Skip to content

Comments

fix(debug): build_id doesn't increase#5015

Merged
hyf0 merged 1 commit intomainfrom
06-19-fix_debug_build_id_doesn_t_increase
Jun 19, 2025
Merged

fix(debug): build_id doesn't increase#5015
hyf0 merged 1 commit intomainfrom
06-19-fix_debug_build_id_doesn_t_increase

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 19, 2025

Afterthought:

For this case, current archtecture makes the rust rolldown more like a part of the rolldown in nodejs instead of a standalone crate.

Copy link
Member Author

hyf0 commented Jun 19, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit a3b4289
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6853c615e5b55d000837550e

@hyf0 hyf0 marked this pull request as ready for review June 19, 2025 08:12
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(48d6c81)
  • pr: 06-19-fix_debug_build_id_doesn_t_increase(a3b4289)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     77.5±3.85ms        ? ?/sec    1.00     76.7±3.45ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     91.3±3.07ms        ? ?/sec    1.00     89.9±4.05ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    116.8±4.52ms        ? ?/sec    1.00    113.9±3.02ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    129.8±2.55ms        ? ?/sec    1.00    128.2±1.98ms        ? ?/sec
bundle/bundle@threejs                                        1.03     42.1±2.46ms        ? ?/sec    1.00     41.0±2.06ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     48.3±1.59ms        ? ?/sec    1.00     48.3±1.06ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    443.4±9.44ms        ? ?/sec    1.00    438.6±7.44ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    515.9±6.77ms        ? ?/sec    1.00    506.6±7.27ms        ? ?/sec
scan/scan@rome_ts                                            1.00     89.2±1.98ms        ? ?/sec    1.00     89.6±2.22ms        ? ?/sec
scan/scan@threejs                                            1.00     31.0±1.99ms        ? ?/sec    1.07     33.1±2.03ms        ? ?/sec
scan/scan@threejs10x                                         1.00    322.8±6.83ms        ? ?/sec    1.02    330.7±6.00ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit 92372c2 Jun 19, 2025
26 checks passed
@hyf0 hyf0 deleted the 06-19-fix_debug_build_id_doesn_t_increase branch June 19, 2025 08:49
hyf0 pushed a commit that referenced this pull request Jun 22, 2025
## [1.0.0-beta.19] - 2025-06-22

### 🚀 Features

- support `OutputOptions#manualChunks` (#5037) by @hyf0
- advanced-chunks: support `advancedChunks#gruop#name` to be function
(#5035) by @hyf0
- rolldown_plugin_import_glob: align with `vitejs/vite#20163` (#5034) by
@shulaoda
- rust/advanced-chunks: support `MatchGroup#name` to be dynamic (#5033)
by @hyf0
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20117`
(#5027) by @shulaoda
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20115`
(#5020) by @shulaoda
- add validation warning for advanced chunks options without groups
(#5009) by @sapphi-red

### 🐛 Bug Fixes

- moduleInfo is not updated when entry module is emitted by
this.emitFile (#5032) by @IWANABETHATGUY
- preserveEntrySignatures: false generates circular imports that hangs
with TLA (#5029) by @IWANABETHATGUY
- rolldown_plugin_build_import_analysis: align pure dynamic import
handling with rolldown-vite (#5016) by @shulaoda
- plugin/vite-resolve: normalize leading slash (#5013) by @sapphi-red
- debug: `build_id` doesn't increase (#5015) by @hyf0
- side effects in this.emitFile({ type: 'chunk' }) is removed when
preserveEntrySignatures: false is set (#5012) by @IWANABETHATGUY

### 🚜 Refactor

- rolldown_utils: simplify `block_on_spawn_all` (#5019) by @shulaoda
- use `rolldown_utils::futures::block_on` for `WatcherImpl#start`
(#5018) by @shulaoda

### 📚 Documentation

- jsdoc: document `experimental.attachDebugInfo` (#5028) by @hyf0
- clarify that `advancedChunks` options are in bytes (#5022) by
@sapphi-red
- add a note that sequential conversion may break the code (#5024) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- infra: clean up `dist` before building `rolldown` (#5036) by @hyf0
- Align status notice in readme with documentation (#5021) by
@rijkvanzanten

### ❤️ New Contributors

* @rijkvanzanten made their first contribution in
[#5021](#5021)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants