Skip to content

Comments

fix(plugin/vite-resolve): normalize leading slash#5013

Merged
shulaoda merged 5 commits intomainfrom
fix/plugin-vite-resolve-normalize-leading-slashes
Jun 19, 2025
Merged

fix(plugin/vite-resolve): normalize leading slash#5013
shulaoda merged 5 commits intomainfrom
fix/plugin-vite-resolve-normalize-leading-slashes

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 19, 2025 •
edited
Loading

Resovle ids like //absolute/path to align with the Vite's JS resolver.

@netlify
Copy link

netlify bot commented Jun 19, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 7c04a95
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6853dc3d9489f900084472f8

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(e3294a2)
  • pr: fix/plugin-vite-resolve-normalize-leading-slashes(7c04a95)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     77.2±3.11ms        ? ?/sec    1.00     76.3±2.39ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     87.4±2.04ms        ? ?/sec    1.01     87.8±3.07ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    116.4±2.43ms        ? ?/sec    1.00    116.4±2.19ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    128.7±1.88ms        ? ?/sec    1.02    130.7±2.87ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.1±1.21ms        ? ?/sec    1.00     41.2±0.88ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     47.7±1.65ms        ? ?/sec    1.00     47.9±0.93ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    440.0±6.52ms        ? ?/sec    1.00    436.9±5.01ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    512.8±5.30ms        ? ?/sec    1.00    509.6±3.51ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.5±1.31ms        ? ?/sec    1.00     87.2±1.45ms        ? ?/sec
scan/scan@threejs                                            1.02     31.2±1.11ms        ? ?/sec    1.00     30.6±0.61ms        ? ?/sec
scan/scan@threejs10x                                         1.00    320.6±4.43ms        ? ?/sec    1.00    321.3±5.50ms        ? ?/sec

@sapphi-red
Copy link
Member Author

sapphi-red commented Jun 19, 2025

https://github.com/rolldown/rolldown/actions/runs/15752776280

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 19, 2025

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@5013

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@5013

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@5013

rolldown

npm i https://pkg.pr.new/rolldown@5013

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@5013

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@5013

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@5013

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@5013

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@5013

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@5013

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@5013

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@5013

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@5013

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@5013

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@5013

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@5013

commit: ab87b53

@sapphi-red sapphi-red marked this pull request as ready for review June 19, 2025 09:17
graphite-app[bot]
graphite-app bot reviewed Jun 19, 2025
View reviewed changes
sapphi-red and others added 2 commits June 19, 2025 18:44
@sapphi-red @graphite-app
fix: / case
0673c37 
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@autofix-ci
[autofix.ci] apply automated fixes
7c04a95
@shulaoda shulaoda added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit f5b8ec0 Jun 19, 2025
23 checks passed
@shulaoda shulaoda deleted the fix/plugin-vite-resolve-normalize-leading-slashes branch June 19, 2025 14:12
@github-actions github-actions bot mentioned this pull request Jun 22, 2025
Merged
hyf0 pushed a commit that referenced this pull request Jun 22, 2025
@github-actions @shulaoda
release: v1.0.0-beta.19 (#5038)
8950628 
## [1.0.0-beta.19] - 2025-06-22

### 🚀 Features

- support `OutputOptions#manualChunks` (#5037) by @hyf0
- advanced-chunks: support `advancedChunks#gruop#name` to be function
(#5035) by @hyf0
- rolldown_plugin_import_glob: align with `vitejs/vite#20163` (#5034) by
@shulaoda
- rust/advanced-chunks: support `MatchGroup#name` to be dynamic (#5033)
by @hyf0
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20117`
(#5027) by @shulaoda
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20115`
(#5020) by @shulaoda
- add validation warning for advanced chunks options without groups
(#5009) by @sapphi-red

### 🐛 Bug Fixes

- moduleInfo is not updated when entry module is emitted by
this.emitFile (#5032) by @IWANABETHATGUY
- preserveEntrySignatures: false generates circular imports that hangs
with TLA (#5029) by @IWANABETHATGUY
- rolldown_plugin_build_import_analysis: align pure dynamic import
handling with rolldown-vite (#5016) by @shulaoda
- plugin/vite-resolve: normalize leading slash (#5013) by @sapphi-red
- debug: `build_id` doesn't increase (#5015) by @hyf0
- side effects in this.emitFile({ type: 'chunk' }) is removed when
preserveEntrySignatures: false is set (#5012) by @IWANABETHATGUY

### 🚜 Refactor

- rolldown_utils: simplify `block_on_spawn_all` (#5019) by @shulaoda
- use `rolldown_utils::futures::block_on` for `WatcherImpl#start`
(#5018) by @shulaoda

### 📚 Documentation

- jsdoc: document `experimental.attachDebugInfo` (#5028) by @hyf0
- clarify that `advancedChunks` options are in bytes (#5022) by
@sapphi-red
- add a note that sequential conversion may break the code (#5024) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- infra: clean up `dist` before building `rolldown` (#5036) by @hyf0
- Align status notice in readme with documentation (#5021) by
@rijkvanzanten

### ❤️ New Contributors

* @rijkvanzanten made their first contribution in
[#5021](#5021)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

trigger: preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapphi-red @IWANABETHATGUY @shulaoda