Skip to content

Comments

feat: add validation warning for advanced chunks options without groups#5009

Merged
hyf0 merged 2 commits intomainfrom
feat/add-warning-for-advanced-chunks-options-without-groups
Jun 19, 2025
Merged

feat: add validation warning for advanced chunks options without groups#5009
hyf0 merged 2 commits intomainfrom
feat/add-warning-for-advanced-chunks-options-without-groups

Conversation

@sapphi-red
Copy link
Member

Added a warning if advanced chunks options are specified without groups.

close #4932

@netlify
Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 4063ca7
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68537c7d819abf00082d2cb4

@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(ca9d42d)
  • pr: feat/add-warning-for-advanced-chunks-options-without-groups(4063ca7)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.07     80.0±2.83ms        ? ?/sec    1.00     74.8±2.61ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.05     90.7±2.04ms        ? ?/sec    1.00     86.2±4.75ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    116.2±2.07ms        ? ?/sec    1.00    113.8±2.57ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    130.6±1.82ms        ? ?/sec    1.00    127.5±2.43ms        ? ?/sec
bundle/bundle@threejs                                        1.05     42.0±2.28ms        ? ?/sec    1.00     39.9±2.52ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     47.8±0.50ms        ? ?/sec    1.00     47.8±0.86ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02    440.7±5.68ms        ? ?/sec    1.00    432.3±5.88ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    502.4±5.35ms        ? ?/sec    1.01    506.3±9.61ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.5±1.12ms        ? ?/sec    1.03     88.9±1.95ms        ? ?/sec
scan/scan@threejs                                            1.00     31.3±1.99ms        ? ?/sec    1.01     31.5±1.98ms        ? ?/sec
scan/scan@threejs10x                                         1.00    317.9±4.41ms        ? ?/sec    1.02    325.2±5.20ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit e3294a2 Jun 19, 2025
23 checks passed
@hyf0 hyf0 deleted the feat/add-warning-for-advanced-chunks-options-without-groups branch June 19, 2025 06:09
hyf0 pushed a commit that referenced this pull request Jun 22, 2025
## [1.0.0-beta.19] - 2025-06-22

### 🚀 Features

- support `OutputOptions#manualChunks` (#5037) by @hyf0
- advanced-chunks: support `advancedChunks#gruop#name` to be function
(#5035) by @hyf0
- rolldown_plugin_import_glob: align with `vitejs/vite#20163` (#5034) by
@shulaoda
- rust/advanced-chunks: support `MatchGroup#name` to be dynamic (#5033)
by @hyf0
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20117`
(#5027) by @shulaoda
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20115`
(#5020) by @shulaoda
- add validation warning for advanced chunks options without groups
(#5009) by @sapphi-red

### 🐛 Bug Fixes

- moduleInfo is not updated when entry module is emitted by
this.emitFile (#5032) by @IWANABETHATGUY
- preserveEntrySignatures: false generates circular imports that hangs
with TLA (#5029) by @IWANABETHATGUY
- rolldown_plugin_build_import_analysis: align pure dynamic import
handling with rolldown-vite (#5016) by @shulaoda
- plugin/vite-resolve: normalize leading slash (#5013) by @sapphi-red
- debug: `build_id` doesn't increase (#5015) by @hyf0
- side effects in this.emitFile({ type: 'chunk' }) is removed when
preserveEntrySignatures: false is set (#5012) by @IWANABETHATGUY

### 🚜 Refactor

- rolldown_utils: simplify `block_on_spawn_all` (#5019) by @shulaoda
- use `rolldown_utils::futures::block_on` for `WatcherImpl#start`
(#5018) by @shulaoda

### 📚 Documentation

- jsdoc: document `experimental.attachDebugInfo` (#5028) by @hyf0
- clarify that `advancedChunks` options are in bytes (#5022) by
@sapphi-red
- add a note that sequential conversion may break the code (#5024) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- infra: clean up `dist` before building `rolldown` (#5036) by @hyf0
- Align status notice in readme with documentation (#5021) by
@rijkvanzanten

### ❤️ New Contributors

* @rijkvanzanten made their first contribution in
[#5021](#5021)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add experimentalMinChunkSize option

2 participants