Skip to content

Comments

fix(rolldown_plugin_import_glob): correctly handle alias glob patterns#5007

Merged
shulaoda merged 2 commits intomainfrom
06-19-fix_rolldown_plugin_import_glob_correctly_handle_alias_glob_patterns
Jun 19, 2025
Merged

fix(rolldown_plugin_import_glob): correctly handle alias glob patterns#5007
shulaoda merged 2 commits intomainfrom
06-19-fix_rolldown_plugin_import_glob_correctly_handle_alias_glob_patterns

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 18, 2025 •
edited
Loading

closes #4971

@shulaoda shulaoda mentioned this pull request Jun 18, 2025
Merged
@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jun 18, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda requested a review from IWANABETHATGUY June 18, 2025 19:09
@shulaoda shulaoda marked this pull request as ready for review June 18, 2025 19:09
graphite-app[bot]
graphite-app bot reviewed Jun 18, 2025
View reviewed changes
@shulaoda shulaoda force-pushed the 06-19-fix_rolldown_plugin_import_glob_correctly_handle_alias_glob_patterns branch from 84d6ba0 to 92b2908 Compare June 18, 2025 19:13
hyf0
hyf0 reviewed Jun 18, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025 •
edited
Loading

Benchmarks Rust

  • target: 06-19-fix_rolldown_plugin_alias_correctly_handle_resolved_id(c41cb56)
  • pr: 06-19-fix_rolldown_plugin_import_glob_correctly_handle_alias_glob_patterns(1334ba9)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.07     83.8±3.74ms        ? ?/sec    1.00     78.4±2.79ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.06     94.2±2.16ms        ? ?/sec    1.00     88.5±1.74ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    121.0±2.21ms        ? ?/sec    1.00    118.1±2.14ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    136.4±2.11ms        ? ?/sec    1.00    132.3±1.93ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.6±0.60ms        ? ?/sec    1.00     41.5±0.65ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     48.6±1.07ms        ? ?/sec    1.00     48.7±0.73ms        ? ?/sec
bundle/bundle@threejs10x                                     1.05    463.3±4.83ms        ? ?/sec    1.00    442.8±5.28ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    533.6±5.69ms        ? ?/sec    1.00    527.2±9.80ms        ? ?/sec
scan/scan@rome_ts                                            1.00     90.6±1.42ms        ? ?/sec    1.02     92.0±1.86ms        ? ?/sec
scan/scan@threejs                                            1.00     31.5±0.56ms        ? ?/sec    1.00     31.6±0.41ms        ? ?/sec
scan/scan@threejs10x                                         1.01    330.7±5.37ms        ? ?/sec    1.00    329.1±4.35ms        ? ?/sec

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 18, 2025

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@5007

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@5007

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@5007

rolldown

npm i https://pkg.pr.new/rolldown@5007

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@5007

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@5007

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@5007

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@5007

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@5007

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@5007

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@5007

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@5007

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@5007

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@5007

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@5007

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@5007

commit: 92b2908

@shulaoda shulaoda mentioned this pull request Jun 18, 2025
Closed
@shulaoda shulaoda force-pushed the 06-19-fix_rolldown_plugin_alias_correctly_handle_resolved_id branch from 57f4342 to c41cb56 Compare June 19, 2025 03:20
@shulaoda shulaoda force-pushed the 06-19-fix_rolldown_plugin_import_glob_correctly_handle_alias_glob_patterns branch from 92b2908 to 1334ba9 Compare June 19, 2025 03:20
Base automatically changed from 06-19-fix_rolldown_plugin_alias_correctly_handle_resolved_id to main June 19, 2025 03:44
@shulaoda shulaoda added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit e7d6acf Jun 19, 2025
24 of 32 checks passed
@shulaoda shulaoda deleted the 06-19-fix_rolldown_plugin_import_glob_correctly_handle_alias_glob_patterns branch June 19, 2025 03:57
@github-actions github-actions bot mentioned this pull request Jun 19, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 19, 2025
@github-actions @sapphi-red
release: v1.0.0-beta.18 (#5010)
983e2c8 
## [1.0.0-beta.18] - 2025-06-19

### 🚀 Features

- advancedChunks: no need to include dependencies for
`PreserveEntrySignatures::False` too (#5005) by @hyf0
- analyze commonjs module side effects and remove unused module (#5003)
by @IWANABETHATGUY
- specially handling commonjs export stmt side effects (#5002) by
@IWANABETHATGUY
- rolldown: oxc v0.73.2 (#5000) by @Boshen
- debug: attach both `session_id` and `build_id` to debug events (#4994)
by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_import_glob: correctly handle alias glob patterns
(#5007) by @shulaoda
- rolldown_plugin_alias: correctly handle `resolved_id` (#5006) by
@shulaoda
- imported namespace is missing after external import namespace merging
(#4999) by @IWANABETHATGUY
- node: add `experimental.viteMode` to option validator (#4996) by
@sapphi-red
- plugin/vite-resolve: optional peer dep id parse error (#4995) by
@sapphi-red

### 🚜 Refactor

- debug: remove extra mechanism for passing `session_id` and unnecessary
passing of spans (#5001) by @hyf0

### 📚 Documentation

- update description about directive handling (#4992) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.11 (#4863) by
@renovate[bot]
- infra: update changelog configuration in `cliff.toml` (#4961) by
@shulaoda
- infra: add knip to ci (#4991) by @webpro

Co-authored-by: sapphi-red <[email protected]>
@shulaoda shulaoda mentioned this pull request Jun 19, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 19, 2025
@shulaoda
refactor: use rolldown_utils::futures::block_on for `WatcherImpl#st…
40b13c2 
…art` (#5018)

Related to #5007

I wrapped the relevant logic in a `block_on` function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 left review comments

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

trigger: preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: thread 'tokio-runtime-worker' panicked at rolldown_plugin_import_glob: Invalid glob pattern: @/assets/**/*.png

3 participants

@shulaoda @IWANABETHATGUY @hyf0