Skip to content

Comments

fix(rolldown_plugin_alias): correctly handle resolved_id#5006

Merged
shulaoda merged 1 commit intomainfrom
06-19-fix_rolldown_plugin_alias_correctly_handle_resolved_id
Jun 19, 2025
Merged

fix(rolldown_plugin_alias): correctly handle resolved_id#5006
shulaoda merged 1 commit intomainfrom
06-19-fix_rolldown_plugin_alias_correctly_handle_resolved_id

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 18, 2025 •
edited
Loading

Related to #4971

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jun 18, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 18, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit c41cb56
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68538211ba54f30008f9aecb

@shulaoda shulaoda changed the title fix(rolldown_plugin_alias): correctly handle resolved_id fix(rolldown_plugin_alias): correctly handle resolved_id Jun 18, 2025
@shulaoda shulaoda requested a review from IWANABETHATGUY June 18, 2025 18:25
@shulaoda shulaoda marked this pull request as ready for review June 18, 2025 18:25
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(ca9d42d)
  • pr: 06-19-fix_rolldown_plugin_alias_correctly_handle_resolved_id(c41cb56)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     72.7±1.47ms        ? ?/sec    1.00     72.5±1.44ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     83.0±1.18ms        ? ?/sec    1.00     83.2±1.23ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    110.8±1.65ms        ? ?/sec    1.00    111.0±1.61ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    126.5±1.70ms        ? ?/sec    1.00    126.3±1.81ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.2±0.58ms        ? ?/sec    1.02     39.9±2.17ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.1±1.37ms        ? ?/sec    1.01     46.3±0.49ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    431.2±5.12ms        ? ?/sec    1.00    430.7±4.58ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    502.4±3.13ms        ? ?/sec    1.00    502.9±5.44ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.6±2.40ms        ? ?/sec    1.00     86.5±1.14ms        ? ?/sec
scan/scan@threejs                                            1.00     30.1±0.47ms        ? ?/sec    1.02     30.6±1.94ms        ? ?/sec
scan/scan@threejs10x                                         1.00    315.1±3.62ms        ? ?/sec    1.01    318.1±4.81ms        ? ?/sec

@shulaoda shulaoda mentioned this pull request Jun 18, 2025
Merged
hyf0
hyf0 reviewed Jun 18, 2025
View reviewed changes
@shulaoda shulaoda force-pushed the 06-19-fix_rolldown_plugin_alias_correctly_handle_resolved_id branch from 57f4342 to c41cb56 Compare June 19, 2025 03:20
@shulaoda shulaoda added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit 94308ea Jun 19, 2025
23 checks passed
@shulaoda shulaoda deleted the 06-19-fix_rolldown_plugin_alias_correctly_handle_resolved_id branch June 19, 2025 03:44
@github-actions github-actions bot mentioned this pull request Jun 19, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 19, 2025
@github-actions @sapphi-red
release: v1.0.0-beta.18 (#5010)
983e2c8 
## [1.0.0-beta.18] - 2025-06-19

### 🚀 Features

- advancedChunks: no need to include dependencies for
`PreserveEntrySignatures::False` too (#5005) by @hyf0
- analyze commonjs module side effects and remove unused module (#5003)
by @IWANABETHATGUY
- specially handling commonjs export stmt side effects (#5002) by
@IWANABETHATGUY
- rolldown: oxc v0.73.2 (#5000) by @Boshen
- debug: attach both `session_id` and `build_id` to debug events (#4994)
by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_import_glob: correctly handle alias glob patterns
(#5007) by @shulaoda
- rolldown_plugin_alias: correctly handle `resolved_id` (#5006) by
@shulaoda
- imported namespace is missing after external import namespace merging
(#4999) by @IWANABETHATGUY
- node: add `experimental.viteMode` to option validator (#4996) by
@sapphi-red
- plugin/vite-resolve: optional peer dep id parse error (#4995) by
@sapphi-red

### 🚜 Refactor

- debug: remove extra mechanism for passing `session_id` and unnecessary
passing of spans (#5001) by @hyf0

### 📚 Documentation

- update description about directive handling (#4992) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.11 (#4863) by
@renovate[bot]
- infra: update changelog configuration in `cliff.toml` (#4961) by
@shulaoda
- infra: add knip to ci (#4991) by @webpro

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shulaoda @hyf0