Skip to content

Comments

feat: analyze commonjs module side effects and remove unused module#5003

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-18-feat_analyze_commonjs_module_side_effects_and_remove_unused_module
Jun 18, 2025
Merged

feat: analyze commonjs module side effects and remove unused module#5003
IWANABETHATGUY merged 1 commit intomainfrom
06-18-feat_analyze_commonjs_module_side_effects_and_remove_unused_module

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author

IWANABETHATGUY commented Jun 18, 2025

Base automatically changed from 06-18-feat_analyze_commonjs_module_side_effects to main June 18, 2025 10:16
@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-18-feat_analyze_commonjs_module_side_effects_and_remove_unused_module branch from 7116cbd to 599fdc6 Compare June 18, 2025 10:24
@netlify
Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 599fdc6
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/685293e1f8685300081c7b99

@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(997db54)
  • pr: 06-18-feat_analyze_commonjs_module_side_effects_and_remove_unused_module(599fdc6)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.08     75.9±3.27ms        ? ?/sec    1.00     70.6±1.40ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.07     87.1±2.40ms        ? ?/sec    1.00     81.1±1.84ms        ? ?/sec
bundle/bundle@rome_ts                                        1.05    114.8±2.33ms        ? ?/sec    1.00    109.7±1.46ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.04    129.5±2.27ms        ? ?/sec    1.00    123.9±1.42ms        ? ?/sec
bundle/bundle@threejs                                        1.07     42.0±2.86ms        ? ?/sec    1.00     39.3±2.21ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.05     48.0±0.78ms        ? ?/sec    1.00     45.7±0.95ms        ? ?/sec
bundle/bundle@threejs10x                                     1.03    434.6±4.42ms        ? ?/sec    1.00    423.2±3.10ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    506.3±5.92ms        ? ?/sec    1.00    495.8±5.11ms        ? ?/sec
scan/scan@rome_ts                                            1.02     87.1±1.71ms        ? ?/sec    1.00     85.3±1.99ms        ? ?/sec
scan/scan@threejs                                            1.03     30.5±1.94ms        ? ?/sec    1.00     29.6±0.37ms        ? ?/sec
scan/scan@threejs10x                                         1.00    316.6±3.78ms        ? ?/sec    1.00    315.5±6.31ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 18, 2025 10:42
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 95d12e2 Jun 18, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-18-feat_analyze_commonjs_module_side_effects_and_remove_unused_module branch June 18, 2025 10:55
Boshen pushed a commit that referenced this pull request Jun 19, 2025
## [1.0.0-beta.18] - 2025-06-19

### 🚀 Features

- advancedChunks: no need to include dependencies for
`PreserveEntrySignatures::False` too (#5005) by @hyf0
- analyze commonjs module side effects and remove unused module (#5003)
by @IWANABETHATGUY
- specially handling commonjs export stmt side effects (#5002) by
@IWANABETHATGUY
- rolldown: oxc v0.73.2 (#5000) by @Boshen
- debug: attach both `session_id` and `build_id` to debug events (#4994)
by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_import_glob: correctly handle alias glob patterns
(#5007) by @shulaoda
- rolldown_plugin_alias: correctly handle `resolved_id` (#5006) by
@shulaoda
- imported namespace is missing after external import namespace merging
(#4999) by @IWANABETHATGUY
- node: add `experimental.viteMode` to option validator (#4996) by
@sapphi-red
- plugin/vite-resolve: optional peer dep id parse error (#4995) by
@sapphi-red

### 🚜 Refactor

- debug: remove extra mechanism for passing `session_id` and unnecessary
passing of spans (#5001) by @hyf0

### 📚 Documentation

- update description about directive handling (#4992) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.11 (#4863) by
@renovate[bot]
- infra: update changelog configuration in `cliff.toml` (#4961) by
@shulaoda
- infra: add knip to ci (#4991) by @webpro

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants