Skip to content

Comments

feat: specially handling commonjs export stmt side effects#5002

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-18-feat_analyze_commonjs_module_side_effects
Jun 18, 2025
Merged

feat: specially handling commonjs export stmt side effects#5002
IWANABETHATGUY merged 1 commit intomainfrom
06-18-feat_analyze_commonjs_module_side_effects

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 18, 2025

No description provided.

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 18, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 18, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit fca00ba
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68528a979b9a590007607025

@IWANABETHATGUY IWANABETHATGUY changed the title feat: analyze commonjs module side effects feat: specially handling commonjs export stmt side effects Jun 18, 2025
@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-18-feat_analyze_commonjs_module_side_effects branch from 1ec27e3 to 483f840 Compare June 18, 2025 09:41
@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-18-feat_analyze_commonjs_module_side_effects branch from 483f840 to fca00ba Compare June 18, 2025 09:44
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Benchmarks Rust

  • target: main(a46a33a)
  • pr: 06-18-feat_analyze_commonjs_module_side_effects(fca00ba)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     73.7±1.87ms        ? ?/sec    1.00     73.6±1.50ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     83.4±1.91ms        ? ?/sec    1.00     83.8±1.39ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    111.1±3.76ms        ? ?/sec    1.00    111.6±2.89ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    125.0±1.56ms        ? ?/sec    1.01    126.7±1.39ms        ? ?/sec
bundle/bundle@threejs                                        1.02     40.1±2.06ms        ? ?/sec    1.00     39.3±0.64ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.4±0.66ms        ? ?/sec    1.00     46.2±0.61ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    430.9±5.42ms        ? ?/sec    1.01    433.3±5.90ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    499.6±3.53ms        ? ?/sec    1.01    506.1±4.95ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.5±1.44ms        ? ?/sec    1.00     86.6±1.62ms        ? ?/sec
scan/scan@threejs                                            1.00     30.5±2.05ms        ? ?/sec    1.00     30.5±1.83ms        ? ?/sec
scan/scan@threejs10x                                         1.00    317.7±4.98ms        ? ?/sec    1.02    322.8±4.96ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 18, 2025 10:01
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 18, 2025
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Jun 18, 2025
Merged
Merged via the queue into main with commit 997db54 Jun 18, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-18-feat_analyze_commonjs_module_side_effects branch June 18, 2025 10:16
@github-actions github-actions bot mentioned this pull request Jun 19, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 19, 2025
@github-actions @sapphi-red
release: v1.0.0-beta.18 (#5010)
983e2c8 
## [1.0.0-beta.18] - 2025-06-19

### 🚀 Features

- advancedChunks: no need to include dependencies for
`PreserveEntrySignatures::False` too (#5005) by @hyf0
- analyze commonjs module side effects and remove unused module (#5003)
by @IWANABETHATGUY
- specially handling commonjs export stmt side effects (#5002) by
@IWANABETHATGUY
- rolldown: oxc v0.73.2 (#5000) by @Boshen
- debug: attach both `session_id` and `build_id` to debug events (#4994)
by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_import_glob: correctly handle alias glob patterns
(#5007) by @shulaoda
- rolldown_plugin_alias: correctly handle `resolved_id` (#5006) by
@shulaoda
- imported namespace is missing after external import namespace merging
(#4999) by @IWANABETHATGUY
- node: add `experimental.viteMode` to option validator (#4996) by
@sapphi-red
- plugin/vite-resolve: optional peer dep id parse error (#4995) by
@sapphi-red

### 🚜 Refactor

- debug: remove extra mechanism for passing `session_id` and unnecessary
passing of spans (#5001) by @hyf0

### 📚 Documentation

- update description about directive handling (#4992) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.11 (#4863) by
@renovate[bot]
- infra: update changelog configuration in `cliff.toml` (#4961) by
@shulaoda
- infra: add knip to ci (#4991) by @webpro

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0