Skip to content

Comments

refactor(debug): remove extra mechanism for passing session_id and unnecessary passing of spans#5001

Merged
hyf0 merged 1 commit intomainfrom
06-18-refactor_debug_remove_extra_mechanism_for_passing_session_id_and_unnecessary_passing_of_spans
Jun 18, 2025
Merged

refactor(debug): remove extra mechanism for passing session_id and unnecessary passing of spans#5001
hyf0 merged 1 commit intomainfrom
06-18-refactor_debug_remove_extra_mechanism_for_passing_session_id_and_unnecessary_passing_of_spans

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 18, 2025 •
edited
Loading

  • Nothing changes.
  • session_id is now also passed around via context-inject mechanism.
  • Just realize no need to manually pass spans around. They're already connected to each other in an implicit way.

@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Jun 18, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 18, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 127f1c8
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68527a560add9a0008bce5d9

@hyf0 hyf0 marked this pull request as ready for review June 18, 2025 08:35
@hyf0 hyf0 force-pushed the 06-18-refactor_debug_remove_extra_mechanism_for_passing_session_id_and_unnecessary_passing_of_spans branch from cd87163 to 127f1c8 Compare June 18, 2025 08:35
@hyf0 hyf0 enabled auto-merge June 18, 2025 08:43
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Benchmarks Rust

  • target: main(a46a33a)
  • pr: 06-18-refactor_debug_remove_extra_mechanism_for_passing_session_id_and_unnecessary_passing_of_spans(127f1c8)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     72.8±2.12ms        ? ?/sec    1.08     78.8±3.30ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     85.2±1.73ms        ? ?/sec    1.05     89.3±3.59ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    112.3±1.80ms        ? ?/sec    1.02    114.8±1.72ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    125.7±1.58ms        ? ?/sec    1.03    129.6±2.35ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.6±0.89ms        ? ?/sec    1.06     41.9±1.98ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.3±0.38ms        ? ?/sec    1.05     48.5±1.26ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    435.6±7.44ms        ? ?/sec    1.02    443.8±6.30ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    507.6±5.66ms        ? ?/sec    1.01    514.6±3.32ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.8±1.50ms        ? ?/sec    1.02     89.7±1.40ms        ? ?/sec
scan/scan@threejs                                            1.00     31.3±1.73ms        ? ?/sec    1.02     31.8±2.08ms        ? ?/sec
scan/scan@threejs10x                                         1.01    324.1±6.72ms        ? ?/sec    1.00    320.6±5.73ms        ? ?/sec

@hyf0 hyf0 requested a review from IWANABETHATGUY June 18, 2025 10:03
@hyf0 hyf0 disabled auto-merge June 18, 2025 10:03
@hyf0 hyf0 enabled auto-merge June 18, 2025 10:03
@hyf0 hyf0 added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 6cd7196 Jun 18, 2025
23 checks passed
@hyf0 hyf0 deleted the 06-18-refactor_debug_remove_extra_mechanism_for_passing_session_id_and_unnecessary_passing_of_spans branch June 18, 2025 10:25
@github-actions github-actions bot mentioned this pull request Jun 19, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 19, 2025
@github-actions @sapphi-red
release: v1.0.0-beta.18 (#5010)
983e2c8 
## [1.0.0-beta.18] - 2025-06-19

### 🚀 Features

- advancedChunks: no need to include dependencies for
`PreserveEntrySignatures::False` too (#5005) by @hyf0
- analyze commonjs module side effects and remove unused module (#5003)
by @IWANABETHATGUY
- specially handling commonjs export stmt side effects (#5002) by
@IWANABETHATGUY
- rolldown: oxc v0.73.2 (#5000) by @Boshen
- debug: attach both `session_id` and `build_id` to debug events (#4994)
by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_import_glob: correctly handle alias glob patterns
(#5007) by @shulaoda
- rolldown_plugin_alias: correctly handle `resolved_id` (#5006) by
@shulaoda
- imported namespace is missing after external import namespace merging
(#4999) by @IWANABETHATGUY
- node: add `experimental.viteMode` to option validator (#4996) by
@sapphi-red
- plugin/vite-resolve: optional peer dep id parse error (#4995) by
@sapphi-red

### 🚜 Refactor

- debug: remove extra mechanism for passing `session_id` and unnecessary
passing of spans (#5001) by @hyf0

### 📚 Documentation

- update description about directive handling (#4992) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.11 (#4863) by
@renovate[bot]
- infra: update changelog configuration in `cliff.toml` (#4961) by
@shulaoda
- infra: add knip to ci (#4991) by @webpro

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY