Skip to content

Comments

fix: imported namespace is missing after external import namespace merging#4999

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-18-fix_4993
Jun 18, 2025
Merged

fix: imported namespace is missing after external import namespace merging#4999
IWANABETHATGUY merged 1 commit intomainfrom
06-18-fix_4993

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 18, 2025

Closed #4993

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8825ada
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68524a03f3188500081c5d7a

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 4993 fix: imported namespace is missing after external import namespace merging Jun 18, 2025
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 18, 2025 05:05
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 18, 2025
@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     73.3±1.46ms        ? ?/sec    1.08     79.4±2.98ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     84.9±1.97ms        ? ?/sec    1.07     90.7±2.69ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    112.6±4.14ms        ? ?/sec    1.04    117.1±3.76ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    126.6±1.59ms        ? ?/sec    1.04    131.8±3.53ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.7±0.58ms        ? ?/sec    1.07     42.4±1.08ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.8±1.90ms        ? ?/sec    1.03     48.4±0.98ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    442.0±9.38ms        ? ?/sec    1.01    444.4±5.81ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    513.3±8.41ms        ? ?/sec    1.01    515.9±7.47ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.7±1.27ms        ? ?/sec    1.02     89.6±2.13ms        ? ?/sec
scan/scan@threejs                                            1.01     31.5±0.48ms        ? ?/sec    1.00     31.3±0.74ms        ? ?/sec
scan/scan@threejs10x                                         1.00    321.2±3.90ms        ? ?/sec    1.01    325.0±4.77ms        ? ?/sec

Merged via the queue into main with commit e795a60 Jun 18, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-18-fix_4993 branch June 18, 2025 05:30
Boshen pushed a commit that referenced this pull request Jun 19, 2025
## [1.0.0-beta.18] - 2025-06-19

### 🚀 Features

- advancedChunks: no need to include dependencies for
`PreserveEntrySignatures::False` too (#5005) by @hyf0
- analyze commonjs module side effects and remove unused module (#5003)
by @IWANABETHATGUY
- specially handling commonjs export stmt side effects (#5002) by
@IWANABETHATGUY
- rolldown: oxc v0.73.2 (#5000) by @Boshen
- debug: attach both `session_id` and `build_id` to debug events (#4994)
by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_import_glob: correctly handle alias glob patterns
(#5007) by @shulaoda
- rolldown_plugin_alias: correctly handle `resolved_id` (#5006) by
@shulaoda
- imported namespace is missing after external import namespace merging
(#4999) by @IWANABETHATGUY
- node: add `experimental.viteMode` to option validator (#4996) by
@sapphi-red
- plugin/vite-resolve: optional peer dep id parse error (#4995) by
@sapphi-red

### 🚜 Refactor

- debug: remove extra mechanism for passing `session_id` and unnecessary
passing of spans (#5001) by @hyf0

### 📚 Documentation

- update description about directive handling (#4992) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.11 (#4863) by
@renovate[bot]
- infra: update changelog configuration in `cliff.toml` (#4961) by
@shulaoda
- infra: add knip to ci (#4991) by @webpro

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing Imported Namespace

2 participants