Skip to content

Comments

fix(plugin/vite-resolve): optional peer dep id parse error#4995

Merged
shulaoda merged 1 commit intomainfrom
fix/plugin-vite-resolve-optional-peer-dep-id-parse-error
Jun 18, 2025
Merged

fix(plugin/vite-resolve): optional peer dep id parse error#4995
shulaoda merged 1 commit intomainfrom
fix/plugin-vite-resolve-optional-peer-dep-id-parse-error

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 18, 2025

Follow-up to #4980.
It seems the new tests in Vite repo caught a bug.

@sapphi-red
Copy link
Member Author

sapphi-red commented Jun 18, 2025 •
edited
Loading

Vite tests: https://github.com/rolldown/rolldown/actions/runs/15722474091 => passed ✅

@netlify
Copy link

netlify bot commented Jun 18, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 63f3c0b
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/685224a8a5327200084f3237

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Benchmarks Rust

  • target: main(d6b6dbd)
  • pr: fix/plugin-vite-resolve-optional-peer-dep-id-parse-error(63f3c0b)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.08     80.1±2.94ms        ? ?/sec    1.00     73.8±1.54ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.07     92.7±1.83ms        ? ?/sec    1.00     86.2±2.65ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    117.5±2.61ms        ? ?/sec    1.00    113.3±1.63ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    132.3±2.70ms        ? ?/sec    1.00    128.6±1.50ms        ? ?/sec
bundle/bundle@threejs                                        1.04     41.9±2.34ms        ? ?/sec    1.00     40.2±0.61ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     48.5±0.65ms        ? ?/sec    1.00     47.9±2.07ms        ? ?/sec
bundle/bundle@threejs10x                                     1.03    447.6±5.39ms        ? ?/sec    1.00    435.5±4.27ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    524.5±4.44ms        ? ?/sec    1.00    512.7±4.25ms        ? ?/sec
scan/scan@rome_ts                                            1.02     92.2±1.87ms        ? ?/sec    1.00     90.3±2.84ms        ? ?/sec
scan/scan@threejs                                            1.05     32.3±1.94ms        ? ?/sec    1.00     30.8±0.50ms        ? ?/sec
scan/scan@threejs10x                                         1.01    326.5±4.16ms        ? ?/sec    1.00    322.3±4.77ms        ? ?/sec

This was referenced Jun 18, 2025
Merged
Merged
Merged
@shulaoda shulaoda added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 9107a97 Jun 18, 2025
26 checks passed
@shulaoda shulaoda deleted the fix/plugin-vite-resolve-optional-peer-dep-id-parse-error branch June 18, 2025 03:34
@github-actions github-actions bot mentioned this pull request Jun 19, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 19, 2025
@github-actions @sapphi-red
release: v1.0.0-beta.18 (#5010)
983e2c8 
## [1.0.0-beta.18] - 2025-06-19

### 🚀 Features

- advancedChunks: no need to include dependencies for
`PreserveEntrySignatures::False` too (#5005) by @hyf0
- analyze commonjs module side effects and remove unused module (#5003)
by @IWANABETHATGUY
- specially handling commonjs export stmt side effects (#5002) by
@IWANABETHATGUY
- rolldown: oxc v0.73.2 (#5000) by @Boshen
- debug: attach both `session_id` and `build_id` to debug events (#4994)
by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_import_glob: correctly handle alias glob patterns
(#5007) by @shulaoda
- rolldown_plugin_alias: correctly handle `resolved_id` (#5006) by
@shulaoda
- imported namespace is missing after external import namespace merging
(#4999) by @IWANABETHATGUY
- node: add `experimental.viteMode` to option validator (#4996) by
@sapphi-red
- plugin/vite-resolve: optional peer dep id parse error (#4995) by
@sapphi-red

### 🚜 Refactor

- debug: remove extra mechanism for passing `session_id` and unnecessary
passing of spans (#5001) by @hyf0

### 📚 Documentation

- update description about directive handling (#4992) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.11 (#4863) by
@renovate[bot]
- infra: update changelog configuration in `cliff.toml` (#4961) by
@shulaoda
- infra: add knip to ci (#4991) by @webpro

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @shulaoda