Skip to content

Comments

docs: update description about directive handling#4992

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-17-docs_update_description_about_directive_handling
Jun 17, 2025
Merged

docs: update description about directive handling#4992
IWANABETHATGUY merged 1 commit intomainfrom
06-17-docs_update_description_about_directive_handling

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 17, 2025 •
edited
Loading

Closed #4558

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 17, 2025 13:55
@netlify
Copy link

netlify bot commented Jun 17, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit b1f414e
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68517c35daf4260008faf303
😎 Deploy Preview https://deploy-preview-4992--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

graphite-app[bot]
graphite-app bot reviewed Jun 17, 2025
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-17-docs_update_description_about_directive_handling branch from 2b9db16 to aa68160 Compare June 17, 2025 14:04
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(138cdcb)
  • pr: 06-17-docs_update_description_about_directive_handling(b1f414e)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     81.0±2.17ms        ? ?/sec    1.02     83.0±2.88ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     90.5±1.38ms        ? ?/sec    1.01     91.4±2.73ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    118.9±3.48ms        ? ?/sec    1.00    117.5±2.48ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    135.9±4.04ms        ? ?/sec    1.00    134.3±2.54ms        ? ?/sec
bundle/bundle@threejs                                        1.01     43.0±1.11ms        ? ?/sec    1.00     42.4±1.40ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     50.1±1.63ms        ? ?/sec    1.00     48.3±0.52ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    445.2±4.67ms        ? ?/sec    1.00    445.6±5.68ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    528.0±9.46ms        ? ?/sec    1.00    518.5±6.33ms        ? ?/sec
scan/scan@rome_ts                                            1.00     90.3±1.44ms        ? ?/sec    1.01     90.9±1.64ms        ? ?/sec
scan/scan@threejs                                            1.00     31.9±1.54ms        ? ?/sec    1.01     32.3±1.79ms        ? ?/sec
scan/scan@threejs10x                                         1.00    326.3±4.20ms        ? ?/sec    1.05    342.8±6.66ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-17-docs_update_description_about_directive_handling branch from aa68160 to b1f414e Compare June 17, 2025 14:31
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit d6b6dbd Jun 17, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-17-docs_update_description_about_directive_handling branch June 17, 2025 14:51
@github-actions github-actions bot mentioned this pull request Jun 19, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 19, 2025
@github-actions @sapphi-red
release: v1.0.0-beta.18 (#5010)
983e2c8 
## [1.0.0-beta.18] - 2025-06-19

### 🚀 Features

- advancedChunks: no need to include dependencies for
`PreserveEntrySignatures::False` too (#5005) by @hyf0
- analyze commonjs module side effects and remove unused module (#5003)
by @IWANABETHATGUY
- specially handling commonjs export stmt side effects (#5002) by
@IWANABETHATGUY
- rolldown: oxc v0.73.2 (#5000) by @Boshen
- debug: attach both `session_id` and `build_id` to debug events (#4994)
by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_import_glob: correctly handle alias glob patterns
(#5007) by @shulaoda
- rolldown_plugin_alias: correctly handle `resolved_id` (#5006) by
@shulaoda
- imported namespace is missing after external import namespace merging
(#4999) by @IWANABETHATGUY
- node: add `experimental.viteMode` to option validator (#4996) by
@sapphi-red
- plugin/vite-resolve: optional peer dep id parse error (#4995) by
@sapphi-red

### 🚜 Refactor

- debug: remove extra mechanism for passing `session_id` and unnecessary
passing of spans (#5001) by @hyf0

### 📚 Documentation

- update description about directive handling (#4992) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.11 (#4863) by
@renovate[bot]
- infra: update changelog configuration in `cliff.toml` (#4961) by
@shulaoda
- infra: add knip to ci (#4991) by @webpro

Co-authored-by: sapphi-red <[email protected]>
Copilot AI mentioned this pull request Nov 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update doc related to 'use strict' behavior.

2 participants

@IWANABETHATGUY @hyf0