Skip to content

Comments

chore(infra): add knip to ci#4991

Merged
hyf0 merged 5 commits intorolldown:mainfrom
webpro:chore/add-knip-to-ci
Jun 17, 2025
Merged

chore(infra): add knip to ci#4991
hyf0 merged 5 commits intorolldown:mainfrom
webpro:chore/add-knip-to-ci

Conversation

@webpro
Copy link
Contributor

@webpro webpro commented Jun 17, 2025

Now that we've mostly established the package.json dependency exceptions in knip.jsonc we can consider adding knip to CI, so here's that.

@webpro webpro force-pushed the chore/add-knip-to-ci branch from bc4993d to f605ccd Compare June 17, 2025 13:19
@webpro webpro force-pushed the chore/add-knip-to-ci branch from 05ab061 to 2810a5b Compare June 17, 2025 13:45
@webpro webpro marked this pull request as ready for review June 17, 2025 13:55
Copy link
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit!

@hyf0 hyf0 enabled auto-merge June 17, 2025 13:59
@hyf0 hyf0 added this pull request to the merge queue Jun 17, 2025
Merged via the queue into rolldown:main with commit 138cdcb Jun 17, 2025
18 checks passed
@webpro webpro deleted the chore/add-knip-to-ci branch June 17, 2025 14:15
Boshen pushed a commit that referenced this pull request Jun 19, 2025
## [1.0.0-beta.18] - 2025-06-19

### 🚀 Features

- advancedChunks: no need to include dependencies for
`PreserveEntrySignatures::False` too (#5005) by @hyf0
- analyze commonjs module side effects and remove unused module (#5003)
by @IWANABETHATGUY
- specially handling commonjs export stmt side effects (#5002) by
@IWANABETHATGUY
- rolldown: oxc v0.73.2 (#5000) by @Boshen
- debug: attach both `session_id` and `build_id` to debug events (#4994)
by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_import_glob: correctly handle alias glob patterns
(#5007) by @shulaoda
- rolldown_plugin_alias: correctly handle `resolved_id` (#5006) by
@shulaoda
- imported namespace is missing after external import namespace merging
(#4999) by @IWANABETHATGUY
- node: add `experimental.viteMode` to option validator (#4996) by
@sapphi-red
- plugin/vite-resolve: optional peer dep id parse error (#4995) by
@sapphi-red

### 🚜 Refactor

- debug: remove extra mechanism for passing `session_id` and unnecessary
passing of spans (#5001) by @hyf0

### 📚 Documentation

- update description about directive handling (#4992) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.11 (#4863) by
@renovate[bot]
- infra: update changelog configuration in `cliff.toml` (#4961) by
@shulaoda
- infra: add knip to ci (#4991) by @webpro

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants