Skip to content

Comments

feat(binding): always use the same BindingBundler to create BindingBundlerImpl for the same RolldownBuild#4985

Merged
hyf0 merged 1 commit intomainfrom
06-17-feat_binding_always_use_the_bindingbundler_to_create_bindingbundlerimpl_for_the_same_rolldownbuild_
Jun 17, 2025
Merged

feat(binding): always use the same BindingBundler to create BindingBundlerImpl for the same RolldownBuild#4985
hyf0 merged 1 commit intomainfrom
06-17-feat_binding_always_use_the_bindingbundler_to_create_bindingbundlerimpl_for_the_same_rolldownbuild_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 17, 2025

Part of #4134.

This PR makes builds triggered by the same RolldownBuild always belong to the same session/bundler

Copy link
Member Author

hyf0 commented Jun 17, 2025

@hyf0 hyf0 marked this pull request as ready for review June 17, 2025 08:30
@hyf0 hyf0 force-pushed the 06-17-feat_binding_always_use_the_bindingbundler_to_create_bindingbundlerimpl_for_the_same_rolldownbuild_ branch from b29563c to eb80823 Compare June 17, 2025 08:32
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

Benchmarks Rust

  • target: main(36f55b2)
  • pr: 06-17-feat_binding_always_use_the_bindingbundler_to_create_bindingbundlerimpl_for_the_same_rolldownbuild_(a2022b8)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     79.3±2.65ms        ? ?/sec    1.00     77.4±1.94ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.04     92.1±3.10ms        ? ?/sec    1.00     88.3±1.80ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    116.6±2.63ms        ? ?/sec    1.00    116.4±1.68ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    130.2±2.25ms        ? ?/sec    1.01    131.4±2.18ms        ? ?/sec
bundle/bundle@threejs                                        1.02     40.9±2.57ms        ? ?/sec    1.00     40.3±1.04ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     47.2±0.98ms        ? ?/sec    1.01     47.5±0.53ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    445.7±5.23ms        ? ?/sec    1.00    442.5±6.79ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    523.4±8.47ms        ? ?/sec    1.00    519.1±6.40ms        ? ?/sec
scan/scan@rome_ts                                            1.00     90.2±1.74ms        ? ?/sec    1.00     90.0±1.96ms        ? ?/sec
scan/scan@threejs                                            1.02     30.9±1.56ms        ? ?/sec    1.00     30.3±0.45ms        ? ?/sec
scan/scan@threejs10x                                         1.00    324.5±4.97ms        ? ?/sec    1.01    326.7±6.37ms        ? ?/sec

@hyf0 hyf0 changed the title feat(binding): always use the BindingBundler to create BindingBundlerImpl for the same RolldownBuild feat(binding): always use the same BindingBundler to create BindingBundlerImpl for the same RolldownBuild Jun 17, 2025
@hyf0 hyf0 requested a review from IWANABETHATGUY June 17, 2025 08:51
@hyf0 hyf0 force-pushed the 06-17-refactor_binding_rename_bundler_to_bindingbundleimpl_ branch from daa9358 to d50c721 Compare June 17, 2025 09:42
@hyf0 hyf0 force-pushed the 06-17-feat_binding_always_use_the_bindingbundler_to_create_bindingbundlerimpl_for_the_same_rolldownbuild_ branch from eb80823 to 0b4d7bb Compare June 17, 2025 09:42
Base automatically changed from 06-17-refactor_binding_rename_bundler_to_bindingbundleimpl_ to main June 17, 2025 10:03
@hyf0 hyf0 force-pushed the 06-17-feat_binding_always_use_the_bindingbundler_to_create_bindingbundlerimpl_for_the_same_rolldownbuild_ branch from 0b4d7bb to a2022b8 Compare June 17, 2025 10:07
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 17, 2025

Merge activity

  • Jun 17, 10:08 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@netlify
Copy link

netlify bot commented Jun 17, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit a2022b8
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68513e68b48aa50008d2b714
😎 Deploy Preview https://deploy-preview-4985--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hyf0 hyf0 added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit f23af87 Jun 17, 2025
22 checks passed
@hyf0 hyf0 deleted the 06-17-feat_binding_always_use_the_bindingbundler_to_create_bindingbundlerimpl_for_the_same_rolldownbuild_ branch June 17, 2025 10:28
github-actions bot pushed a commit that referenced this pull request Jun 17, 2025
## [1.0.0-beta.17] - 2025-06-17

### 🚀 Features

- binding: feat(binding): always use the same `BindingBundler` to create `BindingBundlerImpl` for the same `RolldownBuild` by @hyf0 in [#4985](#4985)
- debug: feat(debug): cache large string by @hyf0 in [#4882](#4882)
- feat: make require('./foo.json') work as expected even if the json is transformed to JS by a custom plugin by @IWANABETHATGUY in [#4984](#4984)
- feat: add diagnostic for multiple entries with UMD/IIFE formats by @shulaoda in [#4954](#4954)

### 🐛 Bug Fixes

- plugin/vite-resolve: fix(plugin/vite-resolve): importing an optional peer dep should throw an runtime error by @sapphi-red in [#4980](#4980)
- fix: upgrade napi, fix wasm url by @sxzz in [#4958](#4958)
- fix: should rewrite hmr related ast after test if `experimental.hmr` is enabled. by @IWANABETHATGUY in [#4972](#4972)

### 💼 Other

- build: provide `"type": "module"` in `package.json` by @iiio2 in [#4974](#4974)

### 🚜 Refactor

- binding: refactor(binding): rename `Bundler` to `BindingBundleImpl` by @hyf0 in [#4983](#4983)
- rolldown: refactor(rolldown): migrate to ESM package by @sxzz in [#4959](#4959)

### 📚 Documentation

- docs: explain how to transpile legacy decorators by @hyf0 in [#4989](#4989)
- code-splitting: docs(code-splitting): make terms bold instead of wrapped with inline code block by @hyf0 in [#4975](#4975)
- docs: improve advanced chunks by @hyf0 in [#4966](#4966)
- docs: refine code splitting guide by @sapphi-red in [#4969](#4969)

### 🧪 Testing

- test: place empty `package.json` to prevent all files to be treated as node mode by @sapphi-red in [#4979](#4979)

### ⚙️ Miscellaneous Tasks

- infra: chore(infra): ensure `pnpm install` for common commands by @hyf0 in [#4987](#4987)
- browser: chore(browser): add `@oxc-project/runtime` by @shulaoda in [#4988](#4988)
- deps: chore(deps): update dependency tsdown to v0.12.8 by @renovate[bot] in [#4977](#4977)
- deps: chore(deps): update npm packages (major) by @renovate[bot] in [#4963](#4963)
- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4967](#4967)
- deps: chore(deps): lock file maintenance rust crates by @renovate[bot] in [#4965](#4965)
- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4964](#4964)
- deps: chore(deps): update github-actions by @renovate[bot] in [#4962](#4962)

### ❤️ New Contributors

* @iiio2 made their first contribution in [#4974](#4974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants