Skip to content

Comments

fix: should rewrite hmr related ast after test if experimental.hmr is enabled.#4972

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-16-fix_4921
Jun 16, 2025
Merged

fix: should rewrite hmr related ast after test if experimental.hmr is enabled.#4972
IWANABETHATGUY merged 1 commit intomainfrom
06-16-fix_4921

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 16, 2025

Closed #4921

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 72bdeb3
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/684fc13ea93ae40008fce816

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 16, 2025 07:01
@IWANABETHATGUY IWANABETHATGUY changed the title fix: 4921 fix: no entry found for key Jun 16, 2025
@IWANABETHATGUY IWANABETHATGUY changed the title fix: no entry found for key fix: should rewrite hmr related ast after test if hmr is enabled. Jun 16, 2025
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 16, 2025
@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     73.9±1.99ms        ? ?/sec    1.06     78.3±1.80ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     88.7±3.49ms        ? ?/sec    1.00     87.9±1.55ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    111.5±2.02ms        ? ?/sec    1.02    113.3±1.61ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    127.5±1.50ms        ? ?/sec    1.01    128.5±1.52ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.8±2.26ms        ? ?/sec    1.01     40.3±0.76ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     45.9±0.49ms        ? ?/sec    1.02     47.0±0.46ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02   447.0±11.85ms        ? ?/sec    1.00    437.2±4.97ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    515.9±6.88ms        ? ?/sec    1.00    512.1±6.15ms        ? ?/sec
scan/scan@rome_ts                                            1.00     89.5±1.41ms        ? ?/sec    1.00     89.9±1.88ms        ? ?/sec
scan/scan@threejs                                            1.00     30.9±0.92ms        ? ?/sec    1.02     31.5±1.88ms        ? ?/sec
scan/scan@threejs10x                                         1.00    326.1±5.35ms        ? ?/sec    1.01    329.1±8.27ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY changed the title fix: should rewrite hmr related ast after test if hmr is enabled. fix: should rewrite hmr related ast after test if experimental.hmr is enabled. Jun 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 16, 2025
@IWANABETHATGUY IWANABETHATGUY merged commit 1c3bbc3 into main Jun 16, 2025
28 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-16-fix_4921 branch June 16, 2025 07:29
github-actions bot pushed a commit that referenced this pull request Jun 17, 2025
## [1.0.0-beta.17] - 2025-06-17

### 🚀 Features

- feat: add diagnostic for multiple entries with UMD/IIFE formats by @shulaoda in [#4954](#4954)

### 🐛 Bug Fixes

- plugin/vite-resolve: fix(plugin/vite-resolve): importing an optional peer dep should throw an runtime error by @sapphi-red in [#4980](#4980)
- fix: upgrade napi, fix wasm url by @sxzz in [#4958](#4958)
- fix: should rewrite hmr related ast after test if `experimental.hmr` is enabled. by @IWANABETHATGUY in [#4972](#4972)

### 💼 Other

- build: provide `"type": "module"` in `package.json` by @iiio2 in [#4974](#4974)

### 🚜 Refactor

- rolldown: refactor(rolldown): migrate to ESM package by @sxzz in [#4959](#4959)

### 📚 Documentation

- code-splitting: docs(code-splitting): make terms bold instead of wrapped with inline code block by @hyf0 in [#4975](#4975)
- docs: improve advanced chunks by @hyf0 in [#4966](#4966)
- docs: refine code splitting guide by @sapphi-red in [#4969](#4969)

### 🧪 Testing

- test: place empty `package.json` to prevent all files to be treated as node mode by @sapphi-red in [#4979](#4979)

### ⚙️ Miscellaneous Tasks

- deps: chore(deps): update dependency tsdown to v0.12.8 by @renovate[bot] in [#4977](#4977)
- deps: chore(deps): update npm packages (major) by @renovate[bot] in [#4963](#4963)
- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4967](#4967)
- deps: chore(deps): lock file maintenance rust crates by @renovate[bot] in [#4965](#4965)
- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4964](#4964)
- deps: chore(deps): update github-actions by @renovate[bot] in [#4962](#4962)

### ❤️ New Contributors

* @iiio2 made their first contribution in [#4974](#4974)
github-actions bot pushed a commit that referenced this pull request Jun 17, 2025
## [1.0.0-beta.17] - 2025-06-17

### 🚀 Features

- binding: feat(binding): always use the same `BindingBundler` to create `BindingBundlerImpl` for the same `RolldownBuild` by @hyf0 in [#4985](#4985)
- debug: feat(debug): cache large string by @hyf0 in [#4882](#4882)
- feat: make require('./foo.json') work as expected even if the json is transformed to JS by a custom plugin by @IWANABETHATGUY in [#4984](#4984)
- feat: add diagnostic for multiple entries with UMD/IIFE formats by @shulaoda in [#4954](#4954)

### 🐛 Bug Fixes

- plugin/vite-resolve: fix(plugin/vite-resolve): importing an optional peer dep should throw an runtime error by @sapphi-red in [#4980](#4980)
- fix: upgrade napi, fix wasm url by @sxzz in [#4958](#4958)
- fix: should rewrite hmr related ast after test if `experimental.hmr` is enabled. by @IWANABETHATGUY in [#4972](#4972)

### 💼 Other

- build: provide `"type": "module"` in `package.json` by @iiio2 in [#4974](#4974)

### 🚜 Refactor

- binding: refactor(binding): rename `Bundler` to `BindingBundleImpl` by @hyf0 in [#4983](#4983)
- rolldown: refactor(rolldown): migrate to ESM package by @sxzz in [#4959](#4959)

### 📚 Documentation

- docs: explain how to transpile legacy decorators by @hyf0 in [#4989](#4989)
- code-splitting: docs(code-splitting): make terms bold instead of wrapped with inline code block by @hyf0 in [#4975](#4975)
- docs: improve advanced chunks by @hyf0 in [#4966](#4966)
- docs: refine code splitting guide by @sapphi-red in [#4969](#4969)

### 🧪 Testing

- test: place empty `package.json` to prevent all files to be treated as node mode by @sapphi-red in [#4979](#4979)

### ⚙️ Miscellaneous Tasks

- infra: chore(infra): ensure `pnpm install` for common commands by @hyf0 in [#4987](#4987)
- browser: chore(browser): add `@oxc-project/runtime` by @shulaoda in [#4988](#4988)
- deps: chore(deps): update dependency tsdown to v0.12.8 by @renovate[bot] in [#4977](#4977)
- deps: chore(deps): update npm packages (major) by @renovate[bot] in [#4963](#4963)
- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4967](#4967)
- deps: chore(deps): lock file maintenance rust crates by @renovate[bot] in [#4965](#4965)
- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4964](#4964)
- deps: chore(deps): update github-actions by @renovate[bot] in [#4962](#4962)

### ❤️ New Contributors

* @iiio2 made their first contribution in [#4974](#4974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: no entry found for key

2 participants