Skip to content

Comments

docs: improve advanced chunks#4966

Merged
hyf0 merged 11 commits intomainfrom
06-16-docs_imrpove_advanced_chunks
Jun 16, 2025
Merged

docs: improve advanced chunks#4966
hyf0 merged 11 commits intomainfrom
06-16-docs_imrpove_advanced_chunks

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 15, 2025

No description provided.

@hyf0 hyf0 marked this pull request as ready for review June 15, 2025 19:38
Copy link
Member Author

hyf0 commented Jun 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 15, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit f124df2
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/684fd2d3db46660008e33a70
😎 Deploy Preview https://deploy-preview-4966--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@sapphi-red sapphi-red changed the title docs: imrpove advanced chunks docs: improve advanced chunks Jun 16, 2025
@Boshen Boshen requested review from sapphi-red and yyx990803 June 16, 2025 02:18
hyf0 and others added 2 commits June 16, 2025 11:32
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Jun 16, 2025
Refined code splitting guide as it was linked from advanced chunks guide
and I read it through to review #4966.

The main changes are:

- remove unordered lists whether it's not "listing" anything
- explain before examples and then, map the abstract explanation and
concrete examples
hyf0 and others added 3 commits June 16, 2025 15:21
Co-authored-by: 翠 <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
hyf0 and others added 2 commits June 16, 2025 15:25
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@hyf0
Copy link
Member Author

hyf0 commented Jun 16, 2025

Notes:

I think we need to mention the Cache-Control header somewhere as we assume that is set.

It may be worth adding a note that using a function that was tree-shaken in the previous bundle will invalidate the library chunk.

@hyf0 hyf0 requested a review from shulaoda June 16, 2025 11:53
@hyf0 hyf0 enabled auto-merge June 16, 2025 11:57
@hyf0 hyf0 added this pull request to the merge queue Jun 16, 2025
Merged via the queue into main with commit 9d09628 Jun 16, 2025
20 checks passed
@hyf0 hyf0 deleted the 06-16-docs_imrpove_advanced_chunks branch June 16, 2025 12:09
github-actions bot pushed a commit that referenced this pull request Jun 17, 2025
## [1.0.0-beta.17] - 2025-06-17

### 🚀 Features

- feat: add diagnostic for multiple entries with UMD/IIFE formats by @shulaoda in [#4954](#4954)

### 🐛 Bug Fixes

- plugin/vite-resolve: fix(plugin/vite-resolve): importing an optional peer dep should throw an runtime error by @sapphi-red in [#4980](#4980)
- fix: upgrade napi, fix wasm url by @sxzz in [#4958](#4958)
- fix: should rewrite hmr related ast after test if `experimental.hmr` is enabled. by @IWANABETHATGUY in [#4972](#4972)

### 💼 Other

- build: provide `"type": "module"` in `package.json` by @iiio2 in [#4974](#4974)

### 🚜 Refactor

- rolldown: refactor(rolldown): migrate to ESM package by @sxzz in [#4959](#4959)

### 📚 Documentation

- code-splitting: docs(code-splitting): make terms bold instead of wrapped with inline code block by @hyf0 in [#4975](#4975)
- docs: improve advanced chunks by @hyf0 in [#4966](#4966)
- docs: refine code splitting guide by @sapphi-red in [#4969](#4969)

### 🧪 Testing

- test: place empty `package.json` to prevent all files to be treated as node mode by @sapphi-red in [#4979](#4979)

### ⚙️ Miscellaneous Tasks

- deps: chore(deps): update dependency tsdown to v0.12.8 by @renovate[bot] in [#4977](#4977)
- deps: chore(deps): update npm packages (major) by @renovate[bot] in [#4963](#4963)
- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4967](#4967)
- deps: chore(deps): lock file maintenance rust crates by @renovate[bot] in [#4965](#4965)
- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4964](#4964)
- deps: chore(deps): update github-actions by @renovate[bot] in [#4962](#4962)

### ❤️ New Contributors

* @iiio2 made their first contribution in [#4974](#4974)
github-actions bot pushed a commit that referenced this pull request Jun 17, 2025
## [1.0.0-beta.17] - 2025-06-17

### 🚀 Features

- binding: feat(binding): always use the same `BindingBundler` to create `BindingBundlerImpl` for the same `RolldownBuild` by @hyf0 in [#4985](#4985)
- debug: feat(debug): cache large string by @hyf0 in [#4882](#4882)
- feat: make require('./foo.json') work as expected even if the json is transformed to JS by a custom plugin by @IWANABETHATGUY in [#4984](#4984)
- feat: add diagnostic for multiple entries with UMD/IIFE formats by @shulaoda in [#4954](#4954)

### 🐛 Bug Fixes

- plugin/vite-resolve: fix(plugin/vite-resolve): importing an optional peer dep should throw an runtime error by @sapphi-red in [#4980](#4980)
- fix: upgrade napi, fix wasm url by @sxzz in [#4958](#4958)
- fix: should rewrite hmr related ast after test if `experimental.hmr` is enabled. by @IWANABETHATGUY in [#4972](#4972)

### 💼 Other

- build: provide `"type": "module"` in `package.json` by @iiio2 in [#4974](#4974)

### 🚜 Refactor

- binding: refactor(binding): rename `Bundler` to `BindingBundleImpl` by @hyf0 in [#4983](#4983)
- rolldown: refactor(rolldown): migrate to ESM package by @sxzz in [#4959](#4959)

### 📚 Documentation

- docs: explain how to transpile legacy decorators by @hyf0 in [#4989](#4989)
- code-splitting: docs(code-splitting): make terms bold instead of wrapped with inline code block by @hyf0 in [#4975](#4975)
- docs: improve advanced chunks by @hyf0 in [#4966](#4966)
- docs: refine code splitting guide by @sapphi-red in [#4969](#4969)

### 🧪 Testing

- test: place empty `package.json` to prevent all files to be treated as node mode by @sapphi-red in [#4979](#4979)

### ⚙️ Miscellaneous Tasks

- infra: chore(infra): ensure `pnpm install` for common commands by @hyf0 in [#4987](#4987)
- browser: chore(browser): add `@oxc-project/runtime` by @shulaoda in [#4988](#4988)
- deps: chore(deps): update dependency tsdown to v0.12.8 by @renovate[bot] in [#4977](#4977)
- deps: chore(deps): update npm packages (major) by @renovate[bot] in [#4963](#4963)
- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4967](#4967)
- deps: chore(deps): lock file maintenance rust crates by @renovate[bot] in [#4965](#4965)
- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4964](#4964)
- deps: chore(deps): update github-actions by @renovate[bot] in [#4962](#4962)

### ❤️ New Contributors

* @iiio2 made their first contribution in [#4974](#4974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants