feat: add diagnostic for multiple entries with UMD/IIFE formats by shulaoda · Pull Request #4954 · rolldown/rolldown

shulaoda · 2025-06-14T00:24:24Z

shulaoda · 2025-06-14T00:24:41Z

feat: add diagnostic for multiple entries with UMD/IIFE formats #4954 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-06-14T00:24:43Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`a9435d1`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/684f88e2db46660008e1629b

github-actions · 2025-06-14T00:39:00Z

Benchmarks Rust

target: main(19072ac)
pr: 06-14-feat_add_diagnostic_for_multiple_entries_with_umd_iife_formats(a9435d1)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.09     84.8±2.40ms        ? ?/sec    1.00     77.8±2.01ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.07     96.0±2.21ms        ? ?/sec    1.00     89.8±2.71ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    122.4±3.98ms        ? ?/sec    1.00    117.5±1.95ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.06    136.6±2.04ms        ? ?/sec    1.00    129.4±2.27ms        ? ?/sec
bundle/bundle@threejs                                        1.07     45.0±2.53ms        ? ?/sec    1.00     42.2±0.64ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     50.8±0.85ms        ? ?/sec    1.00     48.8±0.57ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01   445.2±10.16ms        ? ?/sec    1.00    441.7±5.12ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    509.4±7.42ms        ? ?/sec    1.01    514.5±7.99ms        ? ?/sec
scan/scan@rome_ts                                            1.03     90.6±2.48ms        ? ?/sec    1.00     87.7±1.21ms        ? ?/sec
scan/scan@threejs                                            1.00     31.0±1.99ms        ? ?/sec    1.01     31.3±0.96ms        ? ?/sec
scan/scan@threejs10x                                         1.02    328.8±6.72ms        ? ?/sec    1.00    323.1±4.10ms        ? ?/sec

TheAlexLichter · 2025-06-14T19:58:51Z

As a note: esbuild builds fine with the reproduction from #4952 and the following setup:

import { build } from 'esbuild';

const config = {
  entryPoints: {
    test: './src/index.ts',
    test1: './src/index.ts',
  },
  format: 'iife',
  outdir: 'dist',
};

build(config).catch(() => process.exit(1));

Is that intentional difference from esbuild wanted / Should I raise another issue that goes beyond the panic?

shulaoda · 2025-06-15T07:50:05Z

Is that intentional difference from esbuild wanted / Should I raise another issue that goes beyond the panic?

The current behavior is aligned with rollup. I’ll explore whether it’s possible to make the experience consistent with esbuild.

@shulaoda

## [1.0.0-beta.17] - 2025-06-17 ### 🚀 Features - feat: add diagnostic for multiple entries with UMD/IIFE formats by @shulaoda in [#4954](#4954) ### 🐛 Bug Fixes - plugin/vite-resolve: fix(plugin/vite-resolve): importing an optional peer dep should throw an runtime error by @sapphi-red in [#4980](#4980) - fix: upgrade napi, fix wasm url by @sxzz in [#4958](#4958) - fix: should rewrite hmr related ast after test if `experimental.hmr` is enabled. by @IWANABETHATGUY in [#4972](#4972) ### 💼 Other - build: provide `"type": "module"` in `package.json` by @iiio2 in [#4974](#4974) ### 🚜 Refactor - rolldown: refactor(rolldown): migrate to ESM package by @sxzz in [#4959](#4959) ### 📚 Documentation - code-splitting: docs(code-splitting): make terms bold instead of wrapped with inline code block by @hyf0 in [#4975](#4975) - docs: improve advanced chunks by @hyf0 in [#4966](#4966) - docs: refine code splitting guide by @sapphi-red in [#4969](#4969) ### 🧪 Testing - test: place empty `package.json` to prevent all files to be treated as node mode by @sapphi-red in [#4979](#4979) ### ⚙️ Miscellaneous Tasks - deps: chore(deps): update dependency tsdown to v0.12.8 by @renovate[bot] in [#4977](#4977) - deps: chore(deps): update npm packages (major) by @renovate[bot] in [#4963](#4963) - deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4967](#4967) - deps: chore(deps): lock file maintenance rust crates by @renovate[bot] in [#4965](#4965) - deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4964](#4964) - deps: chore(deps): update github-actions by @renovate[bot] in [#4962](#4962) ### ❤️ New Contributors * @iiio2 made their first contribution in [#4974](#4974)

@hyf0

## [1.0.0-beta.17] - 2025-06-17 ### 🚀 Features - binding: feat(binding): always use the same `BindingBundler` to create `BindingBundlerImpl` for the same `RolldownBuild` by @hyf0 in [#4985](#4985) - debug: feat(debug): cache large string by @hyf0 in [#4882](#4882) - feat: make require('./foo.json') work as expected even if the json is transformed to JS by a custom plugin by @IWANABETHATGUY in [#4984](#4984) - feat: add diagnostic for multiple entries with UMD/IIFE formats by @shulaoda in [#4954](#4954) ### 🐛 Bug Fixes - plugin/vite-resolve: fix(plugin/vite-resolve): importing an optional peer dep should throw an runtime error by @sapphi-red in [#4980](#4980) - fix: upgrade napi, fix wasm url by @sxzz in [#4958](#4958) - fix: should rewrite hmr related ast after test if `experimental.hmr` is enabled. by @IWANABETHATGUY in [#4972](#4972) ### 💼 Other - build: provide `"type": "module"` in `package.json` by @iiio2 in [#4974](#4974) ### 🚜 Refactor - binding: refactor(binding): rename `Bundler` to `BindingBundleImpl` by @hyf0 in [#4983](#4983) - rolldown: refactor(rolldown): migrate to ESM package by @sxzz in [#4959](#4959) ### 📚 Documentation - docs: explain how to transpile legacy decorators by @hyf0 in [#4989](#4989) - code-splitting: docs(code-splitting): make terms bold instead of wrapped with inline code block by @hyf0 in [#4975](#4975) - docs: improve advanced chunks by @hyf0 in [#4966](#4966) - docs: refine code splitting guide by @sapphi-red in [#4969](#4969) ### 🧪 Testing - test: place empty `package.json` to prevent all files to be treated as node mode by @sapphi-red in [#4979](#4979) ### ⚙️ Miscellaneous Tasks - infra: chore(infra): ensure `pnpm install` for common commands by @hyf0 in [#4987](#4987) - browser: chore(browser): add `@oxc-project/runtime` by @shulaoda in [#4988](#4988) - deps: chore(deps): update dependency tsdown to v0.12.8 by @renovate[bot] in [#4977](#4977) - deps: chore(deps): update npm packages (major) by @renovate[bot] in [#4963](#4963) - deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4967](#4967) - deps: chore(deps): lock file maintenance rust crates by @renovate[bot] in [#4965](#4965) - deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4964](#4964) - deps: chore(deps): update github-actions by @renovate[bot] in [#4962](#4962) ### ❤️ New Contributors * @iiio2 made their first contribution in [#4974](#4974)

shulaoda marked this pull request as ready for review June 14, 2025 00:24

shulaoda force-pushed the 06-14-feat_add_diagnostic_for_multiple_entries_with_umd_iife_formats branch from c1ab4dc to f99f063 Compare June 14, 2025 03:46

shulaoda requested review from IWANABETHATGUY and hyf0 and removed request for IWANABETHATGUY June 16, 2025 03:00

feat: add diagnostic for multiple entries with UMD/IIFE formats

a9435d1

shulaoda force-pushed the 06-14-feat_add_diagnostic_for_multiple_entries_with_umd_iife_formats branch from f99f063 to a9435d1 Compare June 16, 2025 03:00

IWANABETHATGUY approved these changes Jun 16, 2025

View reviewed changes

shulaoda added this pull request to the merge queue Jun 16, 2025

Merged via the queue into main with commit d6ce1a1 Jun 16, 2025
23 checks passed

shulaoda deleted the 06-14-feat_add_diagnostic_for_multiple_entries_with_umd_iife_formats branch June 16, 2025 04:46

shulaoda mentioned this pull request Jun 16, 2025

Try to align multi-entry behavior for IIFE with esbuild #4970

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: add diagnostic for multiple entries with UMD/IIFE formats#4954

feat: add diagnostic for multiple entries with UMD/IIFE formats#4954
shulaoda merged 1 commit intomainfrom
06-14-feat_add_diagnostic_for_multiple_entries_with_umd_iife_formats

shulaoda commented Jun 14, 2025 •

edited

Loading

Uh oh!

shulaoda commented Jun 14, 2025

Uh oh!

netlify bot commented Jun 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 14, 2025 •

edited

Loading

Uh oh!

TheAlexLichter commented Jun 14, 2025

Uh oh!

shulaoda commented Jun 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

shulaoda commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Jun 14, 2025

Uh oh!

netlify bot commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

github-actions bot commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

TheAlexLichter commented Jun 14, 2025

Uh oh!

shulaoda commented Jun 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shulaoda commented Jun 14, 2025 •

edited

Loading

netlify bot commented Jun 14, 2025 •

edited

Loading

github-actions bot commented Jun 14, 2025 •

edited

Loading