Skip to content

Comments

fix: deduplicated entry points when have same id, name, and filename #4947

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-13-fix_4946
Jun 13, 2025
Merged

fix: deduplicated entry points when have same id, name, and filename #4947
IWANABETHATGUY merged 1 commit intomainfrom
06-13-fix_4946

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 13, 2025 •
edited
Loading

partial fixed #4946

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 13, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 13, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 25166b9
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/684bfb97a7f31e0008243cdc
😎 Deploy Preview https://deploy-preview-4947--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 13, 2025 10:22
@IWANABETHATGUY IWANABETHATGUY changed the title fix: 4946 fix: deduplicated entry points when have same id, name, and filename Jun 13, 2025
@IWANABETHATGUY
Copy link
Member Author

IWANABETHATGUY commented Jun 13, 2025 •
edited
Loading

Since our referenceId is added to entryPoint, which affects the hash of EntryPoint, the case related to thie.emitFile yields a different result compared to rollup. I will try to refactor it first and then address the remaining issues.Here is an example, https://stackblitz.com/edit/rolldown-rolldown-starter-stackblitz-swq5umnb?file=rolldown.config.mjs,package.json,src%2Fentry.js,rollup-dist%2Fentry.js

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     74.3±2.00ms        ? ?/sec    1.00     74.2±1.57ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     85.7±1.21ms        ? ?/sec    1.00     84.9±1.39ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    113.6±3.01ms        ? ?/sec    1.00    112.2±1.45ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    126.7±1.88ms        ? ?/sec    1.00    127.0±1.52ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.6±1.33ms        ? ?/sec    1.02     40.3±2.21ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     45.8±0.40ms        ? ?/sec    1.02     46.6±0.43ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    430.3±5.26ms        ? ?/sec    1.01    433.5±4.12ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    503.0±3.46ms        ? ?/sec    1.00    503.4±4.45ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.4±1.18ms        ? ?/sec    1.00     87.4±1.29ms        ? ?/sec
scan/scan@threejs                                            1.03     31.2±1.86ms        ? ?/sec    1.00     30.3±0.76ms        ? ?/sec
scan/scan@threejs10x                                         1.00    318.7±4.84ms        ? ?/sec    1.00    318.3±4.14ms        ? ?/sec

Merged via the queue into main with commit 97f0d7d Jun 13, 2025
25 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-13-fix_4946 branch June 13, 2025 10:41
github-actions bot pushed a commit that referenced this pull request Jun 15, 2025
@shulaoda @github-actions
release: v1.0.0-beta.16
5a8075e 
## [1.0.0-beta.16] - 2025-06-15

### 🚀 Features

- rolldown: feat(rolldown): oxc v0.73.0 by @Boshen in [#4948](#4948)
- types: feat(types): generate HMR runtime types by @sapphi-red in [#4928](#4928)
- rolldown_plugin_build_import_analysis: feat(rolldown_plugin_build_import_analysis): align with rolldown-vite by @shulaoda in [#4931](#4931)
- feat: allow to configure`experimental#attachDebugInfo: 'none'` to disable generating `#region` comments by @TheAlexLichter in [#4918](#4918)

### 🐛 Bug Fixes

- fix: deduplicate entry point by @IWANABETHATGUY in [#4956](#4956)
- fix: diagnostic message on minified code is too long to be readable by @IWANABETHATGUY in [#4950](#4950)
- fix: deduplicated entry points when have same `id`, `name`, and `filename` by @IWANABETHATGUY in [#4947](#4947)
- fix: unbundle does not work with outExtensions by @IWANABETHATGUY in [#4945](#4945)
- types: fix(types): remove `undefined` from return type of `generateHmrPatch` and `hmrInvalidate` by @sapphi-red in [#4943](#4943)
- fix: handle error in `hmrInvalidate` by @sapphi-red in [#4942](#4942)
- rolldown_plugin_build_import_analysis: fix(rolldown_plugin_build_import_analysis): preload helper is imported even if it’s not needed by @shulaoda in [#4936](#4936)
- hmr: fix(hmr): avoid panic after syntax error by @sapphi-red in [#4898](#4898)
- strictExecutionOrder: fix(strictExecutionOrder): ensure initialization chain of entry exports by @hyf0 in [#4933](#4933)
- fix: should not panic when meet a syntax error in watch mode. by @IWANABETHATGUY in [#4926](#4926)
- fix: regression, id filter normalization for windows is not working by @IWANABETHATGUY in [#4922](#4922)
- rolldown_plugin_json: fix(rolldown_plugin_json): incorrect default JSON export by @shulaoda in [#4924](#4924)

### 🚜 Refactor

- refactor: avoid unnecessary collect by @IWANABETHATGUY in [#4949](#4949)
- refactor: get normalized options via binding by @IWANABETHATGUY in [#4938](#4938)
- refactor: include DevRuntime base class even if custom HMR implementation is passed by @sapphi-red in [#4929](#4929)

### 📚 Documentation

- docs: clarify minifier state by @TheAlexLichter in [#4953](#4953)
- docs: drafting code splitting by @hyf0 in [#4951](#4951)
- docs: add link to repl by @sxzz in [#4917](#4917)
- pluginutils: docs(pluginutils): add example to simple filter functions by @sapphi-red in [#4915](#4915)

### 🧪 Testing

- test: add testcase for normalized output options by @IWANABETHATGUY in [#4939](#4939)
- hmr: test(hmr): enable `expectExecuted` for `generatePatchError` test by @sapphi-red in [#4937](#4937)
- test: evaluate hmr tests in node by @sapphi-red in [#4930](#4930)
- test: add "non used export" hmr test by @sapphi-red in [#4900](#4900)
- test: enable expectExecuted in HMR tests by @sapphi-red in [#4927](#4927)

### ⚙️ Miscellaneous Tasks

- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4866](#4866)
- infra: chore(infra): remove comments related to `cspell` by @shulaoda in [#4940](#4940)
- ci: remove cargo bench test by @IWANABETHATGUY in [#4925](#4925)
@Boshen Boshen mentioned this pull request Jun 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: generate n + 1 chunks, if user declare same entry n times

2 participants

@IWANABETHATGUY @hyf0