Skip to content

Comments

fix(rolldown_plugin_build_import_analysis): preload helper is imported even if it’s not needed#4936

Merged
shulaoda merged 1 commit intomainfrom
06-13-fix_rolldown_plugin_build_import_analysis_preload_helper_is_imported_even_if_it_s_not_needed
Jun 12, 2025
Merged

fix(rolldown_plugin_build_import_analysis): preload helper is imported even if it’s not needed#4936
shulaoda merged 1 commit intomainfrom
06-13-fix_rolldown_plugin_build_import_analysis_preload_helper_is_imported_even_if_it_s_not_needed

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 12, 2025 •
edited
Loading

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jun 12, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 12, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 076ac24
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/684b05ba4d050800081d9394

@shulaoda shulaoda requested a review from IWANABETHATGUY June 12, 2025 16:52
@shulaoda shulaoda marked this pull request as ready for review June 12, 2025 16:52
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2025

Benchmarks Rust

  • target: main(441d3aa)
  • pr: 06-13-fix_rolldown_plugin_build_import_analysis_preload_helper_is_imported_even_if_it_s_not_needed(076ac24)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     79.2±3.37ms        ? ?/sec    1.04     82.7±3.31ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     90.0±3.05ms        ? ?/sec    1.02     91.7±2.59ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    117.9±3.68ms        ? ?/sec    1.01    119.2±3.43ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    131.9±2.62ms        ? ?/sec    1.00    132.2±2.28ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.0±2.30ms        ? ?/sec    1.03     42.1±1.24ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     48.7±1.06ms        ? ?/sec    1.01     49.4±1.12ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    446.3±6.97ms        ? ?/sec    1.03    457.7±8.11ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    527.0±7.77ms        ? ?/sec    1.02    539.6±8.34ms        ? ?/sec
scan/scan@rome_ts                                            1.00     93.0±3.05ms        ? ?/sec    1.04     97.1±2.81ms        ? ?/sec
scan/scan@threejs                                            1.00     31.9±1.37ms        ? ?/sec    1.05     33.3±0.72ms        ? ?/sec
scan/scan@threejs10x                                         1.00    336.2±6.79ms        ? ?/sec    1.02    342.0±7.12ms        ? ?/sec

@shulaoda shulaoda added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit ae74451 Jun 12, 2025
25 checks passed
@shulaoda shulaoda deleted the 06-13-fix_rolldown_plugin_build_import_analysis_preload_helper_is_imported_even_if_it_s_not_needed branch June 12, 2025 17:16
github-actions bot pushed a commit that referenced this pull request Jun 15, 2025
@shulaoda @github-actions
release: v1.0.0-beta.16
5a8075e 
## [1.0.0-beta.16] - 2025-06-15

### 🚀 Features

- rolldown: feat(rolldown): oxc v0.73.0 by @Boshen in [#4948](#4948)
- types: feat(types): generate HMR runtime types by @sapphi-red in [#4928](#4928)
- rolldown_plugin_build_import_analysis: feat(rolldown_plugin_build_import_analysis): align with rolldown-vite by @shulaoda in [#4931](#4931)
- feat: allow to configure`experimental#attachDebugInfo: 'none'` to disable generating `#region` comments by @TheAlexLichter in [#4918](#4918)

### 🐛 Bug Fixes

- fix: deduplicate entry point by @IWANABETHATGUY in [#4956](#4956)
- fix: diagnostic message on minified code is too long to be readable by @IWANABETHATGUY in [#4950](#4950)
- fix: deduplicated entry points when have same `id`, `name`, and `filename` by @IWANABETHATGUY in [#4947](#4947)
- fix: unbundle does not work with outExtensions by @IWANABETHATGUY in [#4945](#4945)
- types: fix(types): remove `undefined` from return type of `generateHmrPatch` and `hmrInvalidate` by @sapphi-red in [#4943](#4943)
- fix: handle error in `hmrInvalidate` by @sapphi-red in [#4942](#4942)
- rolldown_plugin_build_import_analysis: fix(rolldown_plugin_build_import_analysis): preload helper is imported even if it’s not needed by @shulaoda in [#4936](#4936)
- hmr: fix(hmr): avoid panic after syntax error by @sapphi-red in [#4898](#4898)
- strictExecutionOrder: fix(strictExecutionOrder): ensure initialization chain of entry exports by @hyf0 in [#4933](#4933)
- fix: should not panic when meet a syntax error in watch mode. by @IWANABETHATGUY in [#4926](#4926)
- fix: regression, id filter normalization for windows is not working by @IWANABETHATGUY in [#4922](#4922)
- rolldown_plugin_json: fix(rolldown_plugin_json): incorrect default JSON export by @shulaoda in [#4924](#4924)

### 🚜 Refactor

- refactor: avoid unnecessary collect by @IWANABETHATGUY in [#4949](#4949)
- refactor: get normalized options via binding by @IWANABETHATGUY in [#4938](#4938)
- refactor: include DevRuntime base class even if custom HMR implementation is passed by @sapphi-red in [#4929](#4929)

### 📚 Documentation

- docs: clarify minifier state by @TheAlexLichter in [#4953](#4953)
- docs: drafting code splitting by @hyf0 in [#4951](#4951)
- docs: add link to repl by @sxzz in [#4917](#4917)
- pluginutils: docs(pluginutils): add example to simple filter functions by @sapphi-red in [#4915](#4915)

### 🧪 Testing

- test: add testcase for normalized output options by @IWANABETHATGUY in [#4939](#4939)
- hmr: test(hmr): enable `expectExecuted` for `generatePatchError` test by @sapphi-red in [#4937](#4937)
- test: evaluate hmr tests in node by @sapphi-red in [#4930](#4930)
- test: add "non used export" hmr test by @sapphi-red in [#4900](#4900)
- test: enable expectExecuted in HMR tests by @sapphi-red in [#4927](#4927)

### ⚙️ Miscellaneous Tasks

- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4866](#4866)
- infra: chore(infra): remove comments related to `cspell` by @shulaoda in [#4940](#4940)
- ci: remove cargo bench test by @IWANABETHATGUY in [#4925](#4925)
@Boshen Boshen mentioned this pull request Jun 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Preload helper is imported even if it’s not needed

2 participants

@shulaoda @IWANABETHATGUY