Skip to content

Comments

test: evaluate hmr tests in node#4930

Merged
sapphi-red merged 1 commit intomainfrom
06-12-test_evaluate_hmr_tests_in_node
Jun 13, 2025
Merged

test: evaluate hmr tests in node#4930
sapphi-red merged 1 commit intomainfrom
06-12-test_evaluate_hmr_tests_in_node

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 12, 2025

Added HMR runtime for tests and made the test to evaluate HMR patch chunks.

Copy link
Member Author

sapphi-red commented Jun 12, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2025

Benchmarks Rust

  • target: main(c1f7223)
  • pr: 06-12-test_evaluate_hmr_tests_in_node(16fba10)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     76.5±2.05ms        ? ?/sec    1.09     83.2±4.54ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     86.9±1.82ms        ? ?/sec    1.07     92.8±3.78ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    116.5±3.41ms        ? ?/sec    1.01    117.9±2.36ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    130.1±3.21ms        ? ?/sec    1.02    132.6±3.26ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.2±2.05ms        ? ?/sec    1.01     41.7±1.31ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.7±0.72ms        ? ?/sec    1.02     47.9±0.80ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    440.5±5.57ms        ? ?/sec    1.01    445.0±6.64ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    527.4±9.30ms        ? ?/sec    1.00    520.5±8.14ms        ? ?/sec
scan/scan@rome_ts                                            1.00     92.8±2.17ms        ? ?/sec    1.01     93.7±2.23ms        ? ?/sec
scan/scan@threejs                                            1.00     31.5±0.57ms        ? ?/sec    1.04     32.9±2.05ms        ? ?/sec
scan/scan@threejs10x                                         1.00    329.4±5.97ms        ? ?/sec    1.02    335.6±6.20ms        ? ?/sec

@sapphi-red sapphi-red force-pushed the 06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed branch from 3b75483 to 9db37a4 Compare June 12, 2025 08:59
@sapphi-red sapphi-red force-pushed the 06-12-test_evaluate_hmr_tests_in_node branch from 2d515fe to ba403ba Compare June 12, 2025 08:59
@sapphi-red sapphi-red marked this pull request as ready for review June 12, 2025 08:59
@sapphi-red sapphi-red force-pushed the 06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed branch from 9db37a4 to 81c25c1 Compare June 12, 2025 09:26
@sapphi-red sapphi-red force-pushed the 06-12-test_evaluate_hmr_tests_in_node branch from ba403ba to 0a32417 Compare June 12, 2025 09:26
@shulaoda shulaoda force-pushed the 06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed branch from 81c25c1 to 16ea4ce Compare June 12, 2025 15:19
Base automatically changed from 06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed to main June 12, 2025 15:47
@sapphi-red sapphi-red force-pushed the 06-12-test_evaluate_hmr_tests_in_node branch from 0a32417 to 16fba10 Compare June 13, 2025 02:24
@netlify
Copy link

netlify bot commented Jun 13, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 16fba10
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/684b8be4549c270008affde8

@sapphi-red sapphi-red enabled auto-merge June 13, 2025 02:30
@sapphi-red sapphi-red added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit 579823a Jun 13, 2025
24 checks passed
@sapphi-red sapphi-red deleted the 06-12-test_evaluate_hmr_tests_in_node branch June 13, 2025 02:41
github-actions bot pushed a commit that referenced this pull request Jun 15, 2025
## [1.0.0-beta.16] - 2025-06-15

### 🚀 Features

- rolldown: feat(rolldown): oxc v0.73.0 by @Boshen in [#4948](#4948)
- types: feat(types): generate HMR runtime types by @sapphi-red in [#4928](#4928)
- rolldown_plugin_build_import_analysis: feat(rolldown_plugin_build_import_analysis): align with rolldown-vite by @shulaoda in [#4931](#4931)
- feat: allow to configure`experimental#attachDebugInfo: 'none'` to disable generating `#region` comments by @TheAlexLichter in [#4918](#4918)

### 🐛 Bug Fixes

- fix: deduplicate entry point by @IWANABETHATGUY in [#4956](#4956)
- fix: diagnostic message on minified code is too long to be readable by @IWANABETHATGUY in [#4950](#4950)
- fix: deduplicated entry points when have same `id`, `name`, and `filename` by @IWANABETHATGUY in [#4947](#4947)
- fix: unbundle does not work with outExtensions by @IWANABETHATGUY in [#4945](#4945)
- types: fix(types): remove `undefined` from return type of `generateHmrPatch` and `hmrInvalidate` by @sapphi-red in [#4943](#4943)
- fix: handle error in `hmrInvalidate` by @sapphi-red in [#4942](#4942)
- rolldown_plugin_build_import_analysis: fix(rolldown_plugin_build_import_analysis): preload helper is imported even if it’s not needed by @shulaoda in [#4936](#4936)
- hmr: fix(hmr): avoid panic after syntax error by @sapphi-red in [#4898](#4898)
- strictExecutionOrder: fix(strictExecutionOrder): ensure initialization chain of entry exports by @hyf0 in [#4933](#4933)
- fix: should not panic when meet a syntax error in watch mode. by @IWANABETHATGUY in [#4926](#4926)
- fix: regression, id filter normalization for windows is not working by @IWANABETHATGUY in [#4922](#4922)
- rolldown_plugin_json: fix(rolldown_plugin_json): incorrect default JSON export by @shulaoda in [#4924](#4924)

### 🚜 Refactor

- refactor: avoid unnecessary collect by @IWANABETHATGUY in [#4949](#4949)
- refactor: get normalized options via binding by @IWANABETHATGUY in [#4938](#4938)
- refactor: include DevRuntime base class even if custom HMR implementation is passed by @sapphi-red in [#4929](#4929)

### 📚 Documentation

- docs: clarify minifier state by @TheAlexLichter in [#4953](#4953)
- docs: drafting code splitting by @hyf0 in [#4951](#4951)
- docs: add link to repl by @sxzz in [#4917](#4917)
- pluginutils: docs(pluginutils): add example to simple filter functions by @sapphi-red in [#4915](#4915)

### 🧪 Testing

- test: add testcase for normalized output options by @IWANABETHATGUY in [#4939](#4939)
- hmr: test(hmr): enable `expectExecuted` for `generatePatchError` test by @sapphi-red in [#4937](#4937)
- test: evaluate hmr tests in node by @sapphi-red in [#4930](#4930)
- test: add "non used export" hmr test by @sapphi-red in [#4900](#4900)
- test: enable expectExecuted in HMR tests by @sapphi-red in [#4927](#4927)

### ⚙️ Miscellaneous Tasks

- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4866](#4866)
- infra: chore(infra): remove comments related to `cspell` by @shulaoda in [#4940](#4940)
- ci: remove cargo bench test by @IWANABETHATGUY in [#4925](#4925)
@Boshen Boshen mentioned this pull request Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants