Skip to content

Comments

refactor: include DevRuntime base class even if custom HMR implementation is passed#4929

Merged
shulaoda merged 1 commit intomainfrom
06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed
Jun 12, 2025
Merged

refactor: include DevRuntime base class even if custom HMR implementation is passed#4929
shulaoda merged 1 commit intomainfrom
06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 12, 2025

Split the HMR runtime into two parts and inject the commonly needed part even if the custom implementation is used.

Copy link
Member Author

sapphi-red commented Jun 12, 2025

@sapphi-red sapphi-red changed the base branch from 06-12-feat_types_generate_hmr_runtime_types to graphite-base/4929 June 12, 2025 08:55
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2025

Benchmarks Rust

  • target: main(78f35ad)
  • pr: 06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed(16ea4ce)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     78.0±2.06ms        ? ?/sec    1.01     78.4±3.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     86.9±2.36ms        ? ?/sec    1.00     86.5±1.82ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    116.7±2.79ms        ? ?/sec    1.00    114.9±2.16ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    129.6±2.63ms        ? ?/sec    1.01    130.4±2.72ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.6±2.23ms        ? ?/sec    1.03     41.8±2.91ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     48.9±2.17ms        ? ?/sec    1.00     48.8±0.75ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    442.0±7.68ms        ? ?/sec    1.01    444.9±7.31ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    517.0±5.15ms        ? ?/sec    1.00    518.4±7.03ms        ? ?/sec
scan/scan@rome_ts                                            1.02     90.0±1.63ms        ? ?/sec    1.00     87.8±1.32ms        ? ?/sec
scan/scan@threejs                                            1.04     32.6±1.64ms        ? ?/sec    1.00     31.4±1.90ms        ? ?/sec
scan/scan@threejs10x                                         1.02    331.9±7.58ms        ? ?/sec    1.00    325.9±5.13ms        ? ?/sec

@sapphi-red sapphi-red force-pushed the graphite-base/4929 branch from b3fbcd8 to e61bc25 Compare June 12, 2025 08:59
@sapphi-red sapphi-red force-pushed the 06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed branch from 3b75483 to 9db37a4 Compare June 12, 2025 08:59
@sapphi-red sapphi-red changed the base branch from graphite-base/4929 to 06-12-feat_types_generate_hmr_runtime_types June 12, 2025 08:59
@sapphi-red sapphi-red marked this pull request as ready for review June 12, 2025 08:59
@sapphi-red sapphi-red force-pushed the 06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed branch from 9db37a4 to 81c25c1 Compare June 12, 2025 09:26
@shulaoda shulaoda force-pushed the 06-12-feat_types_generate_hmr_runtime_types branch from e61bc25 to 5c73a18 Compare June 12, 2025 14:32
Base automatically changed from 06-12-feat_types_generate_hmr_runtime_types to main June 12, 2025 14:51
@shulaoda shulaoda force-pushed the 06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed branch from 81c25c1 to 16ea4ce Compare June 12, 2025 15:19
@shulaoda shulaoda enabled auto-merge June 12, 2025 15:20
@netlify
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 16ea4ce
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/684af010c2985f00085aa13b
😎 Deploy Preview https://deploy-preview-4929--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shulaoda shulaoda added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@shulaoda shulaoda added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit 441d3aa Jun 12, 2025
23 checks passed
@shulaoda shulaoda deleted the 06-12-refactor_include_devruntime_base_class_even_if_custom_hmr_implementation_is_passed branch June 12, 2025 15:47
github-actions bot pushed a commit that referenced this pull request Jun 15, 2025
## [1.0.0-beta.16] - 2025-06-15

### 🚀 Features

- rolldown: feat(rolldown): oxc v0.73.0 by @Boshen in [#4948](#4948)
- types: feat(types): generate HMR runtime types by @sapphi-red in [#4928](#4928)
- rolldown_plugin_build_import_analysis: feat(rolldown_plugin_build_import_analysis): align with rolldown-vite by @shulaoda in [#4931](#4931)
- feat: allow to configure`experimental#attachDebugInfo: 'none'` to disable generating `#region` comments by @TheAlexLichter in [#4918](#4918)

### 🐛 Bug Fixes

- fix: deduplicate entry point by @IWANABETHATGUY in [#4956](#4956)
- fix: diagnostic message on minified code is too long to be readable by @IWANABETHATGUY in [#4950](#4950)
- fix: deduplicated entry points when have same `id`, `name`, and `filename` by @IWANABETHATGUY in [#4947](#4947)
- fix: unbundle does not work with outExtensions by @IWANABETHATGUY in [#4945](#4945)
- types: fix(types): remove `undefined` from return type of `generateHmrPatch` and `hmrInvalidate` by @sapphi-red in [#4943](#4943)
- fix: handle error in `hmrInvalidate` by @sapphi-red in [#4942](#4942)
- rolldown_plugin_build_import_analysis: fix(rolldown_plugin_build_import_analysis): preload helper is imported even if it’s not needed by @shulaoda in [#4936](#4936)
- hmr: fix(hmr): avoid panic after syntax error by @sapphi-red in [#4898](#4898)
- strictExecutionOrder: fix(strictExecutionOrder): ensure initialization chain of entry exports by @hyf0 in [#4933](#4933)
- fix: should not panic when meet a syntax error in watch mode. by @IWANABETHATGUY in [#4926](#4926)
- fix: regression, id filter normalization for windows is not working by @IWANABETHATGUY in [#4922](#4922)
- rolldown_plugin_json: fix(rolldown_plugin_json): incorrect default JSON export by @shulaoda in [#4924](#4924)

### 🚜 Refactor

- refactor: avoid unnecessary collect by @IWANABETHATGUY in [#4949](#4949)
- refactor: get normalized options via binding by @IWANABETHATGUY in [#4938](#4938)
- refactor: include DevRuntime base class even if custom HMR implementation is passed by @sapphi-red in [#4929](#4929)

### 📚 Documentation

- docs: clarify minifier state by @TheAlexLichter in [#4953](#4953)
- docs: drafting code splitting by @hyf0 in [#4951](#4951)
- docs: add link to repl by @sxzz in [#4917](#4917)
- pluginutils: docs(pluginutils): add example to simple filter functions by @sapphi-red in [#4915](#4915)

### 🧪 Testing

- test: add testcase for normalized output options by @IWANABETHATGUY in [#4939](#4939)
- hmr: test(hmr): enable `expectExecuted` for `generatePatchError` test by @sapphi-red in [#4937](#4937)
- test: evaluate hmr tests in node by @sapphi-red in [#4930](#4930)
- test: add "non used export" hmr test by @sapphi-red in [#4900](#4900)
- test: enable expectExecuted in HMR tests by @sapphi-red in [#4927](#4927)

### ⚙️ Miscellaneous Tasks

- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4866](#4866)
- infra: chore(infra): remove comments related to `cspell` by @shulaoda in [#4940](#4940)
- ci: remove cargo bench test by @IWANABETHATGUY in [#4925](#4925)
@Boshen Boshen mentioned this pull request Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants