Skip to content

Comments

fix: regression, id filter normalization for windows is not working#4922

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-12-fix_4609
Jun 12, 2025
Merged

fix: regression, id filter normalization for windows is not working#4922
IWANABETHATGUY merged 1 commit intomainfrom
06-12-fix_4609

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 12, 2025

Closed #4609

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 12, 2025 06:05
@netlify
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b270156
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/684a7cb16ba7df000816a185

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 4609 fix: regression, id filter normalization for windows is not working Jun 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2025

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.04     83.6±8.60ms        ? ?/sec    1.00     80.0±7.88ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.05     96.2±9.70ms        ? ?/sec    1.00     92.0±7.98ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02   124.5±10.96ms        ? ?/sec    1.00   122.6±10.18ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.05   139.6±10.76ms        ? ?/sec    1.00    132.5±6.75ms        ? ?/sec
bundle/bundle@threejs                                        1.03     45.0±3.81ms        ? ?/sec    1.00     43.6±4.80ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.03     51.2±6.91ms        ? ?/sec    1.00     49.5±3.24ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01   476.8±29.39ms        ? ?/sec    1.00   471.1±29.70ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02   555.9±37.18ms        ? ?/sec    1.00   543.1±27.10ms        ? ?/sec
scan/scan@rome_ts                                            1.00     94.9±6.14ms        ? ?/sec    1.01     96.3±8.41ms        ? ?/sec
scan/scan@threejs                                            1.02     32.1±2.21ms        ? ?/sec    1.00     31.4±1.99ms        ? ?/sec
scan/scan@threejs10x                                         1.03   348.6±20.33ms        ? ?/sec    1.00   339.2±14.98ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit 63b8400 Jun 12, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-12-fix_4609 branch June 12, 2025 07:30
github-actions bot pushed a commit that referenced this pull request Jun 15, 2025
## [1.0.0-beta.16] - 2025-06-15

### 🚀 Features

- rolldown: feat(rolldown): oxc v0.73.0 by @Boshen in [#4948](#4948)
- types: feat(types): generate HMR runtime types by @sapphi-red in [#4928](#4928)
- rolldown_plugin_build_import_analysis: feat(rolldown_plugin_build_import_analysis): align with rolldown-vite by @shulaoda in [#4931](#4931)
- feat: allow to configure`experimental#attachDebugInfo: 'none'` to disable generating `#region` comments by @TheAlexLichter in [#4918](#4918)

### 🐛 Bug Fixes

- fix: deduplicate entry point by @IWANABETHATGUY in [#4956](#4956)
- fix: diagnostic message on minified code is too long to be readable by @IWANABETHATGUY in [#4950](#4950)
- fix: deduplicated entry points when have same `id`, `name`, and `filename` by @IWANABETHATGUY in [#4947](#4947)
- fix: unbundle does not work with outExtensions by @IWANABETHATGUY in [#4945](#4945)
- types: fix(types): remove `undefined` from return type of `generateHmrPatch` and `hmrInvalidate` by @sapphi-red in [#4943](#4943)
- fix: handle error in `hmrInvalidate` by @sapphi-red in [#4942](#4942)
- rolldown_plugin_build_import_analysis: fix(rolldown_plugin_build_import_analysis): preload helper is imported even if it’s not needed by @shulaoda in [#4936](#4936)
- hmr: fix(hmr): avoid panic after syntax error by @sapphi-red in [#4898](#4898)
- strictExecutionOrder: fix(strictExecutionOrder): ensure initialization chain of entry exports by @hyf0 in [#4933](#4933)
- fix: should not panic when meet a syntax error in watch mode. by @IWANABETHATGUY in [#4926](#4926)
- fix: regression, id filter normalization for windows is not working by @IWANABETHATGUY in [#4922](#4922)
- rolldown_plugin_json: fix(rolldown_plugin_json): incorrect default JSON export by @shulaoda in [#4924](#4924)

### 🚜 Refactor

- refactor: avoid unnecessary collect by @IWANABETHATGUY in [#4949](#4949)
- refactor: get normalized options via binding by @IWANABETHATGUY in [#4938](#4938)
- refactor: include DevRuntime base class even if custom HMR implementation is passed by @sapphi-red in [#4929](#4929)

### 📚 Documentation

- docs: clarify minifier state by @TheAlexLichter in [#4953](#4953)
- docs: drafting code splitting by @hyf0 in [#4951](#4951)
- docs: add link to repl by @sxzz in [#4917](#4917)
- pluginutils: docs(pluginutils): add example to simple filter functions by @sapphi-red in [#4915](#4915)

### 🧪 Testing

- test: add testcase for normalized output options by @IWANABETHATGUY in [#4939](#4939)
- hmr: test(hmr): enable `expectExecuted` for `generatePatchError` test by @sapphi-red in [#4937](#4937)
- test: evaluate hmr tests in node by @sapphi-red in [#4930](#4930)
- test: add "non used export" hmr test by @sapphi-red in [#4900](#4900)
- test: enable expectExecuted in HMR tests by @sapphi-red in [#4927](#4927)

### ⚙️ Miscellaneous Tasks

- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4866](#4866)
- infra: chore(infra): remove comments related to `cspell` by @shulaoda in [#4940](#4940)
- ci: remove cargo bench test by @IWANABETHATGUY in [#4925](#4925)
@Boshen Boshen mentioned this pull request Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: regression, id filter normalization for windows is not working

2 participants