Skip to content

Comments

test: copy rollup preserveEntrySignature override-via-plugin test#4910

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-11-test_copy_rollup_preserveentrysignature_override-via-plugin_test
Jun 11, 2025
Merged

test: copy rollup preserveEntrySignature override-via-plugin test#4910
IWANABETHATGUY merged 1 commit intomainfrom
06-11-test_copy_rollup_preserveentrysignature_override-via-plugin_test

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 11, 2025 •
edited
Loading

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 11, 2025 09:39
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 11, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 11, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3f967a6
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68494fb39e263d0008501617

@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-11-test_copy_rollup_preserveentrysignature_override-via-plugin_test branch from f539c9f to 4d3d548 Compare June 11, 2025 09:40
@IWANABETHATGUY
Copy link
Member Author

IWANABETHATGUY commented Jun 11, 2025

Note

Our default option of preserveEntrySignature is strict, also we will not do some chunk optimization when preserveEntrySignature is strict, the rest of the parts should be the same as rollup.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-11-test_copy_rollup_preserveentrysignature_override-via-plugin_test branch from 4d3d548 to 3f967a6 Compare June 11, 2025 09:43
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025

Benchmarks Rust

  • target: main(b4f3890)
  • pr: 06-11-test_copy_rollup_preserveentrysignature_override-via-plugin_test(3f967a6)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     74.7±1.74ms        ? ?/sec    1.00     73.3±1.80ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     85.6±1.36ms        ? ?/sec    1.00     83.7±1.26ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    115.0±3.43ms        ? ?/sec    1.00    112.6±2.40ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    128.2±1.82ms        ? ?/sec    1.00    127.4±2.28ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.5±0.40ms        ? ?/sec    1.01     40.0±2.29ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.6±1.39ms        ? ?/sec    1.00     46.5±0.96ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    433.7±4.33ms        ? ?/sec    1.00    435.0±5.42ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    507.3±2.98ms        ? ?/sec    1.00    509.6±5.48ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.3±1.25ms        ? ?/sec    1.03     90.9±1.58ms        ? ?/sec
scan/scan@threejs                                            1.01     31.0±1.83ms        ? ?/sec    1.00     30.7±0.42ms        ? ?/sec
scan/scan@threejs10x                                         1.00    325.2±4.15ms        ? ?/sec    1.01    328.4±5.85ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 71bef5e Jun 11, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-11-test_copy_rollup_preserveentrysignature_override-via-plugin_test branch June 11, 2025 10:12
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
@shulaoda @github-actions
release: v1.0.0-beta.15
b32cf0e 
## [1.0.0-beta.15] - 2025-06-11

### 🚀 Features

- feat: make native json plugin callable by @shulaoda in [#4908](#4908)
- feat: support preserveSignature in `this.emitFile` by @IWANABETHATGUY in [#4895](#4895)
- rolldown_plugin_module_preload_polyfill: feat(rolldown_plugin_module_preload_polyfill): expose plugin config by @shulaoda in [#4896](#4896)

### 🐛 Bug Fixes

- fix: add missing pathe polyfill by @sxzz in [#4912](#4912)
- node: fix(node): call options hook for experimental_scan by @sapphi-red in [#4911](#4911)
- fix: better `NoEntryPoint` error message by @IWANABETHATGUY in [#4903](#4903)
- fix: fail to bundle when provide entryPoint dynamiclly by @IWANABETHATGUY in [#4902](#4902)

### 🧪 Testing

- pluginutils: test(pluginutils): add query suffix case for `makeIdFiltersToMatchWithQuery` by @sapphi-red in [#4914](#4914)
- test: copy rollup preserveEntrySignature override-via-plugin test by @IWANABETHATGUY in [#4910](#4910)
- test: include error in hmr test snapshots by @sapphi-red in [#4899](#4899)

### ⚙️ Miscellaneous Tasks

- chore: update committed dts by @sapphi-red in [#4913](#4913)
- chore: bump rolldown-ariadne by @IWANABETHATGUY in [#4909](#4909)
- improve prepare release commit message by @Boshen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

@sapphi-red sapphi-red Awaiting requested review from sapphi-red

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0