Merged
Conversation
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
This adaptation is currently only for the JSON plugin, and it might introduce some performance overhead in the dev environment. Is it really worth it — or should we just use the JS JSON plugin during dev instead? @sapphi-red cc |
IWANABETHATGUY
previously approved these changes
Jun 11, 2025
Contributor
Benchmarks Rust |
sapphi-red
approved these changes
Jun 11, 2025
Member
There was a problem hiding this comment.
I tested this native json plugin on https://github.com/sapphi-red/performance-compare and the diff of the native plugin and js plugin was less than 2% (which is within the margin of error). So I think it's worth.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
## [1.0.0-beta.15] - 2025-06-11 ### 🚀 Features - feat: make native json plugin callable by @shulaoda in [#4908](#4908) - feat: support preserveSignature in `this.emitFile` by @IWANABETHATGUY in [#4895](#4895) - rolldown_plugin_module_preload_polyfill: feat(rolldown_plugin_module_preload_polyfill): expose plugin config by @shulaoda in [#4896](#4896) ### 🐛 Bug Fixes - fix: add missing pathe polyfill by @sxzz in [#4912](#4912) - node: fix(node): call options hook for experimental_scan by @sapphi-red in [#4911](#4911) - fix: better `NoEntryPoint` error message by @IWANABETHATGUY in [#4903](#4903) - fix: fail to bundle when provide entryPoint dynamiclly by @IWANABETHATGUY in [#4902](#4902) ### 🧪 Testing - pluginutils: test(pluginutils): add query suffix case for `makeIdFiltersToMatchWithQuery` by @sapphi-red in [#4914](#4914) - test: copy rollup preserveEntrySignature override-via-plugin test by @IWANABETHATGUY in [#4910](#4910) - test: include error in hmr test snapshots by @sapphi-red in [#4899](#4899) ### ⚙️ Miscellaneous Tasks - chore: update committed dts by @sapphi-red in [#4913](#4913) - chore: bump rolldown-ariadne by @IWANABETHATGUY in [#4909](#4909) - improve prepare release commit message by @Boshen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we only have three native plugins that are potentially used in the dev environment:
resolver,wasmFallback, and maybe thisjsonplugin. The rest aren't callable in dev because they either use thetransform_asthook, rely on internal context, or are only used in build environment.Originally posted by @shulaoda in vitejs/rolldown-vite#246 (comment)