Skip to content

Comments

fix: better NoEntryPoint error message#4903

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-11-fix_better_noentrypoint_error_message
Jun 11, 2025
Merged

fix: better NoEntryPoint error message#4903
IWANABETHATGUY merged 1 commit intomainfrom
06-11-fix_better_noentrypoint_error_message

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 11, 2025 •
edited
Loading

Since the error is caused by incorrect configuration, which should not be unhandled.

image

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 11, 2025 03:45
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 11, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Jun 11, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY changed the title fix: better noEntryPoint error message fix: better NoEntryPoint error message Jun 11, 2025
@IWANABETHATGUY IWANABETHATGUY changed the title fix: better NoEntryPoint error message fix: better NoEntryPoint error message Jun 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(318144c)
  • pr: 06-11-fix_better_noentrypoint_error_message(e36ff37)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     74.0±2.28ms        ? ?/sec    1.04     76.8±2.45ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     84.3±1.92ms        ? ?/sec    1.02     85.8±1.97ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    114.4±3.91ms        ? ?/sec    1.00    112.3±1.97ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    126.9±2.08ms        ? ?/sec    1.00    126.8±1.59ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.0±0.71ms        ? ?/sec    1.01     40.5±2.11ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.5±1.42ms        ? ?/sec    1.00     46.5±1.02ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    429.2±5.46ms        ? ?/sec    1.01    431.6±7.48ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    502.4±4.81ms        ? ?/sec    1.00    503.8±5.68ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.4±1.41ms        ? ?/sec    1.02     89.6±2.81ms        ? ?/sec
scan/scan@threejs                                            1.00     31.0±1.98ms        ? ?/sec    1.01     31.2±1.93ms        ? ?/sec
scan/scan@threejs10x                                         1.00    318.9±4.69ms        ? ?/sec    1.02    324.0±4.48ms        ? ?/sec

Base automatically changed from 06-11-fix_fail_to_bundle_when_provide_entrypoint_dynamiclly to main June 11, 2025 04:11
@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-11-fix_better_noentrypoint_error_message branch from 391fe17 to e36ff37 Compare June 11, 2025 04:13
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 11, 2025

Merge activity

  • Jun 11, 4:13 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@netlify
Copy link

netlify bot commented Jun 11, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e36ff37
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68490254faa2cb0008a9b4bd

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 031c0c0 Jun 11, 2025
22 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-11-fix_better_noentrypoint_error_message branch June 11, 2025 04:34
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
@shulaoda @github-actions
release: v1.0.0-beta.15
b32cf0e 
## [1.0.0-beta.15] - 2025-06-11

### 🚀 Features

- feat: make native json plugin callable by @shulaoda in [#4908](#4908)
- feat: support preserveSignature in `this.emitFile` by @IWANABETHATGUY in [#4895](#4895)
- rolldown_plugin_module_preload_polyfill: feat(rolldown_plugin_module_preload_polyfill): expose plugin config by @shulaoda in [#4896](#4896)

### 🐛 Bug Fixes

- fix: add missing pathe polyfill by @sxzz in [#4912](#4912)
- node: fix(node): call options hook for experimental_scan by @sapphi-red in [#4911](#4911)
- fix: better `NoEntryPoint` error message by @IWANABETHATGUY in [#4903](#4903)
- fix: fail to bundle when provide entryPoint dynamiclly by @IWANABETHATGUY in [#4902](#4902)

### 🧪 Testing

- pluginutils: test(pluginutils): add query suffix case for `makeIdFiltersToMatchWithQuery` by @sapphi-red in [#4914](#4914)
- test: copy rollup preserveEntrySignature override-via-plugin test by @IWANABETHATGUY in [#4910](#4910)
- test: include error in hmr test snapshots by @sapphi-red in [#4899](#4899)

### ⚙️ Miscellaneous Tasks

- chore: update committed dts by @sapphi-red in [#4913](#4913)
- chore: bump rolldown-ariadne by @IWANABETHATGUY in [#4909](#4909)
- improve prepare release commit message by @Boshen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @shulaoda