Skip to content

Comments

fix: fail to bundle when provide entryPoint dynamiclly#4902

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-11-fix_fail_to_bundle_when_provide_entrypoint_dynamiclly
Jun 11, 2025
Merged

fix: fail to bundle when provide entryPoint dynamiclly#4902
IWANABETHATGUY merged 1 commit intomainfrom
06-11-fix_fail_to_bundle_when_provide_entrypoint_dynamiclly

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 11, 2025 •
edited
Loading

Closed #4897

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 11, 2025 03:10
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 11, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 11, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit d5df218
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6848f3cfbda7fd0008325356

@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-11-fix_fail_to_bundle_when_provide_entrypoint_dynamiclly branch from a24afc1 to d5df218 Compare June 11, 2025 03:11
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025

Benchmarks Rust

  • target: main(ea7115d)
  • pr: 06-11-fix_fail_to_bundle_when_provide_entrypoint_dynamiclly(d5df218)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.04     74.9±1.58ms        ? ?/sec    1.00     72.1±1.31ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     84.3±1.14ms        ? ?/sec    1.00     84.7±1.63ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    115.4±2.06ms        ? ?/sec    1.00    112.1±2.20ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    127.4±1.46ms        ? ?/sec    1.00    128.1±2.25ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.7±2.13ms        ? ?/sec    1.01     40.2±2.12ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.5±1.81ms        ? ?/sec    1.00     46.3±0.57ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    435.1±4.58ms        ? ?/sec    1.01    439.5±7.14ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    509.1±4.89ms        ? ?/sec    1.00    509.9±9.42ms        ? ?/sec
scan/scan@rome_ts                                            1.00     90.3±1.36ms        ? ?/sec    1.01     90.8±2.69ms        ? ?/sec
scan/scan@threejs                                            1.00     30.6±0.86ms        ? ?/sec    1.00     30.6±1.73ms        ? ?/sec
scan/scan@threejs10x                                         1.00    326.2±6.95ms        ? ?/sec    1.00    324.7±4.86ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Jun 11, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 318144c Jun 11, 2025
24 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-11-fix_fail_to_bundle_when_provide_entrypoint_dynamiclly branch June 11, 2025 04:11
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
@Boshen @github-actions
release: vv1.0.0-beta.15
fe8e7c5 
## [1.0.0-beta.15] - 2025-06-11

### 🚀 Features

- feat: support preserveSignature in `this.emitFile` by @IWANABETHATGUY in [#4895](#4895)
- rolldown_plugin_module_preload_polyfill: feat(rolldown_plugin_module_preload_polyfill): expose plugin config by @shulaoda in [#4896](#4896)

### 🐛 Bug Fixes

- fix: fail to bundle when provide entryPoint dynamiclly by @IWANABETHATGUY in [#4902](#4902)

### 🧪 Testing

- test: include error in hmr test snapshots by @sapphi-red in [#4899](#4899)

### ⚙️ Miscellaneous Tasks

- improve prepare release commit message

### ❤️ New Contributors

* @IWANABETHATGUY made their first contribution in [#4902](#4902)
* @sapphi-red made their first contribution in [#4899](#4899)
* @shulaoda made their first contribution in [#4896](#4896)
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
@shulaoda @github-actions
release: v1.0.0-beta.15
b32cf0e 
## [1.0.0-beta.15] - 2025-06-11

### 🚀 Features

- feat: make native json plugin callable by @shulaoda in [#4908](#4908)
- feat: support preserveSignature in `this.emitFile` by @IWANABETHATGUY in [#4895](#4895)
- rolldown_plugin_module_preload_polyfill: feat(rolldown_plugin_module_preload_polyfill): expose plugin config by @shulaoda in [#4896](#4896)

### 🐛 Bug Fixes

- fix: add missing pathe polyfill by @sxzz in [#4912](#4912)
- node: fix(node): call options hook for experimental_scan by @sapphi-red in [#4911](#4911)
- fix: better `NoEntryPoint` error message by @IWANABETHATGUY in [#4903](#4903)
- fix: fail to bundle when provide entryPoint dynamiclly by @IWANABETHATGUY in [#4902](#4902)

### 🧪 Testing

- pluginutils: test(pluginutils): add query suffix case for `makeIdFiltersToMatchWithQuery` by @sapphi-red in [#4914](#4914)
- test: copy rollup preserveEntrySignature override-via-plugin test by @IWANABETHATGUY in [#4910](#4910)
- test: include error in hmr test snapshots by @sapphi-red in [#4899](#4899)

### ⚙️ Miscellaneous Tasks

- chore: update committed dts by @sapphi-red in [#4913](#4913)
- chore: bump rolldown-ariadne by @IWANABETHATGUY in [#4909](#4909)
- improve prepare release commit message by @Boshen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: fail to bundle when provide entryPoint dynamiclly

2 participants

@IWANABETHATGUY @shulaoda