fix(hmr): avoid panic after syntax error#4898
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
hyf0
reviewed
Jun 10, 2025
crates/rolldown/tests/rolldown/topics/hmr/generate_patch_error/artifacts.snap
Outdated
Show resolved
Hide resolved
Contributor
Benchmarks Rust |
01a794d to
78934fb
Compare
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Base automatically changed from
06-10-test_include_error_in_hmr_test_snapshots
to
main
June 11, 2025 01:40
78934fb to
c0d596f
Compare
sapphi-red
commented
Jun 11, 2025
Member
|
I need some time to understand your code,maybe I should try to fix the panic in watch with incremental build enabled. |
Member
Author
|
FYI the only essential change in this PR is #4898 (comment). The other parts are to make the compilation pass. |
c0d596f to
705e545
Compare
705e545 to
d685cb7
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
I thought using a **mutable reference** may be better than returning the `cache` struct, so that we don't need to worry about forgetting to reassign `cache` in the future. realted to #4898
Base automatically changed from
06-12-fix_should_not_panic_when_meet_a_syntax_error_in_watch_mode
to
main
June 12, 2025 10:21
d685cb7 to
82d49e8
Compare
Member
Author
|
Looks good to me. @IWANABETHATGUY would you approve this PR as I cannot approve it myself? |
IWANABETHATGUY
approved these changes
Jun 12, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
Fixes the panic that happens after generating a HMR patch after syntax error.
82d49e8 to
66aa027
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
~~probably related to #4898,~~ found while trying #4898 (comment) This test fails only when tree shaking is enabled. Enabling tree shaking with HMR is not supported and is disabled now. So I decided not to try fixing it and only keep the tests for now.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 15, 2025
## [1.0.0-beta.16] - 2025-06-15 ### 🚀 Features - rolldown: feat(rolldown): oxc v0.73.0 by @Boshen in [#4948](#4948) - types: feat(types): generate HMR runtime types by @sapphi-red in [#4928](#4928) - rolldown_plugin_build_import_analysis: feat(rolldown_plugin_build_import_analysis): align with rolldown-vite by @shulaoda in [#4931](#4931) - feat: allow to configure`experimental#attachDebugInfo: 'none'` to disable generating `#region` comments by @TheAlexLichter in [#4918](#4918) ### 🐛 Bug Fixes - fix: deduplicate entry point by @IWANABETHATGUY in [#4956](#4956) - fix: diagnostic message on minified code is too long to be readable by @IWANABETHATGUY in [#4950](#4950) - fix: deduplicated entry points when have same `id`, `name`, and `filename` by @IWANABETHATGUY in [#4947](#4947) - fix: unbundle does not work with outExtensions by @IWANABETHATGUY in [#4945](#4945) - types: fix(types): remove `undefined` from return type of `generateHmrPatch` and `hmrInvalidate` by @sapphi-red in [#4943](#4943) - fix: handle error in `hmrInvalidate` by @sapphi-red in [#4942](#4942) - rolldown_plugin_build_import_analysis: fix(rolldown_plugin_build_import_analysis): preload helper is imported even if it’s not needed by @shulaoda in [#4936](#4936) - hmr: fix(hmr): avoid panic after syntax error by @sapphi-red in [#4898](#4898) - strictExecutionOrder: fix(strictExecutionOrder): ensure initialization chain of entry exports by @hyf0 in [#4933](#4933) - fix: should not panic when meet a syntax error in watch mode. by @IWANABETHATGUY in [#4926](#4926) - fix: regression, id filter normalization for windows is not working by @IWANABETHATGUY in [#4922](#4922) - rolldown_plugin_json: fix(rolldown_plugin_json): incorrect default JSON export by @shulaoda in [#4924](#4924) ### 🚜 Refactor - refactor: avoid unnecessary collect by @IWANABETHATGUY in [#4949](#4949) - refactor: get normalized options via binding by @IWANABETHATGUY in [#4938](#4938) - refactor: include DevRuntime base class even if custom HMR implementation is passed by @sapphi-red in [#4929](#4929) ### 📚 Documentation - docs: clarify minifier state by @TheAlexLichter in [#4953](#4953) - docs: drafting code splitting by @hyf0 in [#4951](#4951) - docs: add link to repl by @sxzz in [#4917](#4917) - pluginutils: docs(pluginutils): add example to simple filter functions by @sapphi-red in [#4915](#4915) ### 🧪 Testing - test: add testcase for normalized output options by @IWANABETHATGUY in [#4939](#4939) - hmr: test(hmr): enable `expectExecuted` for `generatePatchError` test by @sapphi-red in [#4937](#4937) - test: evaluate hmr tests in node by @sapphi-red in [#4930](#4930) - test: add "non used export" hmr test by @sapphi-red in [#4900](#4900) - test: enable expectExecuted in HMR tests by @sapphi-red in [#4927](#4927) ### ⚙️ Miscellaneous Tasks - deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4866](#4866) - infra: chore(infra): remove comments related to `cspell` by @shulaoda in [#4940](#4940) - ci: remove cargo bench test by @IWANABETHATGUY in [#4925](#4925)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes the panic that happens after generating a HMR patch after syntax error.