Skip to content

Comments

feat: support preserveSignature in this.emitFile#4895

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-10-feat_support_preservesignature_in_this.emitfile_
Jun 10, 2025
Merged

feat: support preserveSignature in this.emitFile#4895
IWANABETHATGUY merged 1 commit intomainfrom
06-10-feat_support_preservesignature_in_this.emitfile_

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 10, 2025 •
edited
Loading

Closed #3500

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 10, 2025 09:50
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 10, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 10, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit e02f36d
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68480aa4ce84190008dc755f
😎 Deploy Preview https://deploy-preview-4895--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-10-feat_support_preservesignature_in_this.emitfile_ branch from 9793981 to 83ef95c Compare June 10, 2025 09:54
graphite-app[bot]
graphite-app bot reviewed Jun 10, 2025
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY marked this pull request as draft June 10, 2025 10:04
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(6ec031d)
  • pr: 06-10-feat_support_preservesignature_in_this.emitfile_(e02f36d)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     77.1±2.23ms        ? ?/sec    1.01     77.7±2.80ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     88.2±2.87ms        ? ?/sec    1.00     87.9±2.22ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    114.2±3.11ms        ? ?/sec    1.02    116.3±1.95ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    130.1±3.17ms        ? ?/sec    1.01    131.0±2.34ms        ? ?/sec
bundle/bundle@threejs                                        1.01     41.2±2.54ms        ? ?/sec    1.00     40.6±0.90ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     48.4±1.55ms        ? ?/sec    1.00     48.3±1.43ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    438.3±5.61ms        ? ?/sec    1.00    437.8±5.49ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    513.0±6.89ms        ? ?/sec    1.00    512.6±6.44ms        ? ?/sec
scan/scan@rome_ts                                            1.00     89.1±2.01ms        ? ?/sec    1.01     90.2±2.70ms        ? ?/sec
scan/scan@threejs                                            1.02     31.7±1.99ms        ? ?/sec    1.00     31.2±1.97ms        ? ?/sec
scan/scan@threejs10x                                         1.00    321.5±5.13ms        ? ?/sec    1.00    321.3±5.05ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-10-feat_support_preservesignature_in_this.emitfile_ branch from 83ef95c to 56fa121 Compare June 10, 2025 10:33
@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-10-feat_support_preservesignature_in_this.emitfile_ branch from 56fa121 to e02f36d Compare June 10, 2025 10:36
@IWANABETHATGUY
Copy link
Member Author

IWANABETHATGUY commented Jun 10, 2025 •
edited
Loading

a smoke test case added, but I found a bug when using this.emitFile({type: chunk}), will enable rollup test after fix it.

the issue

#4897

the testcase needs to add

https://github.com/rollup/rollup/blob/061a0387c8654222620f602471d66afd3c582048/test/chunking-form/samples/preserve-entry-signatures/override-via-plugin/_config.js#L1-L36

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 10, 2025 10:37
@IWANABETHATGUY
Copy link
Member Author

IWANABETHATGUY commented Jun 10, 2025

@sapphi-red, can you have a try?

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit e80cbfa Jun 10, 2025
44 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-10-feat_support_preservesignature_in_this.emitfile_ branch June 10, 2025 11:10
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 10, 2025

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@4895

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@4895

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@4895

rolldown

npm i https://pkg.pr.new/rolldown@4895

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@4895

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@4895

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@4895

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@4895

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@4895

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@4895

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@4895

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@4895

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@4895

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@4895

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@4895

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@4895

commit: e02f36d

github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
@Boshen @github-actions
release: vv1.0.0-beta.15
fe8e7c5 
## [1.0.0-beta.15] - 2025-06-11

### 🚀 Features

- feat: support preserveSignature in `this.emitFile` by @IWANABETHATGUY in [#4895](#4895)
- rolldown_plugin_module_preload_polyfill: feat(rolldown_plugin_module_preload_polyfill): expose plugin config by @shulaoda in [#4896](#4896)

### 🐛 Bug Fixes

- fix: fail to bundle when provide entryPoint dynamiclly by @IWANABETHATGUY in [#4902](#4902)

### 🧪 Testing

- test: include error in hmr test snapshots by @sapphi-red in [#4899](#4899)

### ⚙️ Miscellaneous Tasks

- improve prepare release commit message

### ❤️ New Contributors

* @IWANABETHATGUY made their first contribution in [#4902](#4902)
* @sapphi-red made their first contribution in [#4899](#4899)
* @shulaoda made their first contribution in [#4896](#4896)
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
@shulaoda @github-actions
release: v1.0.0-beta.15
b32cf0e 
## [1.0.0-beta.15] - 2025-06-11

### 🚀 Features

- feat: make native json plugin callable by @shulaoda in [#4908](#4908)
- feat: support preserveSignature in `this.emitFile` by @IWANABETHATGUY in [#4895](#4895)
- rolldown_plugin_module_preload_polyfill: feat(rolldown_plugin_module_preload_polyfill): expose plugin config by @shulaoda in [#4896](#4896)

### 🐛 Bug Fixes

- fix: add missing pathe polyfill by @sxzz in [#4912](#4912)
- node: fix(node): call options hook for experimental_scan by @sapphi-red in [#4911](#4911)
- fix: better `NoEntryPoint` error message by @IWANABETHATGUY in [#4903](#4903)
- fix: fail to bundle when provide entryPoint dynamiclly by @IWANABETHATGUY in [#4902](#4902)

### 🧪 Testing

- pluginutils: test(pluginutils): add query suffix case for `makeIdFiltersToMatchWithQuery` by @sapphi-red in [#4914](#4914)
- test: copy rollup preserveEntrySignature override-via-plugin test by @IWANABETHATGUY in [#4910](#4910)
- test: include error in hmr test snapshots by @sapphi-red in [#4899](#4899)

### ⚙️ Miscellaneous Tasks

- chore: update committed dts by @sapphi-red in [#4913](#4913)
- chore: bump rolldown-ariadne by @IWANABETHATGUY in [#4909](#4909)
- improve prepare release commit message by @Boshen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

trigger: preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support preserveEntrySignatures option / preserveSignatures in emitFile

2 participants

@IWANABETHATGUY @hyf0