fix: dynamic import does not return exports when preserveEntrySignatures: false is set and the importee is an entry#4891
Merged
IWANABETHATGUY merged 1 commit intomainfrom Jun 10, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IWANABETHATGUY
changed the title
✅ Deploy Preview for rolldown-rs canceled.
|
IWANABETHATGUY
commented
Jun 10, 2025
crates/rolldown/tests/rolldown/misc/preserve_entry_signature/issue-4880/artifacts.snap
Show resolved
Hide resolved
IWANABETHATGUY
force-pushed
the
06-10-fix_4880
branch
from
55800e6 to
ebbed1e
Compare
hyf0
approved these changes
Jun 10, 2025
Member
hyf0
left a comment
hyf0
left a comment
There was a problem hiding this comment.
Just a heads-up, this thing is around me for a long time. A entry could be both a user-defined entry and a dynamic entry.
I used to want to refactor the current structure to allow to express a entry could be both user-defined and dynamic.
However, I don't see any issue caused by it, so I didn't do it.
Not sure if it relates to this PR, just share something I know.
Member
Author
Yeah, the concept indeed error-prone sometimes. |
Contributor
Benchmarks Rust |
Boshen
pushed a commit
that referenced
this pull request
Jun 10, 2025
## [1.0.0-beta.14] - 2025-06-10 ### 💥 BREAKING CHANGES - refactor!: move preserveEntrySignatures from output to input options by @IWANABETHATGUY in [#4871](#4871) ### 🚀 Features - feat(strictExecutionOrder): no need to generate plain chunk imports for addressing side effects by @hyf0 in [#4890](#4890) - feat: make wasm fallback plugin callable in node by @shulaoda in [#4885](#4885) - feat(rolldown_plugin_module_preload_polyfill): align with `rolldown-vite` by @shulaoda in [#4884](#4884) - feat(attachDebugInfo): improve format and distinguish dynamic entries by @hyf0 in [#4861](#4861) ### 🐛 Bug Fixes - fix(binding): preserveModules infinity loop by @Brooooooklyn in [#4879](#4879) - fix: dynamic import does not return exports when preserveEntrySignatures: false is set and the importee is an entry by @IWANABETHATGUY in [#4891](#4891) - fix: preserveEntrySignatures panics with an edge case by @IWANABETHATGUY in [#4877](#4877) - fix: directives are missing with `preserveModules` by @IWANABETHATGUY in [#4876](#4876) - fix: exports from dynamically imported chunks are removed by @IWANABETHATGUY in [#4875](#4875) ### 🚜 Refactor - refactor: clearify Chunk entry kind by @IWANABETHATGUY in [#4892](#4892) - refactor(rolldown_plugin_build_import_analysis): align the logic with `rolldown-vite` by @shulaoda in [#4856](#4856) ### 📚 Documentation - docs(contrib-guide): add HMR testing section by @sapphi-red in [#4888](#4888) - docs(guide): update release channels - remove nightly, add pkg.pr.new by @Boshen in [#4881](#4881) ### 🧪 Testing - test: rename `rolldown/topics/hmr/mutiply-entires` to snake case by @sapphi-red in [#4889](#4889) - test: add test for #4849 by @sapphi-red in [#4887](#4887) - test: setup infra for hmr tests by @sapphi-red in [#4886](#4886) ### ⚙️ Miscellaneous Tasks - ci: disable publish to nightly by @Boshen in [#4874](#4874) - ci: extend Vite tests timeout by @sapphi-red in [#4870](#4870) - fix publish-to-npm.yml by @Boshen ###◀️ Revert - revert: "refactor(rolldown_plugin_load_fallback): align with rolldown-vite" by @shulaoda in [#4868](#4868) Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #4880