Skip to content

Comments

fix: directives are missing with preserveModules#4876

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-09-fix_4862
Jun 9, 2025
Merged

fix: directives are missing with preserveModules#4876
IWANABETHATGUY merged 1 commit intomainfrom
06-09-fix_4862

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 9, 2025 •
edited
Loading

Closed #4862

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 4862 fix: Directives are missing with preserveModules Jun 9, 2025
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 9, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 2685d6a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68467ab92d9cf80008b6fc5d

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 9, 2025 06:09
@hyf0 hyf0 changed the title fix: Directives are missing with preserveModules fix: directives are missing with preserveModules Jun 9, 2025
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     73.3±2.06ms        ? ?/sec    1.03     75.1±2.17ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     86.1±3.38ms        ? ?/sec    1.00     84.8±1.38ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    111.3±1.51ms        ? ?/sec    1.01    112.7±1.69ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    125.9±2.47ms        ? ?/sec    1.01    127.8±1.63ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.4±2.83ms        ? ?/sec    1.00     40.3±2.30ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.2±0.53ms        ? ?/sec    1.01     46.6±0.49ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    428.7±5.17ms        ? ?/sec    1.01    431.1±4.37ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    501.7±4.47ms        ? ?/sec    1.01    504.6±5.89ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.6±1.25ms        ? ?/sec    1.00     87.9±1.64ms        ? ?/sec
scan/scan@threejs                                            1.02     31.2±1.87ms        ? ?/sec    1.00     30.6±0.81ms        ? ?/sec
scan/scan@threejs10x                                         1.00    319.7±5.01ms        ? ?/sec    1.00    319.1±4.06ms        ? ?/sec

Merged via the queue into main with commit 882e3d8 Jun 9, 2025
25 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-09-fix_4862 branch June 9, 2025 06:36
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 10, 2025
@github-actions @shulaoda
release: v1.0.0-beta.14 (#4894)
6ec031d 
## [1.0.0-beta.14] - 2025-06-10

### 💥 BREAKING CHANGES

- refactor!: move preserveEntrySignatures from output to input options
by @IWANABETHATGUY in
[#4871](#4871)

### 🚀 Features

- feat(strictExecutionOrder): no need to generate plain chunk imports
for addressing side effects by @hyf0 in
[#4890](#4890)
- feat: make wasm fallback plugin callable in node by @shulaoda in
[#4885](#4885)
- feat(rolldown_plugin_module_preload_polyfill): align with
`rolldown-vite` by @shulaoda in
[#4884](#4884)
- feat(attachDebugInfo): improve format and distinguish dynamic entries
by @hyf0 in [#4861](#4861)

### 🐛 Bug Fixes

- fix(binding): preserveModules infinity loop by @Brooooooklyn in
[#4879](#4879)
- fix: dynamic import does not return exports when
preserveEntrySignatures: false is set and the importee is an entry by
@IWANABETHATGUY in
[#4891](#4891)
- fix: preserveEntrySignatures panics with an edge case by
@IWANABETHATGUY in
[#4877](#4877)
- fix: directives are missing with `preserveModules` by @IWANABETHATGUY
in [#4876](#4876)
- fix: exports from dynamically imported chunks are removed by
@IWANABETHATGUY in
[#4875](#4875)

### 🚜 Refactor

- refactor: clearify Chunk entry kind by @IWANABETHATGUY in
[#4892](#4892)
- refactor(rolldown_plugin_build_import_analysis): align the logic with
`rolldown-vite` by @shulaoda in
[#4856](#4856)

### 📚 Documentation

- docs(contrib-guide): add HMR testing section by @sapphi-red in
[#4888](#4888)
- docs(guide): update release channels - remove nightly, add pkg.pr.new
by @Boshen in [#4881](#4881)

### 🧪 Testing

- test: rename `rolldown/topics/hmr/mutiply-entires` to snake case by
@sapphi-red in [#4889](#4889)
- test: add test for #4849 by @sapphi-red in
[#4887](#4887)
- test: setup infra for hmr tests by @sapphi-red in
[#4886](#4886)

### ⚙️ Miscellaneous Tasks

- ci: disable publish to nightly by @Boshen in
[#4874](#4874)
- ci: extend Vite tests timeout by @sapphi-red in
[#4870](#4870)
- fix publish-to-npm.yml by @Boshen

### ◀️ Revert

- revert: "refactor(rolldown_plugin_load_fallback): align with
rolldown-vite" by @shulaoda in
[#4868](#4868)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Directives are missing with preserveModules

2 participants

@IWANABETHATGUY @hyf0