Skip to content

Comments

revert: "refactor(rolldown_plugin_load_fallback): align with rolldown-vite"#4868

Merged
shulaoda merged 1 commit intomainfrom
06-09-revert_refactor_rolldown_plugin_load_fallback_align_with_rolldown-vite
Jun 9, 2025
Merged

revert: "refactor(rolldown_plugin_load_fallback): align with rolldown-vite"#4868
shulaoda merged 1 commit intomainfrom
06-09-revert_refactor_rolldown_plugin_load_fallback_align_with_rolldown-vite

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 9, 2025

The native plugin doesn't need to be callable in the dev environment, so no adaptation is necessary.

Copy link
Member Author

shulaoda commented Jun 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title revert: refactor(rolldown_plugin_load_fallback): align with rolldown-vite revert: "refactor(rolldown_plugin_load_fallback): align with rolldown-vite" Jun 9, 2025
@netlify
Copy link

netlify bot commented Jun 9, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 1d5f25c
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68462fa3486f5a0008345b70

@shulaoda shulaoda marked this pull request as ready for review June 9, 2025 00:50
@shulaoda shulaoda requested a review from IWANABETHATGUY June 9, 2025 00:51
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Benchmarks Rust

  • target: main(024b632)
  • pr: 06-09-revert_refactor_rolldown_plugin_load_fallback_align_with_rolldown-vite(1d5f25c)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     78.1±2.24ms        ? ?/sec    1.00     76.5±3.19ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     89.4±2.33ms        ? ?/sec    1.00     88.9±2.17ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    116.1±3.33ms        ? ?/sec    1.00    113.9±1.76ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    129.5±2.73ms        ? ?/sec    1.00    129.4±1.93ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.0±0.69ms        ? ?/sec    1.02     41.8±2.53ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     47.5±0.59ms        ? ?/sec    1.00     47.3±0.58ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    437.7±5.32ms        ? ?/sec    1.00    438.7±5.32ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    510.0±5.13ms        ? ?/sec    1.00    511.2±7.22ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.4±1.35ms        ? ?/sec    1.00     88.5±1.86ms        ? ?/sec
scan/scan@threejs                                            1.01     31.1±0.58ms        ? ?/sec    1.00     31.0±1.77ms        ? ?/sec
scan/scan@threejs10x                                         1.00    321.6±5.06ms        ? ?/sec    1.00    320.4±5.17ms        ? ?/sec

@shulaoda shulaoda added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit 1aada1f Jun 9, 2025
26 checks passed
@shulaoda shulaoda deleted the 06-09-revert_refactor_rolldown_plugin_load_fallback_align_with_rolldown-vite branch June 9, 2025 02:03
Boshen pushed a commit that referenced this pull request Jun 10, 2025
## [1.0.0-beta.14] - 2025-06-10

### 💥 BREAKING CHANGES

- refactor!: move preserveEntrySignatures from output to input options
by @IWANABETHATGUY in
[#4871](#4871)

### 🚀 Features

- feat(strictExecutionOrder): no need to generate plain chunk imports
for addressing side effects by @hyf0 in
[#4890](#4890)
- feat: make wasm fallback plugin callable in node by @shulaoda in
[#4885](#4885)
- feat(rolldown_plugin_module_preload_polyfill): align with
`rolldown-vite` by @shulaoda in
[#4884](#4884)
- feat(attachDebugInfo): improve format and distinguish dynamic entries
by @hyf0 in [#4861](#4861)

### 🐛 Bug Fixes

- fix(binding): preserveModules infinity loop by @Brooooooklyn in
[#4879](#4879)
- fix: dynamic import does not return exports when
preserveEntrySignatures: false is set and the importee is an entry by
@IWANABETHATGUY in
[#4891](#4891)
- fix: preserveEntrySignatures panics with an edge case by
@IWANABETHATGUY in
[#4877](#4877)
- fix: directives are missing with `preserveModules` by @IWANABETHATGUY
in [#4876](#4876)
- fix: exports from dynamically imported chunks are removed by
@IWANABETHATGUY in
[#4875](#4875)

### 🚜 Refactor

- refactor: clearify Chunk entry kind by @IWANABETHATGUY in
[#4892](#4892)
- refactor(rolldown_plugin_build_import_analysis): align the logic with
`rolldown-vite` by @shulaoda in
[#4856](#4856)

### 📚 Documentation

- docs(contrib-guide): add HMR testing section by @sapphi-red in
[#4888](#4888)
- docs(guide): update release channels - remove nightly, add pkg.pr.new
by @Boshen in [#4881](#4881)

### 🧪 Testing

- test: rename `rolldown/topics/hmr/mutiply-entires` to snake case by
@sapphi-red in [#4889](#4889)
- test: add test for #4849 by @sapphi-red in
[#4887](#4887)
- test: setup infra for hmr tests by @sapphi-red in
[#4886](#4886)

### ⚙️ Miscellaneous Tasks

- ci: disable publish to nightly by @Boshen in
[#4874](#4874)
- ci: extend Vite tests timeout by @sapphi-red in
[#4870](#4870)
- fix publish-to-npm.yml by @Boshen

### ◀️ Revert

- revert: "refactor(rolldown_plugin_load_fallback): align with
rolldown-vite" by @shulaoda in
[#4868](#4868)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants