Skip to content

Comments

refactor(rolldown_plugin_build_import_analysis): align the logic with rolldown-vite#4856

Merged
shulaoda merged 1 commit intomainfrom
06-07-refactor_rolldown_plugin_build_import_analysis_align_logic_with_rolldown-vite
Jun 9, 2025
Merged

refactor(rolldown_plugin_build_import_analysis): align the logic with rolldown-vite#4856
shulaoda merged 1 commit intomainfrom
06-07-refactor_rolldown_plugin_build_import_analysis_align_logic_with_rolldown-vite

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 7, 2025 •
edited
Loading

Related to #3983

  • Refactored the code to align the logic with rolldown-vite
  • Support complex assignment syntax like const { a: { b: c, d: [e] } } = await import('./lib.js');

@shulaoda shulaoda changed the title refactor(rolldown_plugin_build_import_analysis): align logic with rolldown-vite WIP Jun 7, 2025
@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jun 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 7, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 3e1f106
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68456d0aa987af00088010b9
😎 Deploy Preview https://deploy-preview-4856--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(6bb8d8d)
  • pr: 06-07-refactor_rolldown_plugin_build_import_analysis_align_logic_with_rolldown-vite(3e1f106)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     75.6±2.52ms        ? ?/sec    1.03     77.6±3.42ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     87.4±2.22ms        ? ?/sec    1.00     87.2±2.23ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    114.5±1.56ms        ? ?/sec    1.00    115.0±1.82ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    130.9±1.98ms        ? ?/sec    1.00    130.2±2.22ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.5±2.54ms        ? ?/sec    1.00     41.6±2.43ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     48.0±1.54ms        ? ?/sec    1.00     47.9±0.80ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    443.6±5.74ms        ? ?/sec    1.00    441.5±5.10ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    519.0±3.97ms        ? ?/sec    1.00    515.3±4.43ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.9±1.57ms        ? ?/sec    1.01     89.8±2.01ms        ? ?/sec
scan/scan@threejs                                            1.00     31.7±1.90ms        ? ?/sec    1.00     31.7±1.98ms        ? ?/sec
scan/scan@threejs10x                                         1.00    327.4±6.00ms        ? ?/sec    1.01    329.9±6.90ms        ? ?/sec

@shulaoda shulaoda force-pushed the 06-07-refactor_rolldown_plugin_build_import_analysis_align_logic_with_rolldown-vite branch from 722d2d9 to d42a88a Compare June 8, 2025 10:40
@shulaoda shulaoda changed the title WIP refactor(rolldown_plugin_build_import_analysis): align the logic with rolldown-vite Jun 8, 2025
@shulaoda shulaoda marked this pull request as ready for review June 8, 2025 10:53
@shulaoda shulaoda requested a review from IWANABETHATGUY June 8, 2025 10:53
@shulaoda shulaoda force-pushed the 06-07-refactor_rolldown_plugin_build_import_analysis_align_logic_with_rolldown-vite branch from d42a88a to 14c224f Compare June 8, 2025 10:59
@shulaoda shulaoda force-pushed the 06-07-refactor_rolldown_plugin_build_import_analysis_align_logic_with_rolldown-vite branch from 14c224f to 3e1f106 Compare June 8, 2025 10:59
@shulaoda shulaoda added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit 2c93577 Jun 9, 2025
35 of 36 checks passed
@shulaoda shulaoda deleted the 06-07-refactor_rolldown_plugin_build_import_analysis_align_logic_with_rolldown-vite branch June 9, 2025 00:56
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 10, 2025
@github-actions @shulaoda
release: v1.0.0-beta.14 (#4894)
6ec031d 
## [1.0.0-beta.14] - 2025-06-10

### 💥 BREAKING CHANGES

- refactor!: move preserveEntrySignatures from output to input options
by @IWANABETHATGUY in
[#4871](#4871)

### 🚀 Features

- feat(strictExecutionOrder): no need to generate plain chunk imports
for addressing side effects by @hyf0 in
[#4890](#4890)
- feat: make wasm fallback plugin callable in node by @shulaoda in
[#4885](#4885)
- feat(rolldown_plugin_module_preload_polyfill): align with
`rolldown-vite` by @shulaoda in
[#4884](#4884)
- feat(attachDebugInfo): improve format and distinguish dynamic entries
by @hyf0 in [#4861](#4861)

### 🐛 Bug Fixes

- fix(binding): preserveModules infinity loop by @Brooooooklyn in
[#4879](#4879)
- fix: dynamic import does not return exports when
preserveEntrySignatures: false is set and the importee is an entry by
@IWANABETHATGUY in
[#4891](#4891)
- fix: preserveEntrySignatures panics with an edge case by
@IWANABETHATGUY in
[#4877](#4877)
- fix: directives are missing with `preserveModules` by @IWANABETHATGUY
in [#4876](#4876)
- fix: exports from dynamically imported chunks are removed by
@IWANABETHATGUY in
[#4875](#4875)

### 🚜 Refactor

- refactor: clearify Chunk entry kind by @IWANABETHATGUY in
[#4892](#4892)
- refactor(rolldown_plugin_build_import_analysis): align the logic with
`rolldown-vite` by @shulaoda in
[#4856](#4856)

### 📚 Documentation

- docs(contrib-guide): add HMR testing section by @sapphi-red in
[#4888](#4888)
- docs(guide): update release channels - remove nightly, add pkg.pr.new
by @Boshen in [#4881](#4881)

### 🧪 Testing

- test: rename `rolldown/topics/hmr/mutiply-entires` to snake case by
@sapphi-red in [#4889](#4889)
- test: add test for #4849 by @sapphi-red in
[#4887](#4887)
- test: setup infra for hmr tests by @sapphi-red in
[#4886](#4886)

### ⚙️ Miscellaneous Tasks

- ci: disable publish to nightly by @Boshen in
[#4874](#4874)
- ci: extend Vite tests timeout by @sapphi-red in
[#4870](#4870)
- fix publish-to-npm.yml by @Boshen

### ◀️ Revert

- revert: "refactor(rolldown_plugin_load_fallback): align with
rolldown-vite" by @shulaoda in
[#4868](#4868)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shulaoda @IWANABETHATGUY