Skip to content

Comments

fix: handle error in generateHmrPatch#4837

Merged
sapphi-red merged 1 commit intomainfrom
fix/handle-error-in-generate-hmr-patch
Jun 5, 2025
Merged

fix: handle error in generateHmrPatch#4837
sapphi-red merged 1 commit intomainfrom
fix/handle-error-in-generate-hmr-patch

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 5, 2025

Handled error in generateHmrPatch so that it doesn't crash when saving a file with syntax errors.

@netlify
Copy link

netlify bot commented Jun 5, 2025

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 146ac24
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6841795e85db1b00084a904e
😎 Deploy Preview https://deploy-preview-4837--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Benchmarks Rust

  • target: main(d811ec5)
  • pr: fix/handle-error-in-generate-hmr-patch(146ac24)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     82.2±5.47ms        ? ?/sec    1.06     86.9±6.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     93.9±5.56ms        ? ?/sec    1.04     97.3±5.44ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    122.7±5.33ms        ? ?/sec    1.00    120.2±4.55ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    136.4±3.46ms        ? ?/sec    1.00    135.0±4.62ms        ? ?/sec
bundle/bundle@threejs                                        1.00     43.8±2.28ms        ? ?/sec    1.00     43.8±2.17ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     50.2±1.95ms        ? ?/sec    1.00     49.8±2.00ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00   459.4±13.60ms        ? ?/sec    1.00   460.3±10.39ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00   523.7±10.84ms        ? ?/sec    1.01    527.7±9.19ms        ? ?/sec
scan/scan@rome_ts                                            1.00     92.3±3.24ms        ? ?/sec    1.01     92.8±2.85ms        ? ?/sec
scan/scan@threejs                                            1.00     32.9±2.26ms        ? ?/sec    1.01     33.1±1.56ms        ? ?/sec
scan/scan@threejs10x                                         1.02    335.5±6.18ms        ? ?/sec    1.00    327.5±6.16ms        ? ?/sec

@sapphi-red sapphi-red added this pull request to the merge queue Jun 5, 2025
Merged via the queue into main with commit 4a9af95 Jun 5, 2025
24 checks passed
@sapphi-red sapphi-red deleted the fix/handle-error-in-generate-hmr-patch branch June 5, 2025 14:08
@sapphi-red sapphi-red mentioned this pull request Jun 13, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 13, 2025
@sapphi-red
fix: handle error in hmrInvalidate (#4942)
e0d5926 
Same with #4837 but for `hmrInvalidate`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @hyf0