Skip to content

Comments

chore(rust): add comments for ModuleDefFormat methods#4821

Merged
hyf0 merged 4 commits intomainfrom
06-04-chore_rust_add_comments_for_moduledefformat_methods
Jun 4, 2025
Merged

chore(rust): add comments for ModuleDefFormat methods#4821
hyf0 merged 4 commits intomainfrom
06-04-chore_rust_add_comments_for_moduledefformat_methods

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 4, 2025

Description

@hyf0 hyf0 marked this pull request as ready for review June 4, 2025 13:01
This was referenced Jun 4, 2025
Merged
Merged
Merged
Merged
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Jun 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 force-pushed the 06-04-chore_rust_add_comments_for_moduledefformat_methods branch from c78a497 to a363cfe Compare June 4, 2025 13:02
graphite-app[bot]
graphite-app bot reviewed Jun 4, 2025
View reviewed changes
@hyf0 @graphite-app
Update crates/rolldown_common/src/types/module_def_format.rs
932cf2e 
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Benchmarks Rust

  • target: 06-04-feat_always_take_node_esm_spec_into_account_for_dynamic_imports_in_cjs_modules(13b1f3a)
  • pr: 06-04-chore_rust_add_comments_for_moduledefformat_methods(932cf2e)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.05     80.6±3.28ms        ? ?/sec    1.00     77.1±2.65ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     93.7±1.50ms        ? ?/sec    1.00     93.7±1.80ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    118.4±2.93ms        ? ?/sec    1.00    118.8±1.99ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    130.0±2.18ms        ? ?/sec    1.02    132.9±2.10ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.9±2.38ms        ? ?/sec    1.01     43.4±2.18ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     49.0±2.09ms        ? ?/sec    1.00     48.9±0.67ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    451.4±4.01ms        ? ?/sec    1.00    453.4±6.35ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    529.0±7.04ms        ? ?/sec    1.00    525.8±7.14ms        ? ?/sec
scan/scan@rome_ts                                            1.00     94.3±1.90ms        ? ?/sec    1.02     96.2±2.16ms        ? ?/sec
scan/scan@threejs                                            1.00     33.2±1.87ms        ? ?/sec    1.00     33.3±2.01ms        ? ?/sec
scan/scan@threejs10x                                         1.01    341.3±5.50ms        ? ?/sec    1.00    339.2±5.37ms        ? ?/sec

graphite-app[bot]
graphite-app bot reviewed Jun 4, 2025
View reviewed changes
@hyf0 @graphite-app
Update crates/rolldown_common/src/types/module_def_format.rs
0a5654c 
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Base automatically changed from 06-04-feat_always_take_node_esm_spec_into_account_for_dynamic_imports_in_cjs_modules to main June 4, 2025 13:41
@hyf0 hyf0 added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit b85da01 Jun 4, 2025
19 of 20 checks passed
@hyf0 hyf0 deleted the 06-04-chore_rust_add_comments_for_moduledefformat_methods branch June 4, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @shulaoda