Skip to content

Comments

test: ensure correct and consistent behavior on handling import('./some-cjs-module.js')#4817

Merged
hyf0 merged 1 commit intomainfrom
06-04-test_ensure_correct_and_consistent_behavior_on_handling_import_._some-cjs-module.js_
Jun 4, 2025
Merged

test: ensure correct and consistent behavior on handling import('./some-cjs-module.js')#4817
hyf0 merged 1 commit intomainfrom
06-04-test_ensure_correct_and_consistent_behavior_on_handling_import_._some-cjs-module.js_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 4, 2025

Description

@hyf0 hyf0 marked this pull request as ready for review June 4, 2025 10:27
This was referenced Jun 4, 2025
Merged
Merged
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Jun 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 force-pushed the 06-04-test_ensure_correct_and_consistent_behavior_on_handling_import_._some-cjs-module.js_ branch from 66f881a to 2dfa416 Compare June 4, 2025 10:28
@hyf0 hyf0 force-pushed the 06-04-feat_interop_import_some-cjs-module.js_ branch from b03577f to 2975c06 Compare June 4, 2025 10:28
@hyf0 hyf0 force-pushed the 06-04-test_ensure_correct_and_consistent_behavior_on_handling_import_._some-cjs-module.js_ branch 2 times, most recently from 62ef674 to a87aa9c Compare June 4, 2025 10:34
@hyf0 hyf0 force-pushed the 06-04-feat_interop_import_some-cjs-module.js_ branch 2 times, most recently from a8dda97 to d76d690 Compare June 4, 2025 10:36
@hyf0 hyf0 force-pushed the 06-04-test_ensure_correct_and_consistent_behavior_on_handling_import_._some-cjs-module.js_ branch from a87aa9c to 09f1b30 Compare June 4, 2025 10:36
@hyf0 hyf0 mentioned this pull request Jun 4, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(b9ac5f0)
  • pr: 06-04-test_ensure_correct_and_consistent_behavior_on_handling_import_._some-cjs-module.js_(f11a80f)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     77.1±2.13ms        ? ?/sec    1.00     74.9±2.12ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     86.7±1.98ms        ? ?/sec    1.00     84.7±1.14ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    113.3±2.06ms        ? ?/sec    1.00    113.1±2.06ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    127.3±1.58ms        ? ?/sec    1.00    126.7±1.70ms        ? ?/sec
bundle/bundle@threejs                                        1.02     40.6±1.25ms        ? ?/sec    1.00     39.8±0.98ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     46.7±0.67ms        ? ?/sec    1.00     46.2±0.45ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02    439.0±5.11ms        ? ?/sec    1.00    430.2±4.62ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    514.1±8.59ms        ? ?/sec    1.00    503.8±4.64ms        ? ?/sec
scan/scan@rome_ts                                            1.01     88.4±1.20ms        ? ?/sec    1.00     87.9±1.33ms        ? ?/sec
scan/scan@threejs                                            1.00     30.6±0.33ms        ? ?/sec    1.01     30.8±1.92ms        ? ?/sec
scan/scan@threejs10x                                         1.00    321.1±4.69ms        ? ?/sec    1.00    321.2±4.68ms        ? ?/sec

@hyf0 hyf0 force-pushed the 06-04-feat_interop_import_some-cjs-module.js_ branch from d76d690 to f97f85f Compare June 4, 2025 11:14
@hyf0 hyf0 force-pushed the 06-04-test_ensure_correct_and_consistent_behavior_on_handling_import_._some-cjs-module.js_ branch from 09f1b30 to e2e3b49 Compare June 4, 2025 12:00
@hyf0 hyf0 force-pushed the 06-04-feat_interop_import_some-cjs-module.js_ branch from f97f85f to c06735c Compare June 4, 2025 12:00
@hyf0 hyf0 force-pushed the 06-04-test_ensure_correct_and_consistent_behavior_on_handling_import_._some-cjs-module.js_ branch from e2e3b49 to 929f3da Compare June 4, 2025 12:05
@hyf0 hyf0 force-pushed the 06-04-feat_interop_import_some-cjs-module.js_ branch from c06735c to 3fe9ebd Compare June 4, 2025 12:05
Base automatically changed from 06-04-feat_interop_import_some-cjs-module.js_ to main June 4, 2025 12:24
@hyf0 hyf0 force-pushed the 06-04-test_ensure_correct_and_consistent_behavior_on_handling_import_._some-cjs-module.js_ branch from 929f3da to f11a80f Compare June 4, 2025 12:24
@netlify
Copy link

netlify bot commented Jun 4, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit f11a80f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68403b08100cbf00086a09d7

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 4, 2025

Merge activity

  • Jun 4, 12:25 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@hyf0 hyf0 added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 4cdaabd Jun 4, 2025
22 checks passed
@hyf0 hyf0 deleted the 06-04-test_ensure_correct_and_consistent_behavior_on_handling_import_._some-cjs-module.js_ branch June 4, 2025 12:41
@hyf0 hyf0 mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @sapphi-red