Skip to content

Comments

feat: interop import('some-cjs-module.js')#4816

Merged
hyf0 merged 1 commit intomainfrom
06-04-feat_interop_import_some-cjs-module.js_
Jun 4, 2025
Merged

feat: interop import('some-cjs-module.js')#4816
hyf0 merged 1 commit intomainfrom
06-04-feat_interop_import_some-cjs-module.js_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 4, 2025 •
edited
Loading

Description

Fixes #4289. @sapphi-red

@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Jun 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 mentioned this pull request Jun 4, 2025
Merged
@hyf0 hyf0 marked this pull request as ready for review June 4, 2025 09:28
graphite-app[bot]
graphite-app bot reviewed Jun 4, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(b01f7cb)
  • pr: 06-04-feat_interop_import_some-cjs-module.js_(3fe9ebd)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     80.3±1.95ms        ? ?/sec    1.00     79.7±2.37ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     91.7±1.56ms        ? ?/sec    1.00     91.2±1.65ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    117.5±3.97ms        ? ?/sec    1.00    117.0±3.21ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    131.6±1.57ms        ? ?/sec    1.00    131.9±1.84ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.5±2.22ms        ? ?/sec    1.00     42.3±2.09ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     48.3±0.61ms        ? ?/sec    1.00     48.3±0.55ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    449.2±5.21ms        ? ?/sec    1.00    448.1±4.51ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    524.2±4.12ms        ? ?/sec    1.00    521.6±6.78ms        ? ?/sec
scan/scan@rome_ts                                            1.03     95.7±2.48ms        ? ?/sec    1.00     93.0±1.55ms        ? ?/sec
scan/scan@threejs                                            1.03     33.6±1.91ms        ? ?/sec    1.00     32.8±1.79ms        ? ?/sec
scan/scan@threejs10x                                         1.00    335.6±4.46ms        ? ?/sec    1.00    336.3±4.48ms        ? ?/sec

@hyf0 hyf0 force-pushed the 06-04-feat_interop_import_some-cjs-module.js_ branch from 1555fee to b03577f Compare June 4, 2025 10:24
@hyf0 hyf0 mentioned this pull request Jun 4, 2025
Merged
@hyf0 hyf0 force-pushed the 06-04-feat_interop_import_some-cjs-module.js_ branch 3 times, most recently from a8dda97 to d76d690 Compare June 4, 2025 10:36
@hyf0 hyf0 requested a review from IWANABETHATGUY June 4, 2025 10:38
@hyf0 hyf0 mentioned this pull request Jun 4, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY requested a review from sapphi-red June 4, 2025 10:54
Base automatically changed from 06-04-refactor_rust_extract_try_rewrite_import_expression_logic_into_a_standalone_function to main June 4, 2025 11:12
@hyf0 hyf0 force-pushed the 06-04-feat_interop_import_some-cjs-module.js_ branch from d76d690 to f97f85f Compare June 4, 2025 11:14
@netlify
Copy link

netlify bot commented Jun 4, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3fe9ebd
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68403686df1bff0008c519e7

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 4, 2025

Merge activity

  • Jun 4, 11:15 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

sapphi-red
sapphi-red approved these changes Jun 4, 2025
View reviewed changes
@hyf0 hyf0 force-pushed the 06-04-feat_interop_import_some-cjs-module.js_ branch from f97f85f to c06735c Compare June 4, 2025 12:00
@hyf0 hyf0 force-pushed the 06-04-feat_interop_import_some-cjs-module.js_ branch from c06735c to 3fe9ebd Compare June 4, 2025 12:05
@hyf0 hyf0 added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit b9ac5f0 Jun 4, 2025
23 checks passed
@hyf0 hyf0 deleted the 06-04-feat_interop_import_some-cjs-module.js_ branch June 4, 2025 12:24
@hyf0 hyf0 mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@sapphi-red sapphi-red sapphi-red approved these changes

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rolldown behaves differently from node for import('cjs-module')

2 participants

@hyf0 @sapphi-red