Skip to content

Comments

refactor(rust): extract try_rewrite_import_expression logic into a standalone function#4815

Merged
hyf0 merged 1 commit intomainfrom
06-04-refactor_rust_extract_try_rewrite_import_expression_logic_into_a_standalone_function
Jun 4, 2025
Merged

refactor(rust): extract try_rewrite_import_expression logic into a standalone function#4815
hyf0 merged 1 commit intomainfrom
06-04-refactor_rust_extract_try_rewrite_import_expression_logic_into_a_standalone_function

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 4, 2025

Description

@hyf0 hyf0 marked this pull request as ready for review June 4, 2025 09:28
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Jun 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 mentioned this pull request Jun 4, 2025
Merged
@netlify
Copy link

netlify bot commented Jun 4, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 785b52f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6840119ff7d15100088dca68

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Benchmarks Rust

  • target: main(f2a818b)
  • pr: 06-04-refactor_rust_extract_try_rewrite_import_expression_logic_into_a_standalone_function(785b52f)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     79.7±2.56ms        ? ?/sec    1.00     80.0±3.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     91.8±2.78ms        ? ?/sec    1.01     92.6±3.12ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    116.6±2.13ms        ? ?/sec    1.00    117.0±2.13ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    129.9±2.00ms        ? ?/sec    1.01    131.5±1.98ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.9±0.85ms        ? ?/sec    1.02     42.9±2.34ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     48.0±1.06ms        ? ?/sec    1.01     48.6±1.34ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    442.3±6.42ms        ? ?/sec    1.01    445.5±4.66ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    516.5±4.50ms        ? ?/sec    1.00    517.5±5.13ms        ? ?/sec
scan/scan@rome_ts                                            1.01     97.4±3.34ms        ? ?/sec    1.00     96.9±1.88ms        ? ?/sec
scan/scan@threejs                                            1.00     33.7±2.34ms        ? ?/sec    1.00     33.9±2.13ms        ? ?/sec
scan/scan@threejs10x                                         1.00    335.8±5.09ms        ? ?/sec    1.01    338.2±4.20ms        ? ?/sec

This was referenced Jun 4, 2025
Merged
Merged
@hyf0 hyf0 added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit b01f7cb Jun 4, 2025
24 checks passed
@hyf0 hyf0 deleted the 06-04-refactor_rust_extract_try_rewrite_import_expression_logic_into_a_standalone_function branch June 4, 2025 11:12
@hyf0 hyf0 mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY