Skip to content

Comments

fix: Preserve default export for preserveModules#4814

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-04-fix_4758
Jun 4, 2025
Merged

fix: Preserve default export for preserveModules#4814
IWANABETHATGUY merged 1 commit intomainfrom
06-04-fix_4758

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 4, 2025 •
edited
Loading

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 4, 2025 09:25
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 4, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 4, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 437aae9
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6840128e7fbbd80008441ac9

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 4758 fix: Preserve default export for preserveModules Jun 4, 2025
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     75.2±2.39ms        ? ?/sec    1.00     74.9±1.84ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     87.1±2.24ms        ? ?/sec    1.00     84.9±2.31ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    112.5±1.55ms        ? ?/sec    1.01    114.1±2.43ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    128.0±2.30ms        ? ?/sec    1.00    127.3±1.64ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.6±2.67ms        ? ?/sec    1.00     40.6±2.10ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     47.3±0.72ms        ? ?/sec    1.00     47.3±1.28ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    437.8±5.35ms        ? ?/sec    1.00    431.8±4.77ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    506.6±7.98ms        ? ?/sec    1.00    504.7±6.75ms        ? ?/sec
scan/scan@rome_ts                                            1.00     89.8±2.13ms        ? ?/sec    1.00     89.5±1.66ms        ? ?/sec
scan/scan@threejs                                            1.01     31.6±1.99ms        ? ?/sec    1.00     31.4±1.85ms        ? ?/sec
scan/scan@threejs10x                                         1.01   327.0±17.75ms        ? ?/sec    1.00    324.4±3.88ms        ? ?/sec

Merged via the queue into main with commit b30ab1f Jun 4, 2025
25 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-04-fix_4758 branch June 4, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Preserve default export for preserveModules

2 participants

@IWANABETHATGUY @hyf0