Skip to content

Comments

feat(rolldown_plugin_isolated_declaration): improve diagnostic messages#4731

Merged
shulaoda merged 1 commit intomainfrom
05-29-feat_rolldown_plugin_isolated_declaration_improve_diagnostic_messages
May 29, 2025
Merged

feat(rolldown_plugin_isolated_declaration): improve diagnostic messages#4731
shulaoda merged 1 commit intomainfrom
05-29-feat_rolldown_plugin_isolated_declaration_improve_diagnostic_messages

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented May 29, 2025 •
edited
Loading

Description

closes #4040

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented May 29, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented May 29, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 4b175a9
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6838cd9bb48f9a0008c80dc4
😎 Deploy Preview https://deploy-preview-4731--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shulaoda shulaoda marked this pull request as ready for review May 29, 2025 07:38
@shulaoda shulaoda force-pushed the 05-29-feat_rolldown_plugin_isolated_declaration_improve_diagnostic_messages branch from 1883a54 to ece9350 Compare May 29, 2025 07:41
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(0a177d4)
  • pr: 05-29-feat_rolldown_plugin_isolated_declaration_improve_diagnostic_messages(4b175a9)
group                                 pr                                     target
-----                                 --                                     ------
bundle/bundle@rome_ts                 1.02    115.8±1.91ms        ? ?/sec    1.00    113.6±1.82ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap       1.02    131.0±2.39ms        ? ?/sec    1.00    128.4±1.76ms        ? ?/sec
bundle/bundle@threejs                 1.00     41.4±2.47ms        ? ?/sec    1.01     41.9±1.82ms        ? ?/sec
bundle/bundle@threejs-sourcemap       1.02     48.1±0.61ms        ? ?/sec    1.00     47.0±0.63ms        ? ?/sec
bundle/bundle@threejs10x              1.00    432.6±5.47ms        ? ?/sec    1.00    434.4±5.37ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap    1.00    506.8±6.83ms        ? ?/sec    1.00    505.6±5.33ms        ? ?/sec
scan/scan@rome_ts                     1.00     89.7±2.27ms        ? ?/sec    1.01     90.6±3.13ms        ? ?/sec
scan/scan@threejs                     1.04     31.6±2.31ms        ? ?/sec    1.00     30.5±0.48ms        ? ?/sec
scan/scan@threejs10x                  1.01    323.3±5.20ms        ? ?/sec    1.00    319.9±4.79ms        ? ?/sec

IWANABETHATGUY
IWANABETHATGUY approved these changes May 29, 2025
View reviewed changes
@shulaoda shulaoda mentioned this pull request May 29, 2025
Closed
@shulaoda shulaoda force-pushed the 05-29-feat_rolldown_plugin_isolated_declaration_improve_diagnostic_messages branch from ece9350 to 4b175a9 Compare May 29, 2025 21:11
@shulaoda shulaoda added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit 87188ed May 29, 2025
24 checks passed
@shulaoda shulaoda deleted the 05-29-feat_rolldown_plugin_isolated_declaration_improve_diagnostic_messages branch May 29, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Unhandleable IsolatedDeclarations Error

2 participants

@shulaoda @IWANABETHATGUY