Skip to content

Comments

fix: removing unused dynamic imported chunks#4655

Merged
IWANABETHATGUY merged 1 commit intomainfrom
05-24-fix_3998
May 25, 2025
Merged

fix: removing unused dynamic imported chunks#4655
IWANABETHATGUY merged 1 commit intomainfrom
05-24-fix_3998

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented May 24, 2025 •
edited by hyf0
Loading

Description

  1. Closed After removing unused dynamic imported chunks, rolldown outputs different results compared to rollup #3998

This PR makes unused dynamic entries disappear instead continuing participate in calculations related to enries.

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented May 24, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented May 24, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit c0f2427
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6832fd52b3e0b40008671b39

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2025 •
edited
Loading

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     71.8±0.68ms        ? ?/sec    1.03     73.6±3.32ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     90.9±0.61ms        ? ?/sec    1.01     91.8±0.51ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    104.6±0.69ms        ? ?/sec    1.01    105.9±0.59ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     81.7±0.59ms        ? ?/sec    1.02     83.3±0.88ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    114.3±0.96ms        ? ?/sec    1.00    114.8±0.97ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    182.3±0.63ms        ? ?/sec    1.01    183.6±0.81ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.04    225.4±1.27ms        ? ?/sec    1.00    216.5±1.01ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    126.7±0.93ms        ? ?/sec    1.00    126.9±1.10ms        ? ?/sec
bundle/bundle@threejs                                               1.01     39.0±2.63ms        ? ?/sec    1.00     38.6±0.47ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     79.1±1.30ms        ? ?/sec    1.01     80.2±0.58ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     94.3±0.30ms        ? ?/sec    1.04     98.1±1.85ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     45.0±0.40ms        ? ?/sec    1.01     45.3±0.20ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    408.8±3.11ms        ? ?/sec    1.01    412.6±2.56ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    992.4±5.13ms        ? ?/sec    1.00    991.4±3.45ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1169.5±3.40ms        ? ?/sec    1.00   1166.6±3.00ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    474.3±2.12ms        ? ?/sec    1.01    478.5±3.00ms        ? ?/sec
remapping/remapping                                                 1.00     26.6±0.69ms        ? ?/sec    1.00     26.7±0.72ms        ? ?/sec
remapping/render-chunk-remapping                                    1.04     69.2±4.41ms        ? ?/sec    1.00     66.5±0.60ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     87.7±0.56ms        ? ?/sec    1.00     87.5±0.62ms        ? ?/sec
scan/scan@threejs                                                   1.01     30.1±1.25ms        ? ?/sec    1.00     30.0±1.23ms        ? ?/sec
scan/scan@threejs10x                                                1.01    302.0±2.38ms        ? ?/sec    1.00    299.8±2.35ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request May 24, 2025
Closed
@hyf0 hyf0 linked an issue May 24, 2025 that may be closed by this pull request
After removing unused dynamic imported chunks, rolldown outputs different results compared to rollup #3998
Closed
hyf0
hyf0 reviewed May 24, 2025
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY force-pushed the 05-24-fix_3998 branch 2 times, most recently from 3d88f07 to 58e2e1d Compare May 25, 2025 11:06
@IWANABETHATGUY IWANABETHATGUY changed the title fix: 3998 fix: removing unused dynamic imported chunks May 25, 2025
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review May 25, 2025 11:17
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue May 25, 2025
Merged via the queue into main with commit fe21db7 May 25, 2025
31 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 05-24-fix_3998 branch May 25, 2025 11:45
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request May 25, 2025
Closed
@dominikg dominikg mentioned this pull request Sep 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

After removing unused dynamic imported chunks, rolldown outputs different results compared to rollup

2 participants

@IWANABETHATGUY @hyf0