feat: better error message for manualChunks#4530
Merged
shulaoda merged 4 commits intorolldown:mainfrom May 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the error messaging for configuration of the manualChunks option by explicitly disallowing it and pointing users toward using advancedChunks instead.
- Updated the validator to disallow manualChunks using v.never with a custom error message.
- Ensured consistency by keeping advancedChunks as a valid option.
sapphi-red
commented
May 13, 2025
hyf0
reviewed
May 13, 2025
hyf0
approved these changes
May 13, 2025
shulaoda
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the following error message to be output if
ouput.manualChunkswas specified.