Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tests to ensure that unused pure function calls are properly tree-shaken, addressing issue 3245.
- Updates the integration snapshot to include a marker for issue 3245.
- Introduces a new test case in main.js with a pure annotation and verifies through a test that the function call is removed during tree-shaking.
- Updates artifact snapshots and adds necessary test configuration.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap | Updates snapshot with a new section for issue 3245. |
| crates/rolldown/tests/rolldown/issues/3245/main.js | Adds test code with a pure annotation for the unused function call. |
| crates/rolldown/tests/rolldown/issues/3245/artifacts.snap | Reflects the expected output post tree-shake in the snapshot. |
| crates/rolldown/tests/rolldown/issues/3245/_test.mjs | Introduces a test to assert that the function call is tree-shaken. |
| crates/rolldown/tests/rolldown/issues/3245/_config.json | Adds an empty configuration file for the test suite. |
sapphi-red
force-pushed
the
05-13-test_rust_ensure_unused_pure_function_call_got_treeshaked
branch
from
d43e083 to
ec59792
Compare
sapphi-red
approved these changes
Sep 8, 2025
Member
Author
Merge activity
|
<!-- Thank you for contributing! --> ### Description Closes #3245. <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
graphite-app
bot
force-pushed
the
05-13-test_rust_ensure_unused_pure_function_call_got_treeshaked
branch
from
ec59792 to
5d3ceb3
Compare
shulaoda
deleted the
05-13-test_rust_ensure_unused_pure_function_call_got_treeshaked
branch
shulaoda
added a commit
that referenced
this pull request
Sep 8, 2025
## [1.0.0-beta.36] - 2025-09-08 > [!warning] > ### 💥 BREAKING CHANGES > > - drop CJS format, increase minimum required node (#6025) by @sxzz ### 🚀 Features - rolldown_plugin_reporter: statically imported dynamic import warning (#6065) by @shulaoda - rolldown_plugin_reporter: warn large chunks (#6063) by @shulaoda - rolldown: oxc v0.87.0 (#5975) by @Boshen ### 🐛 Bug Fixes - allow keeping whitespace while enabling minify (#5893) by @sapphi-red - dev/watch: build connection between file in `this.addWatchFile` and currently transformed module during transform hook (#6048) by @hyf0 - validator of `output.minify` (#6062) by @IWANABETHATGUY - codspeed rust benchmark ci (#6052) by @IWANABETHATGUY - just command in ci (#6045) by @IWANABETHATGUY - watch: only consider files read from disk are able to watch (#6037) by @hyf0 ### 🚜 Refactor - dev: introduce `DevWatchOptions` for enhanced file watching configuration (#6057) by @hyf0 - unify to use `is_in_node_modules` from `rolldown_plugin_utils` (#6066) by @shulaoda ### 🧪 Testing - rust: ensure unused pure function call got treeshaked (#4524) by @hyf0 - hmr: tweak improper test (#6034) by @hyf0 - hmr: add test of editing multiple files in the same timeframe (#6029) by @hyf0 - hmr: support to edit multiple files in the same timeframe (#6014) by @hyf0 ### ⚙️ Miscellaneous Tasks - deps: lock file maintenance rust crates (#6003) by @renovate[bot] - deps: lock file maintenance npm packages (#5995) by @renovate[bot] - add auto-assign PR workflow for organization members (#6058) by @IWANABETHATGUY - fix benchmark-node workflow (#6060) by @IWANABETHATGUY - adding `test-node-rolldown-only` just command (#6055) by @IWANABETHATGUY - just commands in ci (#6056) by @IWANABETHATGUY - run test ci when `justfile` is changed (#6049) by @IWANABETHATGUY - remove unused warning for conditional compiled`SimplifyMinifyOptions` (#6047) by @IWANABETHATGUY - remove auto approval ci (#6051) by @IWANABETHATGUY - adding rustfmt components for `repo-validation` (#6053) by @IWANABETHATGUY - repo: check format/style in `just lint-rust` (#6050) by @hyf0 - repo/ai: refine `justfile` (#6038) by @hyf0 - repo/ai: add `AGENTS.md` and `CLAUDE.md` (#6039) by @hyf0 - deps: update github-actions (major) (#6041) by @renovate[bot] - deps: update github-actions (#6040) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.1 (#6035) by @renovate[bot] Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3245.