Skip to content

Comments

refactor(hmr): hmr chunk loadExports#4460

Merged
underfin merged 8 commits intomainfrom
05-08-refactor_hmr_hmr_chunk_loadexports
May 10, 2025
Merged

refactor(hmr): hmr chunk loadExports#4460
underfin merged 8 commits intomainfrom
05-08-refactor_hmr_hmr_chunk_loadexports

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented May 9, 2025 •
edited
Loading

Description

The pr intend to support some features.

  • avoid create import one module mulitly times
  • interop
  • import external module, even it's not used at now.

@underfin Graphite App
Copy link
Contributor Author

underfin commented May 9, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@underfin underfin mentioned this pull request May 9, 2025
Merged
@netlify
Copy link

netlify bot commented May 9, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit a3ee2ad
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/681edd943bd80e0008e66abe

underfin
underfin commented May 9, 2025
View reviewed changes
@underfin underfin marked this pull request as ready for review May 9, 2025 09:36
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(093c41d)
  • pr: 05-08-refactor_hmr_hmr_chunk_loadexports(a3ee2ad)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     79.2±1.08ms        ? ?/sec    1.00     79.1±1.65ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     99.5±0.96ms        ? ?/sec    1.04    103.0±1.72ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    113.1±1.22ms        ? ?/sec    1.04    117.7±2.30ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     88.7±1.27ms        ? ?/sec    1.00     88.8±1.03ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    121.0±1.28ms        ? ?/sec    1.02    123.8±1.31ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    197.6±6.77ms        ? ?/sec    1.02    201.6±2.11ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.02    237.0±2.56ms        ? ?/sec    1.00    232.1±1.61ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    134.1±2.35ms        ? ?/sec    1.03    138.2±1.95ms        ? ?/sec
bundle/bundle@threejs                                               1.00     40.4±0.99ms        ? ?/sec    1.06     42.7±1.20ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     82.8±0.66ms        ? ?/sec    1.05     86.9±4.39ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    102.1±0.71ms        ? ?/sec    1.04    105.9±1.07ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     46.8±0.42ms        ? ?/sec    1.07     50.0±0.43ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    418.0±3.94ms        ? ?/sec    1.03    432.4±4.19ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1031.4±6.15ms        ? ?/sec    1.02   1050.9±3.78ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1223.8±4.48ms        ? ?/sec    1.00   1228.9±4.49ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00   495.9±17.41ms        ? ?/sec    1.02    505.0±2.97ms        ? ?/sec
remapping/remapping                                                 1.00     24.2±2.44ms        ? ?/sec    1.16     28.0±0.42ms        ? ?/sec
remapping/render-chunk-remapping                                    1.05     72.2±6.56ms        ? ?/sec    1.00     69.1±4.49ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     93.8±0.87ms        ? ?/sec    1.00     94.1±1.67ms        ? ?/sec
scan/scan@threejs                                                   1.01     31.0±0.32ms        ? ?/sec    1.00     30.8±1.02ms        ? ?/sec
scan/scan@threejs10x                                                1.03    318.3±2.59ms        ? ?/sec    1.00    310.5±2.61ms        ? ?/sec

@underfin underfin force-pushed the 05-08-refactor_hmr_hmr_chunk_loadexports branch from 7100bbd to 251aa8c Compare May 10, 2025 04:22
@underfin underfin enabled auto-merge May 10, 2025 04:22
graphite-app[bot]
graphite-app bot reviewed May 10, 2025
View reviewed changes
@underfin @graphite-app
Update crates/rolldown/src/hmr/hmr_ast_finalizer.rs
8ac8cf5 
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
graphite-app[bot]
graphite-app bot reviewed May 10, 2025
View reviewed changes
graphite-app[bot]
graphite-app bot reviewed May 10, 2025
View reviewed changes
@underfin @graphite-app
Update crates/rolldown/src/runtime/runtime-extra-dev.js
3530007 
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
graphite-app[bot]
graphite-app bot reviewed May 10, 2025
View reviewed changes
graphite-app[bot]
graphite-app bot reviewed May 10, 2025
View reviewed changes
@underfin underfin added this pull request to the merge queue May 10, 2025
Merged via the queue into main with commit 7da8585 May 10, 2025
30 checks passed
@underfin underfin deleted the 05-08-refactor_hmr_hmr_chunk_loadexports branch May 10, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @hyf0