Skip to content

Comments

fix(hmr): hmr chunk execute dependencies before create import.meta.hot#4320

Merged
underfin merged 2 commits intomainfrom
04-25-fix_hmr_hmr_chunk_execute_dependencies_at_first
Apr 28, 2025
Merged

fix(hmr): hmr chunk execute dependencies before create import.meta.hot#4320
underfin merged 2 commits intomainfrom
04-25-fix_hmr_hmr_chunk_execute_dependencies_at_first

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Apr 25, 2025 •
edited
Loading

Description

Make sure the module execute semantics, crate import.meta.hot should be place after execute dependencies.

@underfin Graphite App
Copy link
Contributor Author

underfin commented Apr 25, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@underfin underfin mentioned this pull request Apr 25, 2025
Merged
@underfin underfin changed the title fix(hmr): hmr chunk execute dependencies at first fix(hmr): hmr chunk execute dependencies before create import.meta.hot Apr 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(6239159)
  • pr: 04-25-fix_hmr_hmr_chunk_execute_dependencies_at_first(ac1caa1)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.07     79.7±2.40ms        ? ?/sec    1.00     74.4±0.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     96.5±0.93ms        ? ?/sec    1.02     98.0±1.84ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    110.6±1.45ms        ? ?/sec    1.01    112.0±1.74ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     85.9±1.42ms        ? ?/sec    1.01     86.5±2.50ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    123.2±2.34ms        ? ?/sec    1.00    122.1±2.70ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    194.6±2.21ms        ? ?/sec    1.08    211.2±9.29ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.02   236.7±12.09ms        ? ?/sec    1.00    232.8±4.89ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    133.6±1.32ms        ? ?/sec    1.04    139.4±4.09ms        ? ?/sec
bundle/bundle@threejs                                               1.00     42.0±1.56ms        ? ?/sec    1.07     44.9±4.06ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     83.9±0.68ms        ? ?/sec    1.03     86.4±1.50ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.06    107.4±3.45ms        ? ?/sec    1.00    101.4±0.78ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.9±0.36ms        ? ?/sec    1.04     49.6±0.61ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    422.8±4.57ms        ? ?/sec    1.04    440.8±6.10ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1068.8±25.43ms        ? ?/sec    1.00   1071.0±9.55ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01   1245.6±7.79ms        ? ?/sec    1.00  1237.4±11.40ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    505.3±7.56ms        ? ?/sec    1.03    518.2±8.37ms        ? ?/sec
remapping/remapping                                                 1.13     25.2±0.13ms        ? ?/sec    1.00     22.2±0.41ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     70.4±4.46ms        ? ?/sec    1.04     73.3±6.56ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     92.1±0.97ms        ? ?/sec    1.00     92.5±1.00ms        ? ?/sec
scan/scan@threejs                                                   1.00     31.3±1.75ms        ? ?/sec    1.02     31.8±2.04ms        ? ?/sec
scan/scan@threejs10x                                                1.00    313.0±5.36ms        ? ?/sec    1.01    316.6±5.20ms        ? ?/sec

Base automatically changed from 04-25-fix_hmr_reexport_named_declaration to main April 25, 2025 10:08
@underfin underfin force-pushed the 04-25-fix_hmr_hmr_chunk_execute_dependencies_at_first branch from a6e4a45 to 4f835df Compare April 27, 2025 07:19
@underfin underfin mentioned this pull request Apr 27, 2025
Merged
@netlify
Copy link

netlify bot commented Apr 27, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ac1caa1
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/680ee411ca58f60008d8c77f

@underfin underfin marked this pull request as ready for review April 27, 2025 07:21
@underfin underfin enabled auto-merge April 27, 2025 07:21
@underfin underfin force-pushed the 04-25-fix_hmr_hmr_chunk_execute_dependencies_at_first branch from 4f835df to ac1caa1 Compare April 28, 2025 02:12
@underfin underfin added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit 2a06dfe Apr 28, 2025
29 checks passed
@underfin underfin deleted the 04-25-fix_hmr_hmr_chunk_execute_dependencies_at_first branch April 28, 2025 02:37
@underfin underfin mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @hyf0