Skip to content

Comments

fix(hmr): accpet deps#4314

Merged
underfin merged 2 commits intomainfrom
fix-hmr-accpet-deps
Apr 25, 2025
Merged

fix(hmr): accpet deps#4314
underfin merged 2 commits intomainfrom
fix-hmr-accpet-deps

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Apr 25, 2025

Description

close #4104

@underfin underfin mentioned this pull request Apr 24, 2025
Closed
@netlify
Copy link

netlify bot commented Apr 25, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 2603523
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/680b0a42b0114d000872924e

@underfin underfin enabled auto-merge April 25, 2025 04:07
@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 April 25, 2025 04:11
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     76.3±1.14ms        ? ?/sec    1.01     77.0±0.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     99.2±1.91ms        ? ?/sec    1.01     99.8±1.82ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    111.2±1.05ms        ? ?/sec    1.01    112.7±1.18ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     85.9±2.15ms        ? ?/sec    1.02     88.1±2.02ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    120.5±1.65ms        ? ?/sec    1.02    122.8±1.94ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    202.0±4.53ms        ? ?/sec    1.00    200.6±4.59ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    230.6±2.26ms        ? ?/sec    1.03    236.7±4.18ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    132.9±3.13ms        ? ?/sec    1.04    138.6±2.29ms        ? ?/sec
bundle/bundle@threejs                                               1.00     42.6±1.94ms        ? ?/sec    1.01     43.2±3.01ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     85.0±0.49ms        ? ?/sec    1.02     87.0±1.08ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    100.5±1.46ms        ? ?/sec    1.04    104.4±2.74ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.6±0.67ms        ? ?/sec    1.00     48.5±0.80ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    434.6±8.91ms        ? ?/sec    1.00    434.3±4.57ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1068.3±5.26ms        ? ?/sec    1.01   1076.3±6.10ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1260.3±10.89ms        ? ?/sec    1.00   1260.6±5.94ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    507.3±8.80ms        ? ?/sec    1.00    504.9±4.36ms        ? ?/sec
remapping/remapping                                                 1.00     25.9±0.89ms        ? ?/sec    1.00     25.9±0.21ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     65.1±0.38ms        ? ?/sec    1.00     65.1±0.34ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     94.2±1.55ms        ? ?/sec    1.01     94.7±1.72ms        ? ?/sec
scan/scan@threejs                                                   1.00     31.9±1.20ms        ? ?/sec    1.00     31.8±1.33ms        ? ?/sec
scan/scan@threejs10x                                                1.00    318.8±6.83ms        ? ?/sec    1.01    321.0±3.96ms        ? ?/sec

@underfin underfin added this pull request to the merge queue Apr 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2025
@underfin underfin added this pull request to the merge queue Apr 25, 2025
Merged via the queue into main with commit 6aca0ce Apr 25, 2025
32 checks passed
@underfin underfin deleted the fix-hmr-accpet-deps branch April 25, 2025 06:42
@sapphi-red sapphi-red mentioned this pull request Aug 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 21, 2025
@sapphi-red
test(hmr): import.meta.hot.accept cases (#5821)
94e7501 
refs #4104 #4314
close #4243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: import.meta.hot.accept(deps) panic

2 participants

@underfin @hyf0