Skip to content

Comments

feat(plugin/vite-resolve): port changes after Vite 6#4269

Merged
hyf0 merged 7 commits intomainfrom
feat/plugin-vite-resolve-align-with-vite-6
Apr 23, 2025
Merged

feat(plugin/vite-resolve): port changes after Vite 6#4269
hyf0 merged 7 commits intomainfrom
feat/plugin-vite-resolve-align-with-vite-6

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Apr 23, 2025 •
edited
Loading

@netlify
Copy link

netlify bot commented Apr 23, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b080ea5
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6808ce5c38a57c0008292f21

@netlify
Copy link

netlify bot commented Apr 23, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 59a9811
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6808cee51bd3460008776951

@sapphi-red sapphi-red marked this pull request as ready for review April 23, 2025 11:39
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025

Benchmarks Rust

  • target: main(f386130)
  • pr: feat/plugin-vite-resolve-align-with-vite-6(59a9811)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     70.1±0.73ms        ? ?/sec    1.00     69.6±1.68ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     92.0±0.87ms        ? ?/sec    1.00     92.1±1.33ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    104.8±1.19ms        ? ?/sec    1.00    105.0±1.45ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     80.3±0.88ms        ? ?/sec    1.02     81.8±1.29ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    120.4±0.94ms        ? ?/sec    1.00    119.1±1.28ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    193.8±1.82ms        ? ?/sec    1.00    191.7±3.28ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    227.8±2.72ms        ? ?/sec    1.03    233.7±1.37ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    134.0±2.51ms        ? ?/sec    1.00    132.0±2.30ms        ? ?/sec
bundle/bundle@threejs                                               1.00     40.6±0.53ms        ? ?/sec    1.02     41.5±0.79ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     84.2±0.84ms        ? ?/sec    1.01     85.2±0.72ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     99.6±1.59ms        ? ?/sec    1.00     99.8±0.71ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.4±0.37ms        ? ?/sec    1.07     50.8±1.36ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01    428.5±8.14ms        ? ?/sec    1.00    424.7±6.71ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1046.8±12.60ms        ? ?/sec    1.00   1047.5±6.24ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1222.4±7.85ms        ? ?/sec    1.00   1225.9±9.91ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    499.2±4.57ms        ? ?/sec    1.00    496.4±3.72ms        ? ?/sec
remapping/remapping                                                 1.00     25.1±0.10ms        ? ?/sec    1.08     27.0±0.72ms        ? ?/sec
remapping/render-chunk-remapping                                    1.10     71.2±5.52ms        ? ?/sec    1.00     64.6±0.32ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     98.0±3.05ms        ? ?/sec    1.00     97.8±3.15ms        ? ?/sec
scan/scan@threejs                                                   1.01     31.1±0.93ms        ? ?/sec    1.00     30.9±0.31ms        ? ?/sec
scan/scan@threejs10x                                                1.00    314.2±4.25ms        ? ?/sec    1.00    314.3±2.70ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Apr 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2025
@hyf0 hyf0 added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit 7c1fae3 Apr 23, 2025
29 checks passed
@hyf0 hyf0 deleted the feat/plugin-vite-resolve-align-with-vite-6 branch April 23, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @hyf0