Skip to content

Comments

fix(hmr): export full reload info if reach to hmr root#4242

Merged
hyf0 merged 1 commit intomainfrom
fix-hmr-root
Apr 22, 2025
Merged

fix(hmr): export full reload info if reach to hmr root#4242
hyf0 merged 1 commit intomainfrom
fix-hmr-root

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Apr 22, 2025 •
edited
Loading

Description

close #4068.

For the test, tracking at here #4243. I test it at vitejs/rolldown-vite@c1edfee

@netlify
Copy link

netlify bot commented Apr 22, 2025

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 998b664
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6807533a2c4a3b0008335f61
😎 Deploy Preview https://deploy-preview-4242--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@underfin underfin enabled auto-merge April 22, 2025 08:41
@underfin underfin added this pull request to the merge queue Apr 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     70.3±1.65ms        ? ?/sec    1.05     73.6±3.35ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     92.8±1.38ms        ? ?/sec    1.02     94.7±1.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    106.0±1.54ms        ? ?/sec    1.01    106.8±1.06ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     81.1±2.20ms        ? ?/sec    1.02     82.7±1.07ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    121.0±1.71ms        ? ?/sec    1.00    121.5±1.27ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    194.1±2.80ms        ? ?/sec    1.02    198.8±3.22ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    236.6±2.64ms        ? ?/sec    1.01    239.5±3.96ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    131.1±1.69ms        ? ?/sec    1.03    134.5±1.98ms        ? ?/sec
bundle/bundle@threejs                                               1.02     41.7±0.99ms        ? ?/sec    1.00     40.9±0.42ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     85.6±0.54ms        ? ?/sec    1.00     85.3±2.44ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    100.2±0.84ms        ? ?/sec    1.00    100.0±0.88ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     48.1±0.61ms        ? ?/sec    1.00     47.4±0.36ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    423.0±4.17ms        ? ?/sec    1.00    424.8±4.68ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1050.2±7.19ms        ? ?/sec    1.01   1055.7±5.07ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1231.0±18.07ms        ? ?/sec    1.00   1234.4±5.61ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    493.7±2.98ms        ? ?/sec    1.01    498.2±3.96ms        ? ?/sec
remapping/remapping                                                 1.01     26.3±0.65ms        ? ?/sec    1.00     26.1±0.27ms        ? ?/sec
remapping/render-chunk-remapping                                    1.09     69.4±5.74ms        ? ?/sec    1.00     63.4±3.20ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     95.2±1.05ms        ? ?/sec    1.00     95.2±1.36ms        ? ?/sec
scan/scan@threejs                                                   1.01     31.6±1.05ms        ? ?/sec    1.00     31.4±1.25ms        ? ?/sec
scan/scan@threejs10x                                                1.00    314.9±3.76ms        ? ?/sec    1.00    313.8±3.81ms        ? ?/sec

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2025
@hyf0 hyf0 added this pull request to the merge queue Apr 22, 2025
Merged via the queue into main with commit 9b57bd3 Apr 22, 2025
34 checks passed
@hyf0 hyf0 deleted the fix-hmr-root branch April 22, 2025 10:13
@sapphi-red sapphi-red mentioned this pull request Aug 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 21, 2025
@sapphi-red
test(hmr): no boundary full reload case (#5819)
761c7d6 
refs #4068 #4242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: HMR not found boundaries should be trigger page reload

2 participants

@underfin @hyf0