Skip to content

Comments

perf: skip empty js hook for js plugin#4192

Merged
IWANABETHATGUY merged 1 commit intomainfrom
04-18-perf_skip_empty_js_hook_for_js_plugin
Apr 19, 2025
Merged

perf: skip empty js hook for js plugin#4192
IWANABETHATGUY merged 1 commit intomainfrom
04-18-perf_skip_empty_js_hook_for_js_plugin

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Apr 18, 2025 •
edited
Loading

With 1000 empty plugin(only have name), use 10000 case,

Main

Benchmark 1: node --run build:rolldown
  Time (mean ± σ):     953.0 ms ±   6.0 ms    [User: 15170.3 ms, System: 875.5 ms]
  Range (min … max):   947.8 ms … 959.5 ms    3 runs

chrome-trace json size:
image
This is only partial trace json file, I need to terminate it because it stuck my computer.

This branch

Benchmark 1: node --run build:rolldown
  Time (mean ± σ):     584.0 ms ±   6.7 ms    [User: 2775.2 ms, System: 1057.3 ms]
  Range (min … max):   577.2 ms … 590.5 ms    3 runs

Tracing chrome-json: 161MB

With zero plugin

Main

Benchmark 1: node --run build:rolldown
  Time (mean ± σ):     548.0 ms ±   6.9 ms    [User: 2439.8 ms, System: 926.7 ms]
  Range (min … max):   542.4 ms … 555.7 ms    3 runs

This branch

Benchmark 1: node --run build:rolldown
  Time (mean ± σ):     537.3 ms ±  12.8 ms    [User: 2450.7 ms, System: 1034.6 ms]
  Range (min … max):   527.7 ms … 551.9 ms    3 runs

This was referenced Apr 18, 2025
Merged
Merged
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Apr 18, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-perf_skip_empty_js_hook_for_js_plugin branch from 53714d5 to ceb7a07 Compare April 18, 2025 09:41
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(37e71eb)
  • pr: 04-18-perf_skip_empty_js_hook_for_js_plugin(dc81ecb)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     74.2±2.59ms        ? ?/sec    1.00     73.4±1.64ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.04    101.6±3.59ms        ? ?/sec    1.00     97.9±3.24ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.06    116.6±2.52ms        ? ?/sec    1.00    110.0±1.52ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.07     92.7±1.53ms        ? ?/sec    1.00     86.9±4.56ms        ? ?/sec
bundle/bundle@rome-ts                                               1.02    127.3±1.52ms        ? ?/sec    1.00    124.4±1.74ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    203.2±3.08ms        ? ?/sec    1.00    201.7±4.55ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.06   257.5±11.80ms        ? ?/sec    1.00    242.6±2.32ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    139.7±1.98ms        ? ?/sec    1.00    138.0±2.57ms        ? ?/sec
bundle/bundle@threejs                                               1.00     41.9±1.38ms        ? ?/sec    1.01     42.4±1.65ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     86.4±1.42ms        ? ?/sec    1.00     85.4±0.64ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.01    102.0±1.30ms        ? ?/sec    1.00    100.6±0.58ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.7±0.81ms        ? ?/sec    1.00     48.6±0.98ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01    437.2±3.31ms        ? ?/sec    1.00    434.6±3.34ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1086.4±8.23ms        ? ?/sec    1.01  1095.8±11.75ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1275.8±15.75ms        ? ?/sec    1.00   1273.2±8.88ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    512.4±6.04ms        ? ?/sec    1.01    516.8±7.02ms        ? ?/sec
remapping/remapping                                                 1.00     26.6±1.14ms        ? ?/sec    1.04     27.6±0.36ms        ? ?/sec
remapping/render-chunk-remapping                                    1.07     69.4±3.62ms        ? ?/sec    1.00     65.2±0.75ms        ? ?/sec
scan/scan@rome-ts                                                   1.02     98.7±3.74ms        ? ?/sec    1.00     96.4±1.90ms        ? ?/sec
scan/scan@threejs                                                   1.05     33.5±1.24ms        ? ?/sec    1.00     32.1±1.17ms        ? ?/sec
scan/scan@threejs10x                                                1.02    329.4±4.30ms        ? ?/sec    1.00    323.9±4.18ms        ? ?/sec

@underfin
Copy link
Contributor

underfin commented Apr 18, 2025

Awesome!

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 18, 2025 10:26
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-perf_skip_empty_js_hook_for_js_plugin branch from ceb7a07 to caf7e14 Compare April 19, 2025 02:46
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-perf_skip_empty_hook_with_hook_usage branch from 4d34042 to 5d1eddf Compare April 19, 2025 02:46
Base automatically changed from 04-18-perf_skip_empty_hook_with_hook_usage to main April 19, 2025 03:19
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-perf_skip_empty_js_hook_for_js_plugin branch 2 times, most recently from 80a825e to dc81ecb Compare April 19, 2025 03:20
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 19, 2025

Merge activity

  • Apr 18, 11:21 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@netlify
Copy link

netlify bot commented Apr 19, 2025

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 80a825e
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6803168c20a9270008f63ae5
😎 Deploy Preview https://deploy-preview-4192--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 19, 2025

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit dc81ecb
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/680316966e9d2e00080b30da
😎 Deploy Preview https://deploy-preview-4192--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 19, 2025
Merged via the queue into main with commit 5e53564 Apr 19, 2025
41 of 42 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 04-18-perf_skip_empty_js_hook_for_js_plugin branch April 19, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IWANABETHATGUY @underfin @hyf0