Skip to content

Comments

perf: skip empty hook with hook_usage meta#4187

Merged
IWANABETHATGUY merged 1 commit intomainfrom
04-18-perf_skip_empty_hook_with_hook_usage
Apr 19, 2025
Merged

perf: skip empty hook with hook_usage meta#4187
IWANABETHATGUY merged 1 commit intomainfrom
04-18-perf_skip_empty_hook_with_hook_usage

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Apr 18, 2025

Description

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Apr 18, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Apr 18, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY changed the title perf: skip empty hook with hook_usage perf: skip empty hook with hook_usage meta Apr 18, 2025
hyf0
hyf0 reviewed Apr 18, 2025
View reviewed changes
hyf0
hyf0 reviewed Apr 18, 2025
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-perf_skip_empty_hook_with_hook_usage branch from 9a60cf8 to a4d1117 Compare April 18, 2025 08:46
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 18, 2025 08:47
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(6f18af6)
  • pr: 04-18-perf_skip_empty_hook_with_hook_usage(5d1eddf)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.02     79.8±1.24ms        ? ?/sec    1.00     78.4±3.36ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00    100.3±1.53ms        ? ?/sec    1.00    100.8±3.40ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    113.8±2.34ms        ? ?/sec    1.01    115.0±3.05ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     87.8±1.93ms        ? ?/sec    1.01     89.1±2.90ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    127.9±2.78ms        ? ?/sec    1.01    129.2±3.46ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.05    233.8±4.72ms        ? ?/sec    1.00    222.6±9.11ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.05    269.5±4.46ms        ? ?/sec    1.00   256.3±11.27ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    140.0±2.10ms        ? ?/sec    1.00    140.6±2.83ms        ? ?/sec
bundle/bundle@threejs                                               1.03     44.8±4.02ms        ? ?/sec    1.00     43.5±0.89ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     88.9±3.28ms        ? ?/sec    1.01     90.2±3.51ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    104.4±1.33ms        ? ?/sec    1.02    106.8±3.73ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     49.1±0.31ms        ? ?/sec    1.01     49.5±0.43ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    434.7±4.47ms        ? ?/sec    1.00    435.5±7.43ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1066.0±8.64ms        ? ?/sec    1.00   1064.0±9.04ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01  1257.3±11.59ms        ? ?/sec    1.00  1248.8±11.56ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    512.6±4.57ms        ? ?/sec    1.00    512.7±8.34ms        ? ?/sec
remapping/remapping                                                 1.00     27.3±1.11ms        ? ?/sec    1.00     27.4±0.28ms        ? ?/sec
remapping/render-chunk-remapping                                    1.05     70.7±4.39ms        ? ?/sec    1.00     67.5±3.89ms        ? ?/sec
scan/scan@rome-ts                                                   1.03    102.6±1.56ms        ? ?/sec    1.00     99.9±2.14ms        ? ?/sec
scan/scan@threejs                                                   1.00     33.7±1.09ms        ? ?/sec    1.01     33.9±1.28ms        ? ?/sec
scan/scan@threejs10x                                                1.00    326.1±3.82ms        ? ?/sec    1.03    334.7±9.81ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-feat_add_hook_usage_meta branch 2 times, most recently from cec481c to 9b039e6 Compare April 18, 2025 09:05
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-perf_skip_empty_hook_with_hook_usage branch from a4d1117 to 4d34042 Compare April 18, 2025 09:05
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Apr 18, 2025
Merged
Base automatically changed from 04-18-feat_add_hook_usage_meta to main April 18, 2025 10:15
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 18, 2025
@hyf0 hyf0 added this pull request to the merge queue Apr 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 18, 2025
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-perf_skip_empty_hook_with_hook_usage branch from 4d34042 to 5d1eddf Compare April 19, 2025 02:46
@netlify
Copy link

netlify bot commented Apr 19, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5d1eddf
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/68030e8e6201670008d81879

@IWANABETHATGUY IWANABETHATGUY merged commit 37e71eb into main Apr 19, 2025
25 of 28 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 04-18-perf_skip_empty_hook_with_hook_usage branch April 19, 2025 03:19
@sapphi-red sapphi-red mentioned this pull request Jun 25, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 25, 2025
@sapphi-red @autofix-ci
perf: skip empty write bundle hook with hook_usage meta (#5057)
1bf31f8 
write bundle hook was missing `hook_usage` meta check. This PR adds
that.

refs #4187

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0