Skip to content

Comments

feat: add hook usage meta#4181

Merged
IWANABETHATGUY merged 1 commit intomainfrom
04-18-feat_add_hook_usage_meta
Apr 18, 2025
Merged

feat: add hook usage meta#4181
IWANABETHATGUY merged 1 commit intomainfrom
04-18-feat_add_hook_usage_meta

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Apr 18, 2025

Description

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Apr 18, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Apr 18, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 9b039e6
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/680215df705a580008ed2cfa
😎 Deploy Preview https://deploy-preview-4181--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-feat_add_hook_usage_meta branch 3 times, most recently from 0a76a90 to 3efb7a7 Compare April 18, 2025 07:24
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025 •
edited
Loading

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     75.1±1.52ms        ? ?/sec    1.00     75.2±1.28ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     95.9±1.99ms        ? ?/sec    1.01     97.0±4.21ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    109.7±1.76ms        ? ?/sec    1.00    109.4±3.02ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     85.9±3.73ms        ? ?/sec    1.00     86.2±3.11ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    124.2±2.20ms        ? ?/sec    1.01    124.8±2.10ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    202.5±2.22ms        ? ?/sec    1.02    207.5±6.49ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.05    251.4±6.40ms        ? ?/sec    1.00    239.6±2.84ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    136.9±1.82ms        ? ?/sec    1.01    138.4±2.11ms        ? ?/sec
bundle/bundle@threejs                                               1.00     42.9±2.03ms        ? ?/sec    1.01     43.5±1.67ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     86.2±1.16ms        ? ?/sec    1.01     87.1±0.78ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.01    103.6±1.85ms        ? ?/sec    1.00    102.5±1.21ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.9±0.53ms        ? ?/sec    1.01     49.5±0.63ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01   438.7±11.58ms        ? ?/sec    1.00    435.6±5.05ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1072.3±4.73ms        ? ?/sec    1.01  1086.1±28.45ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1267.5±13.37ms        ? ?/sec    1.01  1276.5±12.78ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    507.0±8.75ms        ? ?/sec    1.01    514.1±7.64ms        ? ?/sec
remapping/remapping                                                 1.02     26.8±1.38ms        ? ?/sec    1.00     26.3±0.45ms        ? ?/sec
remapping/render-chunk-remapping                                    1.08     71.1±5.77ms        ? ?/sec    1.00     65.7±2.62ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     97.3±1.24ms        ? ?/sec    1.00     96.3±1.26ms        ? ?/sec
scan/scan@threejs                                                   1.02     33.0±1.60ms        ? ?/sec    1.00     32.2±1.03ms        ? ?/sec
scan/scan@threejs10x                                                1.01    324.4±5.82ms        ? ?/sec    1.00    322.1±2.54ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-feat_add_hook_usage_meta branch from 3efb7a7 to a060e72 Compare April 18, 2025 08:06
@hyf0
Copy link
Member

hyf0 commented Apr 18, 2025

This is a great idea. I'm suffering from adding each hook s correpsondng method like enable_transform() -> bool.

hyf0
hyf0 reviewed Apr 18, 2025
View reviewed changes
hyf0
hyf0 reviewed Apr 18, 2025
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Apr 18, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 18, 2025 08:46
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-feat_add_hook_usage_meta branch from a060e72 to cec481c Compare April 18, 2025 09:03
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-18-feat_add_hook_usage_meta branch from cec481c to 9b039e6 Compare April 18, 2025 09:05
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Apr 18, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 18, 2025
Merged via the queue into main with commit 95255cf Apr 18, 2025
28 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 04-18-feat_add_hook_usage_meta branch April 18, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0