Skip to content

Comments

fix: avoid load again if load success at concurrent load#4156

Merged
underfin merged 1 commit intomainfrom
fix-load-concurrent
Apr 17, 2025
Merged

fix: avoid load again if load success at concurrent load#4156
underfin merged 1 commit intomainfrom
fix-load-concurrent

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Apr 17, 2025 •
edited
Loading

Description

close #4143.

I'm trying to add minimal reproduction test for it, but failed...

@netlify
Copy link

netlify bot commented Apr 17, 2025

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 0a0f976
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6800c4d56a9912000832fef3
😎 Deploy Preview https://deploy-preview-4156--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@underfin underfin enabled auto-merge April 17, 2025 09:19
@underfin underfin added this pull request to the merge queue Apr 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     75.2±2.97ms        ? ?/sec    1.03     77.9±2.30ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     97.4±2.29ms        ? ?/sec    1.00     96.0±2.33ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    110.1±1.71ms        ? ?/sec    1.03    113.4±3.48ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     86.8±1.98ms        ? ?/sec    1.03     89.3±1.89ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    123.9±1.52ms        ? ?/sec    1.03    127.6±1.85ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    205.1±5.36ms        ? ?/sec    1.13    231.1±5.02ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    236.7±3.27ms        ? ?/sec    1.11    262.6±7.64ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    137.9±3.30ms        ? ?/sec    1.04    142.7±2.53ms        ? ?/sec
bundle/bundle@threejs                                               1.00     42.0±1.13ms        ? ?/sec    1.06     44.3±0.54ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     85.9±2.17ms        ? ?/sec    1.03     88.1±0.73ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.02    104.7±2.56ms        ? ?/sec    1.00    102.3±1.31ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.9±0.45ms        ? ?/sec    1.04     49.6±0.60ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    439.3±4.70ms        ? ?/sec    1.00    441.1±7.74ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1069.9±16.77ms        ? ?/sec    1.02  1087.8±13.43ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1242.0±9.51ms        ? ?/sec    1.02   1263.1±9.04ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    511.5±6.79ms        ? ?/sec    1.01    517.5±8.46ms        ? ?/sec
remapping/remapping                                                 1.04     27.5±0.40ms        ? ?/sec    1.00     26.5±0.52ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     64.2±0.83ms        ? ?/sec    1.11     71.1±4.50ms        ? ?/sec
scan/scan@rome-ts                                                   1.00    103.0±1.96ms        ? ?/sec    1.00    102.6±1.84ms        ? ?/sec
scan/scan@threejs                                                   1.00     33.6±1.25ms        ? ?/sec    1.01     34.1±0.71ms        ? ?/sec
scan/scan@threejs10x                                                1.02    328.3±4.25ms        ? ?/sec    1.00    323.3±2.26ms        ? ?/sec

Merged via the queue into main with commit 821fc82 Apr 17, 2025
33 checks passed
@underfin underfin deleted the fix-load-concurrent branch April 17, 2025 09:34
@sapphi-red sapphi-red mentioned this pull request Sep 15, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Sep 16, 2025
@sapphi-red
refactor: wait this.load using futures instead of callbacks (#6222)
392ad04 
The code for `this.load` waited for the `markModuleLoaded` callback to be called. But this should be able to simplify by using a future.
This PR refactors the code for `this.load` to wait for a future instead. This should also improve the perf a bit because we no longer have to call `markModuleLoaded` for each module.
I wonder if I'm missing something.

refs #4156, #2777, #2772, #2687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Potential Freezing and Errors When Using rolldown-plugin-dts

2 participants

@underfin @hyf0